Docker build for the revised ITs #12707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-rogers
force-pushed
the
220624-image
branch
from
dcfbbc8
to
a816e30
Compare
clintropolis
added
Area - Testing
Area - Dev
paul-rogers
force-pushed
the
220624-image
branch
from
c4973dd
to
3e53834
Compare
kfaraz
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Thanks for extracting this into a smaller PR, @paul-rogers !
The changes look good to me.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -e |
There was a problem hiding this comment.
Maybe we should add a one-line description for each of these scripts either in the respective files or in a single README.
There was a problem hiding this comment.
Good idea. Added documentation to the scripts in this PR. The markdown files will appear in a future PR: I'll update the list of scripts in those files as well.
|
@kfaraz, thanks much for the final review! The final commit updates script documentation as you suggested. Changing script comments should not break anything, but Travis will do its thing anyway. Let's hope we get lucky and don't hit any flaky tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the Docker image build for the revised ITs. Split out from PR #12368 to simplify review and merge.
This PR contains two items:
it-toolswhich defines the IT test extensions that are added into the IT Docker image. These are the same as what theintegration-testsproject provides, just built separately and packaged so they can be added to the image.it-toolsis built as part of the Maven build, afterdistribution. Its output is an extension jar. No harm in including it even in non-IT builds.it-imagewhich builds the Docker image. It is activated by thetest-imageprofile.In addition,
.travis.ymlis modified to run the Docker image to show that it builds. Nothing uses the image, that will come when #12368 is merged. We're just proving that that the build works to assure reviewers that things are correct.The changes here have already been reviewed as part of #12368. This is a subset of those changes. The test themselves, and the documentation, is omitted to keep the PR small.
This PR has: