Add validation for invalid partitioned by granularities #12589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoe
reviewed
Jun 1, 2022
| if(!GranularityType.isStandard(granularity)) | ||
| { | ||
| throw new IAE("The granularity specified in PARTITIONED BY is not supported. " | ||
| + "Please use a standard granularity."); |
There was a problem hiding this comment.
What does standard granularity mean? How does the user know that these are the granularities I can use. _
There was a problem hiding this comment.
Good point, does simple granularities seem more appropriate? https://druid.apache.org/docs/latest/querying/granularities.html
There was a problem hiding this comment.
IMHO I would map GranularityType.values() to period and then use a string Joiner with "," and put that in the exception message.
cryptoe
reviewed
Jun 2, 2022
sql/src/main/codegen/config.fmpp
Outdated
| @@ -55,7 +55,9 @@ data: { | |||
| "org.apache.calcite.sql.SqlNode" | |||
| "org.apache.calcite.sql.SqlInsert" | |||
| "org.apache.druid.java.util.common.granularity.Granularity" | |||
| "org.apache.druid.java.util.common.granularity.GranularityType" | |||
There was a problem hiding this comment.
Nit: do you still need granularity type here.
abhishekagarwal87
approved these changes
Jun 6, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is in continuation to #12580 and rejects the ingest queries with
PARTITIONED BYgranularities that are not supported. For example queries withPARTITIONED BYclause set toTIME_FLOOR(__time, 'PT2H')are rejected in the validation layer itself. Unit tests for the same have been added.This PR has: