Improve build performance of modules #12486
Conversation
| @@ -41,12 +41,12 @@ | |||
| <version>${project.parent.version}</version> | |||
| <scope>provided</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <!-- <dependency> | |||
There was a problem hiding this comment.
it's better to remove it directly from the file.
server/pom.xml
Outdated
| @@ -49,12 +49,12 @@ | |||
| <version>${project.parent.version}</version> | |||
| <scope>runtime</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <!-- <dependency> | |||
| <artifactId>druid-console</artifactId> | ||
| <version>${project.parent.version}</version> | ||
| <scope>runtime</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Heads up: I am reverting this change here 592ddd4
Removing the druid-console dependency makes the web console no longer be part of Druid...
The e2e tests do not run unless there are JS changes which is how this PR passed CI. I was struggling to figure out why my console PR (#12489) was failing to even start the e2e tests when it turned out that the console was just gone...
So I am adding this dependency back. Fun fact, my PR (linked above) will actually improve the console build speed a little bit by removing the stylus dependency but obviously not as much as not building the console all together.
There was a problem hiding this comment.
Based on ^, I think maybe we should consider running web e2e tests on java changes, instead of just web-console changes.
There was a problem hiding this comment.
Running web e2e tests on java changes may be too burden. IMO, we can add one test case to check if localhost:888/unified-console.html returns HTTP 200.
There was a problem hiding this comment.
@vogievetsky Do you mean the druid-console.jar is missing in the distribution package after deleting the depedency declaration from server/pom.xml ?
There was a problem hiding this comment.
The final distribution package is packaged by maven-assembly-plugin. I think we can make some modifications to the assembly file under distribution/src/assembly/assembly.xml to include the druid-console module in the final package. If it's viable, we don't need to include druid-console module in the druid-server module which really looks a little bit strange.
Fixes #12485
Description
Removing unused dependencies between modules can improved parallelism of parallel builds.
This PR has: