Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit vectorized metric dimension by default #12464

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

rohangarg
Copy link
Member

Vectorized metric will help in knowing more information about the performance profile of a workload

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! This will be helpful in bringing more visibility into what types of queries could benefit from being optimized 👍

@suneet-s
Copy link
Contributor

Marked as release notes as users may want to know about this new dimension. The release manager should feel free to choose to exclude this from the release notes if they decide it isn't necessary.

@suneet-s suneet-s merged commit 4c6ba73 into apache:master Apr 21, 2022
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants