Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update log4j to 2.15.0 to address security vulnerabilities #12051

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

xvrl
Copy link
Member

@xvrl xvrl commented Dec 10, 2021

fixes #12050

@xvrl xvrl merged commit 1931601 into apache:master Dec 10, 2021
@xvrl xvrl deleted the update-log4j2 branch December 10, 2021 06:34
@FrankChen021
Copy link
Member

@xvrl You're so quick. Why can't I find the 2.15.0 artifact on the mvnrepository.com?

@clintropolis
Copy link
Member

it probably hasn't propagated to all of the mirrors yet, I see it here https://search.maven.org/search?q=g:org.apache.logging.log4j

@a2l007
Copy link
Contributor

a2l007 commented Dec 10, 2021

Not sure if we know at this point if 2.15.0 will completely resolve this issue, but operators must be setting -Dlog4j2.formatMsgNoLookups=true in their jvm args meanwhile.

@suneet-s
Copy link
Contributor

log4j's official announcement is here https://lists.apache.org/thread/bfnl1stql187jytr0t5k0hv0go6b76g4

Based on this, operators could add %m{nolookups} to the PatternLayout in log4j2.xml since we use log4j version 2.8.2 -Dlog4j2.formatMsgNoLookups=true will not work

@a2l007
Copy link
Contributor

a2l007 commented Dec 10, 2021

Thanks for clarifying @suneet-s

@dongjoon-hyun
Copy link
Member

Thank you all!

nikhil-ddu pushed a commit to twitter-forks/druid that referenced this pull request Dec 13, 2021
nikhil-ddu pushed a commit to twitter-forks/druid that referenced this pull request Dec 13, 2021
@GElkayam
Copy link

GElkayam commented Dec 15, 2021

@xvrl , @clintropolis , Is this going to get updated to 2.16 to mitigate CVE-2021-45046?
Nevermind, addressed in #12061

@FrankChen021
Copy link
Member

@GElkayam I checked the description of that CVE. If I understand correctly, this vulnerability exists when thread context map pattern layout is applied.

Since Druid's default log4j2 configuration does not use such pattern layout, I think it's not affected by this problem.

This could allow attackers with control over Thread Context Map (MDC) input data when the logging configuration uses a non-default Pattern Layout with either a Context Lookup (for example, $${ctx:loginId}) or a Thread Context Map pattern (%X, %mdc, or %MDC) to craft malicious input data using a JNDI Lookup pattern resulting in a denial of service (DOS) attack.

debasatwa29 pushed a commit to debasatwa29/druid that referenced this pull request Jun 2, 2022
…ilities

Summary:
Druid is running with JVM 1.8.0_232 but log4j 2.5 so it's P1 rather than p0.

Pull upstream to upgrade log4j to 2.15.0 to address security vulnerabilities

Changes are from the following upstream PRs:

# Upgrade log4j from 2.8.2 to 2.15.0
apache#12051
apache#12056

# Upgrade log4j from 2.5 to 2.8.2
apache#8878

Reviewers: O1139 Druid, jgu, itallam

Reviewed By: O1139 Druid, jgu, itallam

Subscribers: jenkins, shawncao, #realtime-analytics

Differential Revision: https://phabricator.pinadmin.com/D823708
anishanagarajan pushed a commit to twitter-forks/druid that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommended to upgrade log4j to 2.15.0
9 participants