Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct DimensionSpec with for column value selectors created from dictionary encoded column indexers #11873

Merged
merged 4 commits into from
Nov 5, 2021
Merged

use correct DimensionSpec with for column value selectors created from dictionary encoded column indexers #11873

merged 4 commits into from
Nov 5, 2021

Conversation

clintropolis
Copy link
Member

@clintropolis clintropolis commented Nov 3, 2021 •
edited
Loading

Description

Follow-up to #11829, this modifies DimensionHandler to allow defining a DimensionSpec appropriate for the type of dimension being handled, which is now used DictionaryEncodedColumnIndexer.makeColumnValueSelector, so that more type appropriate column selectors can be created.

I also renamed BitmapIndexColumnPartSupplier to StringBitmapIndexColumnPartSupplier since it currently only works for string dictionary encoded columns (instead of making it generic and introducing additional virtual call-sites)

Key changed/added classes in this PR
  • DimensionHandler

This PR has:

  • been self-reviewed.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@clintropolis clintropolis changed the title allow dictionary encoded columns with non-string dictionaries to use bitmap index use correct DimensionSpec with for column value selectors created from dictionary encoded column indexers Nov 5, 2021
@clintropolis clintropolis merged commit 907e4ca into apache:master Nov 5, 2021
@clintropolis clintropolis deleted the generic-dictionary-encoded-column-indexes-pt-1 branch November 5, 2021 08:51
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
@abhishekagarwal87 abhishekagarwal87 mentioned this pull request May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoonson jihoonson jihoonson approved these changes

Assignees
No one assigned
Labels
Area - Segment Format and Ser/De
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clintropolis @jihoonson @abhishekagarwal87