-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 Ingestion from non-default endpoints #11798
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0e305e5
Add endpoint support for s3inputsource
a2l007 098212e
Merge branch 'master' of github.com:apache/druid into s3_external
a2l007 1207d72
Merge branch 'master' of github.com:apache/druid into s3_external
a2l007 4be3d05
Changes to tests
a2l007 a19a2cd
Fix docs
a2l007 f0d0e47
Fix config
a2l007 c3c29a5
Fix inspections
a2l007 e6d2a9f
Fix spelling
a2l007 d413f22
Remove password from toString
a2l007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -943,13 +943,55 @@ Sample specs: | |
}, | ||
... | ||
``` | ||
```json | ||
... | ||
"ioConfig": { | ||
"type": "index_parallel", | ||
"inputSource": { | ||
"type": "s3", | ||
"uris": ["s3://foo/bar/file.json", "s3://bar/foo/file2.json"], | ||
"endpointConfig": { | ||
"url" : "s3-store.aws.com", | ||
"signingRegion" : "us-west-2" | ||
}, | ||
"clientConfig": { | ||
"protocol" : "http", | ||
"disableChunkedEncoding" : true, | ||
"enablePathStyleAccess" : true, | ||
"forceGlobalBucketAccessEnabled" : false | ||
}, | ||
|
||
"proxyConfig": { | ||
"host" : "proxy-s3.aws.com", | ||
"port" : 8888, | ||
"username" : "admin", | ||
"password" : "admin" | ||
}, | ||
|
||
"properties": { | ||
"accessKeyId": "KLJ78979SDFdS2", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replace with xxxx or something ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for taking a look. These are fake credentials. |
||
"secretAccessKey": "KLS89s98sKJHKJKJH8721lljkd", | ||
"assumeRoleArn": "arn:aws:iam::2981002874992:role/role-s3" | ||
} | ||
}, | ||
"inputFormat": { | ||
"type": "json" | ||
}, | ||
... | ||
}, | ||
... | ||
``` | ||
|
||
|
||
|property|description|default|required?| | ||
|--------|-----------|-------|---------| | ||
|type|This should be `s3`.|None|yes| | ||
|uris|JSON array of URIs where S3 objects to be ingested are located.|None|`uris` or `prefixes` or `objects` must be set| | ||
|prefixes|JSON array of URI prefixes for the locations of S3 objects to be ingested. Empty objects starting with one of the given prefixes will be skipped.|None|`uris` or `prefixes` or `objects` must be set| | ||
|objects|JSON array of S3 Objects to be ingested.|None|`uris` or `prefixes` or `objects` must be set| | ||
| endpointConfig |Config for overriding the default S3 endpoint and signing region. This would allow ingesting data from a different S3 store. See below for more information.|None|No (defaults will be used if not given) | ||
| clientConfig |S3 client properties for the overridden s3 endpoint. This is used in conjunction with `endPointConfig`. Please see [s3 config](../development/extensions-core/s3.md#connecting-to-s3-configuration) for more information.|None|No (defaults will be used if not given) | ||
| proxyConfig |Properties for specifying proxy information for the overridden s3 endpoint. This is used in conjunction with `clientConfig`. Please see [s3 config](../development/extensions-core/s3.md#connecting-to-s3-configuration) for more information.|None|No (defaults will be used if not given) | ||
|properties|Properties Object for overriding the default S3 configuration. See below for more information.|None|No (defaults will be used if not given) | ||
|
||
Note that the S3 input source will skip all empty objects only when `prefixes` is specified. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: Should we toString the password here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, removed it.