Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protobuf use case document #11545

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

bananaaggle
Copy link
Contributor

@bananaaggle bananaaggle commented Aug 4, 2021

Now we have protobuf inputformat, and protobuf parser will be deprecated. So we should change document to follow it. Actually, because of 10647, supervisor properties with parser not work in 'Load data' tab in frontend, as described in 11537.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bananaaggle

@suneet-s
Copy link
Contributor

suneet-s commented Aug 5, 2021

@bananaaggle Do you think you could take a stab at fixing the web-console to use the inputFormat instead of the parser in a future change? I don't know a lot about front-end coding but that would be awesome for people to be able to use the UI instead of having to hand craft the ingestion spec. Thanks again for all your contributions!

@bananaaggle
Copy link
Contributor Author

bananaaggle commented Aug 6, 2021

@bananaaggle Do you think you could take a stab at fixing the web-console to use the inputFormat instead of the parser in a future change? I don't know a lot about front-end coding but that would be awesome for people to be able to use the UI instead of having to hand craft the ingestion spec. Thanks again for all your contributions!

Actually, all data formats in core extension have been adapted to inputformat. Only one thrift contrib-extension does not have implementation which is in processing in 11360. So in next release, users won't meet this trouble because them can use inputformat to ingest data with all formats. If you mean we should support parser in UI, I think it's easy to change front-end code and I can do it. But Because parser will be deprecated, so it's not necessary supporting it in front-end(new users will not use it through UI if we change user guide). If you think it's necessary to fix it for some old users, I'm glad to make this change.

@bananaaggle bananaaggle closed this Aug 6, 2021
@bananaaggle bananaaggle reopened this Aug 6, 2021
@suneet-s
Copy link
Contributor

suneet-s commented Aug 6, 2021

@bananaaggle Do you think you could take a stab at fixing the web-console to use the inputFormat instead of the parser in a future change? I don't know a lot about front-end coding but that would be awesome for people to be able to use the UI instead of having to hand craft the ingestion spec. Thanks again for all your contributions!

Actually, all data formats in core extension have been adapted to inputformat. Only one thrift contrib-extension does not have implementation which is in processing in 11360. So in next release, users won't meet this trouble because them can use inputformat to ingest data with all formats. If you mean we should support parser in UI, I think it's easy to change front-end code and I can do it. But Because parser will be deprecated, so it's not necessary supporting it in front-end(new users will not use it through UI if we change user guide). If you think it's necessary to fix it for some old users, I'm glad to make this change.

I misunderstood when I wrote my last comment - I thought the web console was generating a deprecated parse spec when users selected protobuf, avro, etc. I agree with you that since the parser will be deprecated, it's not necessary to support it in the front-end.

@suneet-s suneet-s merged commit 59c8430 into apache:master Aug 6, 2021
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants