fix compression-strategy-test (#12575)

fixes an issue caused by a test modification in #12408 that was closing buffers allocated by the compression strategy instead of allowing the closer to do it
apache · May 31, 2022 · 0640c9c · 0640c9c
1 parent 02ae3e7
commit 0640c9c
Showing 1 changed file with 9 additions and 15 deletions.
diff --git a/processing/src/test/java/org/apache/druid/segment/data/CompressionStrategyTest.java b/processing/src/test/java/org/apache/druid/segment/data/CompressionStrategyTest.java
@@ -126,21 +126,15 @@ public void testConcurrency() throws Exception
                                                                .allocateOutBuffer(originalData.length, closer);
                 ByteBuffer compressionIn = compressionStrategy.getCompressor()
                                                               .allocateInBuffer(originalData.length, closer);
-                try {
-                  compressionIn.put(originalData);
-                  compressionIn.position(0);
-                  ByteBuffer compressed = compressionStrategy.getCompressor().compress(compressionIn, compressionOut);
-                  ByteBuffer output = compressionStrategy.getCompressor().allocateOutBuffer(originalData.length, closer);
-                  compressionStrategy.getDecompressor().decompress(compressed, compressed.remaining(), output);
-                  byte[] checkArray = new byte[DATA_SIZER];
-                  output.get(checkArray);
-                  Assert.assertArrayEquals("Uncompressed data does not match", originalData, checkArray);
-                  return true;
-                }
-                finally {
-                  ByteBufferUtils.free(compressionIn);
-                  ByteBufferUtils.free(compressionOut);
-                }
+                compressionIn.put(originalData);
+                compressionIn.position(0);
+                ByteBuffer compressed = compressionStrategy.getCompressor().compress(compressionIn, compressionOut);
+                ByteBuffer output = compressionStrategy.getCompressor().allocateOutBuffer(originalData.length, closer);
+                compressionStrategy.getDecompressor().decompress(compressed, compressed.remaining(), output);
+                byte[] checkArray = new byte[DATA_SIZER];
+                output.get(checkArray);
+                Assert.assertArrayEquals("Uncompressed data does not match", originalData, checkArray);
+                return true;
               }
           )
       );