Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR UPDATE] use same version of commons-io in all drill projects #2955

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[MINOR UPDATE] use same version of commons-io in all drill projects #2955

merged 1 commit into from
Oct 22, 2024

Conversation

pjfanning
Copy link
Contributor

Relates to #2946 - but might be better to use same commons-io version in all Drill projects

@pjfanning
Copy link
Contributor Author

@cgivre @jnturton Is this PR ok - I prefer it to #2946

jnturton
jnturton approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@jnturton jnturton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better than #2946, thank you.

@cgivre
Copy link
Contributor

cgivre commented Oct 21, 2024

@pjfanning Are all packages using this version?

@pjfanning
Copy link
Contributor Author

@pjfanning Are all packages using this version?

The instance in this PR is the only one that does not use the commons-io.version

@cgivre cgivre merged commit cdb735e into master Oct 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnturton jnturton jnturton approved these changes

Assignees

@pjfanning pjfanning

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjfanning @cgivre @jnturton