Add threadSafe annotation to fmpp Maven Plugin #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this annotation Maven assumes the plugin is NOT threadsafe, and any parallel builds spews log warnings
|
I wasn't able to run the tests locally, (they just hung before getting to the fmpp module) |
|
@bdemers It looks like CI has passed. Could you please create an issue and we will merge this. |
cgivre
added
minor-update
backport-to-stable
Sorry... I should have been more clear. I meant a JIRA issue, but don't bother.. This is a minor update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this annotation Maven assumes the plugin is NOT threadsafe, and any parallel builds spews log warnings
Fixes: #2928