Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] #44505

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] #44505

wants to merge 2 commits into from

Conversation

zhiqiang-hhhh
Copy link
Contributor

No description provided.

@morningman @zhiqiang-hhhh
1
03b0f2f 
2

1

6

7

8

audit

audit

add ut

2

3

1

tmp fix
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

1 similar comment
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Nov 23, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/io/io_common.h
@@ -19,6 +19,8 @@

#include <gen_cpp/Types_types.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]

#include <gen_cpp/Types_types.h>
         ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@platoneko platoneko Awaiting requested review from platoneko platoneko will be requested when the pull request is marked ready for review platoneko is a code owner

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou will be requested when the pull request is marked ready for review gavinchou is a code owner

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring will be requested when the pull request is marked ready for review dataroaring is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiang-hhhh @doris-robot @morningman