-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](file_cache) Add config to enable base compaction output to file cache #44497
[opt](file_cache) Add config to enable base compaction output to file cache #44497
Conversation
… cache Previous implementation does not allow the output of base compaction write into file cache, which may have some performance penalty. This commit add a config to make that policy configurable. be.conf `enable_file_cache_keep_base_compaction_output` it is false by default. If your file cache is ample enough to accommodate all the data in your database, enable this option; otherwise, it is recommended to leave it disabled.
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39983 ms
|
TPC-DS: Total hot run time: 197082 ms
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 32.58 s
|
… cache (#44497) (#44496) Previous implementation does not allow the output of base compaction write into file cache, which may have some performance penalty. This commit add a config to make that policy configurable. be.conf `enable_file_cache_keep_base_compaction_output` it is false by default. If your file cache is ample enough to accommodate all the data in your database, enable this option; otherwise, it is recommended to leave it disabled. master branch PR #44497
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Previous implementation does not allow the output of base compaction write into file cache, which may have some performance penalty.
This commit add a config to make that policy configurable. be.conf
enable_file_cache_keep_base_compaction_output
it is false by default.If your file cache is ample enough to accommodate all the data in your database, enable this option; otherwise, it is recommended to leave it disabled.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)