Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](planner) NullLiteral should always having a correct Type and set to be analyzed #43370

Merged
merged 1 commit into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public NullLiteral() {
public static NullLiteral create(Type type) {
NullLiteral l = new NullLiteral();
l.type = type;
l.analysisDone();
return l;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ protected Expr uncheckedCastTo(Type targetType) throws AnalysisException {
return new FloatLiteral(Double.valueOf(value), targetType);
} catch (NumberFormatException e) {
// consistent with CastExpr's getResultValue() method
return new NullLiteral();
return NullLiteral.create(targetType);
}
case DECIMALV2:
case DECIMAL32:
Expand Down
4 changes: 4 additions & 0 deletions regression-test/data/insert_p0/test_insert_nan.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !select --
1 \N

34 changes: 34 additions & 0 deletions regression-test/suites/insert_p0/test_insert_nan.groovy
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

suite("test_insert_nan") {
sql """drop table if exists `nan_table`;"""

sql """
CREATE TABLE `nan_table` (
`id` int NOT NULL ,
`val` double,
) ENGINE=OLAP
UNIQUE KEY(`id`)
DISTRIBUTED BY HASH(`id`) BUCKETS 3
PROPERTIES("replication_num" = "1");
"""

sql """insert into nan_table values ('1', 'nan');"""

qt_select """select * from nan_table;"""
}
Loading