[fix](heartbeat) fix heartbeat editlog no persist hbTime #42653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
yujun777
force-pushed
the
fix-replay-lost-heartbeat-time
branch
from
f4e7ed1
to
3090bd4
Compare
|
run buildall |
TPC-H: Total hot run time: 41945 ms |
TPC-DS: Total hot run time: 196161 ms |
ClickBench: Total hot run time: 32.74 s |
|
run feut |
|
run p0 |
|
run feut |
|
run p0 |
yujun777
force-pushed
the
fix-replay-lost-heartbeat-time
branch
from
f267923
to
685260e
Compare
yujun777
changed the title
yujun777
requested review from
dataroaring,
CalvinKirs and
morningman
as code owners
|
run buildall |
TPC-H: Total hot run time: 40846 ms |
TPC-DS: Total hot run time: 191146 ms |
ClickBench: Total hot run time: 32.57 s |
yujun777
changed the title
|
run buildall |
yujun777
force-pushed
the
fix-replay-lost-heartbeat-time
branch
from
db6664c
to
f64d942
Compare
|
run buildall |
yujun777
force-pushed
the
fix-replay-lost-heartbeat-time
branch
from
f67fb4f
to
3621967
Compare
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 41385 ms |
gavinchou
reviewed
Oct 30, 2024
TPC-DS: Total hot run time: 192290 ms |
ClickBench: Total hot run time: 32.82 s |
yujun777
force-pushed
the
fix-replay-lost-heartbeat-time
branch
from
3621967
to
f9b4bfd
Compare
|
run buildall |
|
run performance |
2 similar comments
|
run performance |
|
run performance |
|
run buildall |
gavinchou
approved these changes
Oct 30, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
run performance |
TPC-H: Total hot run time: 41543 ms |
TPC-DS: Total hot run time: 196318 ms |
ClickBench: Total hot run time: 32.78 s |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
Backend persist lastUpdateMs, it will be modified by heartbeat editlog. But heartbeat editlog not persist hbTime, and hbTime always equal 0, it will make backend's lastUpdateMs = 0 in bdb image. fix details: 1. heartbeat response persist hbTime; 2. only be state change will write an editlog. but we make a change: even a backend is healthy, still write a healthy response editlog every 5 min. Inorder to make backend's lastUpdateMs periodly updated in bdb image. But notice that this change wouldn't increase real editlog num. Because heartbeat mgr will patch all fe/be's heartbeat into one editlog. Even no fe/be state change, it still write an editlog which not contains any node's response. 3. for a dead heartbeat response, set hbTime to last succ hbTime, then replayer can set correct lastUpdateMs;
dataroaring
pushed a commit
that referenced
this pull request
Nov 7, 2024
…42986) PR Body: Backend persist lastUpdateMs, it will be modified by heartbeat editlog. But heartbeat editlog not persist hbTime, and hbTime always equal 0, it will make backend's lastUpdateMs = 0 in bdb image. fix details: 1. heartbeat response persist hbTime; 2. only be state change will write an editlog. but we make a change: even a backend is healthy, still write a healthy response editlog every 5 min. Inorder to make backend's lastUpdateMs periodly updated in bdb image. But notice that this change wouldn't increase real editlog num. Because heartbeat mgr will patch all fe/be's heartbeat into one editlog. Even no fe/be state change, it still write an editlog which not contains any node's response. 3. for a dead heartbeat response, set hbTime to last succ hbTime, then replayer can set correct lastUpdateMs; Cherry-picked from #42653 Co-authored-by: yujun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend persist lastUpdateMs, it will be modified by heartbeat editlog. But heartbeat editlog not persist hbTime, and hbTime always equal 0, it will make backend's lastUpdateMs = 0 in bdb image.
fix details: