Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE can occur in the Response Path if MetricRepo is not initialized yet #42505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rijeshkp
Copy link
Contributor

@rijeshkp rijeshkp commented Oct 25, 2024

Proposed changes

Issue Number: close #44220

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@rijeshkp
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41386 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c0295db381a40ef503d3a22ccdd55a4f64bd8007, data reload: false

------ Round 1 ----------------------------------
q1	17568	7423	7287	7287
q2	2039	275	271	271
q3	12200	1073	1137	1073
q4	10577	840	802	802
q5	7744	3097	3024	3024
q6	233	150	144	144
q7	1021	617	604	604
q8	9355	1998	1983	1983
q9	6557	6489	6460	6460
q10	7077	2402	2420	2402
q11	428	235	238	235
q12	410	232	208	208
q13	17790	3019	3032	3019
q14	243	207	222	207
q15	556	495	513	495
q16	634	587	577	577
q17	968	559	572	559
q18	7195	6703	6751	6703
q19	1323	1083	865	865
q20	462	182	188	182
q21	3988	3281	3288	3281
q22	1129	1005	1026	1005
Total cold run time: 109497 ms
Total hot run time: 41386 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7329	7269	7233	7233
q2	324	230	231	230
q3	3082	2985	2937	2937
q4	2106	1839	1779	1779
q5	5757	5792	5789	5789
q6	236	148	143	143
q7	2223	1849	1767	1767
q8	3430	3543	3457	3457
q9	8949	8923	8957	8923
q10	3593	3531	3561	3531
q11	579	482	498	482
q12	850	612	616	612
q13	9629	3208	3188	3188
q14	296	277	273	273
q15	587	533	523	523
q16	693	640	622	622
q17	1891	1628	1613	1613
q18	8367	7851	7674	7674
q19	1720	1564	1547	1547
q20	2123	1881	1849	1849
q21	5650	5441	5478	5441
q22	1173	1104	1035	1035
Total cold run time: 70587 ms
Total hot run time: 60648 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191873 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c0295db381a40ef503d3a22ccdd55a4f64bd8007, data reload: false

query1	851	394	393	393
query2	6266	2121	2078	2078
query3	8676	202	197	197
query4	34178	23829	23656	23656
query5	4985	476	451	451
query6	294	186	179	179
query7	4195	296	296	296
query8	298	241	238	238
query9	9550	2715	2717	2715
query10	508	252	251	251
query11	18118	15308	15357	15308
query12	154	108	99	99
query13	1560	412	423	412
query14	9735	7499	6572	6572
query15	251	186	174	174
query16	8037	488	530	488
query17	1464	577	586	577
query18	2158	310	307	307
query19	359	159	161	159
query20	128	116	120	116
query21	205	104	108	104
query22	4592	4623	4541	4541
query23	34815	34090	34260	34090
query24	11071	2833	2847	2833
query25	623	409	398	398
query26	1167	160	167	160
query27	2310	279	280	279
query28	7644	2447	2445	2445
query29	830	417	415	415
query30	268	164	158	158
query31	1028	785	806	785
query32	96	57	56	56
query33	788	268	291	268
query34	919	521	512	512
query35	1070	899	882	882
query36	1092	960	965	960
query37	140	74	74	74
query38	4405	4269	4382	4269
query39	1539	1453	1442	1442
query40	207	101	103	101
query41	48	45	47	45
query42	109	99	100	99
query43	533	509	506	506
query44	1230	810	804	804
query45	184	166	165	165
query46	1148	721	695	695
query47	1933	1831	1816	1816
query48	412	319	325	319
query49	938	415	406	406
query50	818	395	431	395
query51	6997	6895	6957	6895
query52	100	89	88	88
query53	252	176	176	176
query54	1156	394	410	394
query55	80	77	74	74
query56	264	238	240	238
query57	1314	1154	1168	1154
query58	205	207	209	207
query59	3224	3021	3087	3021
query60	260	246	250	246
query61	103	97	100	97
query62	847	687	642	642
query63	215	193	190	190
query64	4050	628	617	617
query65	3297	3210	3253	3210
query66	813	297	306	297
query67	15895	15629	15625	15625
query68	4912	559	547	547
query69	444	256	262	256
query70	1223	1138	1145	1138
query71	348	249	254	249
query72	6245	4061	3971	3971
query73	768	353	373	353
query74	10540	8949	8943	8943
query75	3441	2714	2677	2677
query76	2788	961	941	941
query77	388	278	289	278
query78	10591	9548	9528	9528
query79	1086	598	605	598
query80	728	442	430	430
query81	546	253	242	242
query82	377	113	120	113
query83	172	139	134	134
query84	233	68	72	68
query85	1235	294	291	291
query86	391	287	281	281
query87	4889	4649	4743	4649
query88	3311	2212	2165	2165
query89	409	297	296	296
query90	2000	191	188	188
query91	138	105	111	105
query92	58	47	52	47
query93	1090	545	527	527
query94	856	281	295	281
query95	356	247	243	243
query96	616	279	278	278
query97	2917	2707	2695	2695
query98	208	198	208	198
query99	1557	1304	1336	1304
Total cold run time: 297860 ms
Total hot run time: 191873 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c0295db381a40ef503d3a22ccdd55a4f64bd8007, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.06	0.06
query4	1.64	0.10	0.10
query5	0.41	0.39	0.40
query6	1.17	0.65	0.67
query7	0.03	0.02	0.01
query8	0.04	0.03	0.05
query9	0.57	0.50	0.51
query10	0.56	0.55	0.54
query11	0.14	0.11	0.11
query12	0.13	0.11	0.11
query13	0.61	0.60	0.59
query14	2.80	2.77	2.73
query15	0.90	0.83	0.82
query16	0.39	0.38	0.39
query17	1.07	1.06	1.09
query18	0.20	0.19	0.20
query19	1.93	1.94	1.89
query20	0.01	0.02	0.01
query21	15.36	0.59	0.58
query22	2.22	3.00	1.70
query23	17.16	0.83	0.84
query24	3.23	1.41	0.78
query25	0.22	0.12	0.10
query26	0.58	0.13	0.14
query27	0.05	0.05	0.04
query28	10.66	1.08	1.07
query29	12.58	3.32	3.32
query30	0.24	0.06	0.07
query31	2.85	0.39	0.39
query32	3.24	0.46	0.46
query33	3.01	2.99	3.01
query34	17.05	4.48	4.55
query35	4.60	4.55	4.52
query36	0.68	0.49	0.50
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.15	0.12	0.12
query41	0.09	0.02	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.13 s
Total hot run time: 32.47 s

@rijeshkp
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41312 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c0295db381a40ef503d3a22ccdd55a4f64bd8007, data reload: false

------ Round 1 ----------------------------------
q1	17598	7408	7292	7292
q2	2017	287	276	276
q3	12192	1037	1201	1037
q4	10581	848	827	827
q5	7775	3079	3053	3053
q6	234	148	142	142
q7	1049	606	586	586
q8	9354	1915	1989	1915
q9	6494	6465	6434	6434
q10	7091	2387	2403	2387
q11	429	246	250	246
q12	426	221	209	209
q13	17793	3018	2973	2973
q14	241	211	209	209
q15	569	520	523	520
q16	662	592	589	589
q17	970	511	480	480
q18	7241	6751	6786	6751
q19	1320	1114	970	970
q20	484	179	183	179
q21	3940	3246	3258	3246
q22	1114	1028	991	991
Total cold run time: 109574 ms
Total hot run time: 41312 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7309	7243	7249	7243
q2	331	233	229	229
q3	3021	2970	2952	2952
q4	2077	1790	1779	1779
q5	5768	5766	5812	5766
q6	225	143	143	143
q7	2208	1809	1753	1753
q8	3378	3484	3472	3472
q9	8925	8914	8884	8884
q10	3590	3515	3544	3515
q11	576	497	477	477
q12	844	644	614	614
q13	10787	3175	3202	3175
q14	320	270	273	270
q15	568	523	527	523
q16	685	647	644	644
q17	1839	1621	1615	1615
q18	8306	7776	7461	7461
q19	1705	1476	1418	1418
q20	2135	1920	1826	1826
q21	5554	5466	5383	5383
q22	1177	1043	1048	1043
Total cold run time: 71328 ms
Total hot run time: 60185 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191223 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c0295db381a40ef503d3a22ccdd55a4f64bd8007, data reload: false

query1	844	407	396	396
query2	7211	2098	2080	2080
query3	8680	187	195	187
query4	34471	23760	23584	23584
query5	4538	446	451	446
query6	278	178	186	178
query7	4197	295	298	295
query8	300	235	241	235
query9	9507	2709	2705	2705
query10	481	257	245	245
query11	18258	15207	15406	15207
query12	149	104	97	97
query13	1594	443	411	411
query14	9304	7133	6430	6430
query15	246	174	173	173
query16	7882	489	498	489
query17	1402	593	584	584
query18	2137	304	308	304
query19	235	174	154	154
query20	125	118	115	115
query21	202	107	106	106
query22	4937	4607	4668	4607
query23	35123	33998	34129	33998
query24	11067	2820	2749	2749
query25	635	399	402	399
query26	1270	166	169	166
query27	2702	292	283	283
query28	7656	2434	2409	2409
query29	867	421	410	410
query30	270	160	157	157
query31	1021	779	786	779
query32	94	53	55	53
query33	778	258	283	258
query34	948	529	518	518
query35	1029	880	891	880
query36	1087	943	940	940
query37	132	73	76	73
query38	4458	4219	4277	4219
query39	1470	1424	1420	1420
query40	251	101	99	99
query41	49	46	46	46
query42	108	100	100	100
query43	541	476	494	476
query44	1282	802	804	802
query45	182	164	165	164
query46	1127	699	714	699
query47	1952	1850	1839	1839
query48	440	322	321	321
query49	943	413	403	403
query50	809	400	388	388
query51	7186	7041	6881	6881
query52	106	94	87	87
query53	254	180	182	180
query54	1161	402	398	398
query55	76	73	73	73
query56	257	235	240	235
query57	1292	1179	1177	1177
query58	216	197	201	197
query59	3199	2875	2969	2875
query60	268	243	239	239
query61	97	98	95	95
query62	870	680	669	669
query63	218	188	181	181
query64	4112	629	616	616
query65	3284	3200	3201	3200
query66	946	334	302	302
query67	16071	15720	15665	15665
query68	4691	566	543	543
query69	435	257	258	257
query70	1188	1155	1150	1150
query71	405	245	257	245
query72	6231	4047	3944	3944
query73	762	360	359	359
query74	10249	9097	8967	8967
query75	3415	2666	2688	2666
query76	2860	960	914	914
query77	391	265	274	265
query78	10585	9695	9599	9599
query79	1126	594	591	591
query80	742	409	439	409
query81	519	248	237	237
query82	719	111	113	111
query83	229	142	139	139
query84	243	67	67	67
query85	1052	290	279	279
query86	334	289	295	289
query87	5027	4722	4751	4722
query88	3456	2210	2165	2165
query89	390	290	284	284
query90	1978	188	186	186
query91	137	98	98	98
query92	55	48	49	48
query93	1075	525	524	524
query94	730	293	282	282
query95	346	240	242	240
query96	620	283	278	278
query97	2921	2720	2697	2697
query98	212	195	187	187
query99	1522	1335	1348	1335
Total cold run time: 299527 ms
Total hot run time: 191223 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c0295db381a40ef503d3a22ccdd55a4f64bd8007, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.64	0.10	0.11
query5	0.43	0.43	0.40
query6	1.16	0.65	0.66
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.57	0.53	0.51
query10	0.54	0.54	0.55
query11	0.14	0.11	0.10
query12	0.13	0.12	0.11
query13	0.60	0.61	0.60
query14	2.73	2.78	2.74
query15	0.90	0.83	0.81
query16	0.38	0.39	0.40
query17	0.99	0.97	1.00
query18	0.20	0.20	0.20
query19	1.89	1.83	1.84
query20	0.02	0.02	0.01
query21	15.37	0.59	0.58
query22	2.32	2.53	1.78
query23	17.27	0.96	0.76
query24	3.28	1.14	1.21
query25	0.21	0.14	0.08
query26	0.50	0.14	0.14
query27	0.06	0.05	0.04
query28	10.32	1.10	1.07
query29	12.57	3.32	3.30
query30	0.25	0.07	0.06
query31	2.85	0.40	0.38
query32	3.26	0.45	0.46
query33	2.99	3.03	3.03
query34	16.83	4.42	4.48
query35	4.49	4.49	4.48
query36	0.69	0.48	0.48
query37	0.08	0.06	0.05
query38	0.04	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.43 s
Total hot run time: 32.6 s

@rijeshkp rijeshkp marked this pull request as ready for review November 18, 2024 16:19
@rijeshkp
Copy link
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] NPE can occur in the Response Path if MetricRepo is not initialized yet
2 participants