Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](compile) fix lost header on arm platform #42475

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[Fix](compile) fix lost header on arm platform #42475

merged 1 commit into from
Oct 29, 2024

Conversation

zclllyybb
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9713/25932)
Line Coverage: 28.71% (80538/280547)
Region Coverage: 28.13% (41643/148018)
Branch Coverage: 24.69% (21157/85688)
Coverage Report: http://coverage.selectdb-in.cc/coverage/da09966ca8a29edf5abb6562ebf84fdb51f4602e_da09966ca8a29edf5abb6562ebf84fdb51f4602e/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41401 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0176e45f7331dc9c7b42e0b836f0f7cfb81dc6cc, data reload: false

------ Round 1 ----------------------------------
q1	17579	7358	7277	7277
q2	2037	276	281	276
q3	12401	1051	1244	1051
q4	10565	845	837	837
q5	7745	3088	3042	3042
q6	230	146	141	141
q7	1020	596	603	596
q8	9353	1956	1949	1949
q9	7178	6503	6445	6445
q10	7114	2414	2399	2399
q11	445	252	249	249
q12	409	215	210	210
q13	17778	3029	2976	2976
q14	236	209	211	209
q15	570	526	507	507
q16	657	593	585	585
q17	974	547	571	547
q18	7232	6728	6788	6728
q19	1341	1087	1035	1035
q20	457	187	181	181
q21	3995	3218	3165	3165
q22	1109	996	1011	996
Total cold run time: 110425 ms
Total hot run time: 41401 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7267	7233	7266	7233
q2	328	234	235	234
q3	3073	2962	2954	2954
q4	2118	1858	1794	1794
q5	5728	5758	5815	5758
q6	222	144	139	139
q7	2265	1843	1807	1807
q8	3379	3472	3483	3472
q9	8888	8863	8904	8863
q10	3603	3568	3537	3537
q11	583	501	496	496
q12	826	628	624	624
q13	9447	3195	3214	3195
q14	331	294	281	281
q15	566	513	523	513
q16	675	654	641	641
q17	1850	1621	1580	1580
q18	8358	7763	7691	7691
q19	1712	1698	1629	1629
q20	2130	1864	1871	1864
q21	5567	5538	5430	5430
q22	1147	1091	1060	1060
Total cold run time: 70063 ms
Total hot run time: 60795 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9713/25932)
Line Coverage: 28.72% (80576/280547)
Region Coverage: 28.14% (41646/148018)
Branch Coverage: 24.69% (21158/85688)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0176e45f7331dc9c7b42e0b836f0f7cfb81dc6cc_0176e45f7331dc9c7b42e0b836f0f7cfb81dc6cc/report/index.html

@zclllyybb
Copy link
Contributor Author

run arm

@doris-robot
Copy link

TPC-DS: Total hot run time: 192046 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0176e45f7331dc9c7b42e0b836f0f7cfb81dc6cc, data reload: false

query1	836	408	407	407
query2	6253	2116	2023	2023
query3	8672	197	205	197
query4	35318	24001	23719	23719
query5	5074	450	431	431
query6	274	169	164	164
query7	4202	294	286	286
query8	286	234	237	234
query9	9404	2672	2655	2655
query10	478	245	250	245
query11	18222	15218	15352	15218
query12	158	105	112	105
query13	1569	434	400	400
query14	9620	6956	7107	6956
query15	251	173	175	173
query16	7647	482	488	482
query17	1442	579	578	578
query18	2126	307	307	307
query19	372	179	178	178
query20	125	110	115	110
query21	210	118	112	112
query22	4827	4750	4950	4750
query23	34663	34165	34008	34008
query24	11003	2760	2781	2760
query25	613	403	382	382
query26	813	160	169	160
query27	2072	281	297	281
query28	6697	2443	2413	2413
query29	751	417	417	417
query30	258	159	159	159
query31	1026	779	817	779
query32	97	53	56	53
query33	768	282	284	282
query34	926	509	509	509
query35	1015	910	889	889
query36	1098	960	923	923
query37	115	74	77	74
query38	4475	4275	4368	4275
query39	1466	1412	1411	1411
query40	198	100	104	100
query41	50	48	48	48
query42	115	100	104	100
query43	522	490	488	488
query44	1255	818	808	808
query45	180	165	167	165
query46	1128	696	688	688
query47	1935	1842	1859	1842
query48	410	315	324	315
query49	901	417	395	395
query50	800	397	402	397
query51	7208	6871	6910	6871
query52	104	90	89	89
query53	251	183	183	183
query54	1248	418	415	415
query55	82	79	75	75
query56	270	263	248	248
query57	1314	1158	1189	1158
query58	216	197	198	197
query59	3198	3026	2873	2873
query60	263	245	250	245
query61	104	99	103	99
query62	840	655	675	655
query63	210	186	186	186
query64	4065	624	593	593
query65	3280	3199	3239	3199
query66	728	307	300	300
query67	15925	15767	15563	15563
query68	4460	564	551	551
query69	429	284	251	251
query70	1142	1165	1102	1102
query71	347	255	250	250
query72	6231	3962	3957	3957
query73	752	363	359	359
query74	10128	9028	9033	9028
query75	3401	2638	2663	2638
query76	2851	991	976	976
query77	390	266	279	266
query78	10562	9580	9709	9580
query79	2062	612	587	587
query80	1119	435	426	426
query81	576	240	245	240
query82	615	117	118	117
query83	235	137	133	133
query84	245	70	76	70
query85	1315	310	286	286
query86	440	303	296	296
query87	4864	4780	4813	4780
query88	3739	2215	2185	2185
query89	417	291	283	283
query90	2024	192	186	186
query91	134	104	102	102
query92	66	50	48	48
query93	2371	546	541	541
query94	925	295	294	294
query95	352	252	250	250
query96	617	277	283	277
query97	2946	2691	2717	2691
query98	213	204	201	201
query99	1561	1315	1295	1295
Total cold run time: 299551 ms
Total hot run time: 192046 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.96 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0176e45f7331dc9c7b42e0b836f0f7cfb81dc6cc, data reload: false

query1	0.03	0.03	0.04
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.65	0.11	0.11
query5	0.43	0.39	0.41
query6	1.15	0.65	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.51
query10	0.55	0.56	0.55
query11	0.15	0.12	0.14
query12	0.14	0.11	0.10
query13	0.62	0.60	0.60
query14	2.68	2.70	2.75
query15	0.90	0.82	0.85
query16	0.40	0.37	0.39
query17	0.96	1.09	0.98
query18	0.20	0.19	0.19
query19	1.95	1.88	2.00
query20	0.01	0.02	0.01
query21	15.40	0.61	0.59
query22	2.74	1.97	1.61
query23	17.08	0.95	0.81
query24	2.87	0.55	1.35
query25	0.15	0.08	0.04
query26	0.58	0.13	0.14
query27	0.04	0.06	0.04
query28	10.97	1.09	1.07
query29	12.59	3.32	3.34
query30	0.24	0.06	0.06
query31	2.87	0.38	0.39
query32	3.28	0.47	0.46
query33	3.02	3.00	3.07
query34	16.83	4.51	4.51
query35	4.55	4.50	4.54
query36	0.65	0.47	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.15	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 107.03 s
Total hot run time: 31.96 s

@zclllyybb
Copy link
Contributor Author

run arm

1 similar comment
@hello-stephen
Copy link
Contributor

run arm

dataroaring
dataroaring approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen hello-stephen merged commit 134d74c into apache:master Oct 29, 2024
24 of 27 checks passed
@zclllyybb zclllyybb deleted the fix_arm branch October 29, 2024 06:05
@zy-kkk zy-kkk mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

@platoneko platoneko Awaiting requested review from platoneko platoneko is a code owner

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zclllyybb @doris-robot @hello-stephen @dataroaring