Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](ip-function)improve is_ip_address_in_range for inverted index speed #41768

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[improve](ip-function)improve is_ip_address_in_range for inverted index speed #41768

merged 2 commits into from
Oct 16, 2024

Conversation

amorynan
Copy link
Contributor

Proposed changes

speed up is_ip_address_in_range with inverted index

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.43% (9679/25858)
Line Coverage: 28.67% (80253/279958)
Region Coverage: 28.11% (41527/147735)
Branch Coverage: 24.69% (21112/85504)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e4ee6a1f016145534da19b6b8b40ec38b32f8538_e4ee6a1f016145534da19b6b8b40ec38b32f8538/report/index.html

zzzxl1993
zzzxl1993 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@amorynan
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/functions/function_ip.h

size_t get_number_of_arguments() const override { return 2; }
Status evaluate_inverted_index(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'evaluate_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]

    Status evaluate_inverted_index(
           ^
Additional context

be/src/vec/functions/function_ip.h:641: 90 lines including whitespace and comments (threshold 80)

    Status evaluate_inverted_index(
           ^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25912)
Line Coverage: 28.73% (80603/280539)
Region Coverage: 28.18% (41708/148020)
Branch Coverage: 24.76% (21212/85678)
Coverage Report: http://coverage.selectdb-in.cc/coverage/75140747133e72cd0aa25f393db4dac0ea9e556d_75140747133e72cd0aa25f393db4dac0ea9e556d/report/index.html

airborne12
airborne12 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2024
@airborne12 airborne12 merged commit 39f4883 into apache:master Oct 16, 2024
25 of 27 checks passed
amorynan added a commit to amorynan/doris that referenced this pull request Oct 17, 2024
@amorynan
[improve](ip-function)improve is_ip_address_in_range for inverted ind…
6468703 
…ex speed (apache#41768)

## Proposed changes
speed up is_ip_address_in_range with inverted index
@amorynan amorynan mentioned this pull request Oct 17, 2024
Merged
eldenmoon pushed a commit that referenced this pull request Oct 17, 2024
@amorynan
[improve](ip-function)improve is_ip_address_in_range for inverted ind…
5982b01 
…ex speed

pick #41768
amorynan added a commit to amorynan/doris that referenced this pull request Oct 25, 2024
@amorynan
[improve](ip-function)improve is_ip_address_in_range for inverted ind…
e545a77 
…ex speed (apache#41768)

speed up is_ip_address_in_range with inverted index
@amorynan amorynan mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.3-merged p0_c reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amorynan @doris-robot @airborne12 @zzzxl1993 @shuke987 @eldenmoon