Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix](core) fmt lost one parameter #40914

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[bugfix](core) fmt lost one parameter #40914

merged 2 commits into from
Sep 18, 2024

Conversation

yiguolei
Copy link
Contributor

Proposed changes

bug is introduced by #40542

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yiguolei
Copy link
Contributor Author

run buildall

@yiguolei
Copy link
Contributor Author

run buildall

morningman
morningman approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TPC-H: Total hot run time: 41657 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e3bc592a7a157e64938f97f5f85cb2ba97be1f62, data reload: false

------ Round 1 ----------------------------------
q1	17557	7451	7267	7267
q2	2046	160	161	160
q3	10801	1083	1300	1083
q4	10521	736	808	736
q5	7768	3118	3087	3087
q6	241	147	146	146
q7	1020	622	609	609
q8	9467	2068	2079	2068
q9	6905	6450	6441	6441
q10	7030	2307	2305	2305
q11	440	248	251	248
q12	398	214	207	207
q13	17770	2981	2959	2959
q14	242	220	212	212
q15	581	533	522	522
q16	688	658	621	621
q17	997	825	865	825
q18	7439	6688	6723	6688
q19	1400	1078	1020	1020
q20	585	297	283	283
q21	3960	3259	3179	3179
q22	1119	1003	991	991
Total cold run time: 108975 ms
Total hot run time: 41657 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7234	7258	7234	7234
q2	326	229	227	227
q3	3083	2982	2964	2964
q4	2061	1875	1832	1832
q5	5615	5644	5651	5644
q6	238	147	140	140
q7	2217	1776	1769	1769
q8	3333	3465	3423	3423
q9	8841	8952	8766	8766
q10	3500	3463	3500	3463
q11	576	482	479	479
q12	849	638	626	626
q13	11798	3195	3132	3132
q14	292	271	280	271
q15	581	533	527	527
q16	727	659	662	659
q17	1819	1633	1597	1597
q18	8277	7692	8026	7692
q19	1754	1607	1578	1578
q20	2107	1906	1851	1851
q21	5621	5334	5728	5334
q22	1144	1075	1051	1051
Total cold run time: 71993 ms
Total hot run time: 60259 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.33% (9582/25666)
Line Coverage: 28.73% (79240/275856)
Region Coverage: 28.20% (41023/145456)
Branch Coverage: 24.82% (20904/84220)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e3bc592a7a157e64938f97f5f85cb2ba97be1f62_e3bc592a7a157e64938f97f5f85cb2ba97be1f62/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 199747 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e3bc592a7a157e64938f97f5f85cb2ba97be1f62, data reload: false

query1	1276	878	907	878
query2	6455	2115	2071	2071
query3	10832	3979	4082	3979
query4	64368	29875	23481	23481
query5	5104	472	494	472
query6	409	174	170	170
query7	5463	297	290	290
query8	316	220	216	216
query9	8494	2649	2651	2649
query10	433	286	272	272
query11	17719	15199	15679	15199
query12	154	106	104	104
query13	1452	421	404	404
query14	10754	7418	7591	7418
query15	213	178	182	178
query16	7173	458	499	458
query17	1096	592	585	585
query18	1715	301	300	300
query19	200	144	144	144
query20	133	116	109	109
query21	209	105	103	103
query22	4995	4588	4961	4588
query23	34993	33740	35028	33740
query24	6010	2853	2880	2853
query25	482	384	401	384
query26	637	160	152	152
query27	1781	277	284	277
query28	4088	2462	2416	2416
query29	643	402	399	399
query30	239	149	155	149
query31	928	771	792	771
query32	69	49	52	49
query33	424	284	281	281
query34	921	497	480	480
query35	853	738	731	731
query36	1040	951	929	929
query37	145	85	87	85
query38	4029	3860	3993	3860
query39	1458	1397	1421	1397
query40	201	91	93	91
query41	47	44	42	42
query42	114	99	102	99
query43	523	525	496	496
query44	1131	807	790	790
query45	193	158	160	158
query46	1108	774	753	753
query47	1952	1856	1896	1856
query48	458	367	364	364
query49	705	390	376	376
query50	839	402	398	398
query51	7003	6982	6837	6837
query52	96	89	85	85
query53	251	175	179	175
query54	563	465	463	463
query55	79	81	74	74
query56	293	271	267	267
query57	1214	1071	1114	1071
query58	230	245	237	237
query59	3283	3218	2986	2986
query60	292	279	284	279
query61	130	122	126	122
query62	741	673	668	668
query63	217	189	187	187
query64	1506	758	725	725
query65	3266	3170	3191	3170
query66	628	322	319	319
query67	16196	15525	15584	15525
query68	1209	876	876	876
query69	448	352	354	352
query70	1170	1195	1156	1156
query71	344	337	334	334
query72	5082	3637	3633	3633
query73	583	570	576	570
query74	9013	9070	8935	8935
query75	3077	2854	2860	2854
query76	1059	860	874	860
query77	449	356	361	356
query78	9505	9292	9340	9292
query79	909	894	877	877
query80	588	568	560	560
query81	463	252	254	252
query82	235	228	234	228
query83	158	158	157	157
query84	242	112	106	106
query85	643	373	390	373
query86	315	351	327	327
query87	4276	4295	4328	4295
query88	4235	4082	4068	4068
query89	366	362	359	359
query90	1258	305	311	305
query91	164	158	159	158
query92	71	70	73	70
query93	900	896	898	896
query94	502	356	365	356
query95	429	427	410	410
query96	491	488	491	488
query97	3163	3096	3129	3096
query98	230	223	217	217
query99	1430	1297	1299	1297
Total cold run time: 303969 ms
Total hot run time: 199747 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e3bc592a7a157e64938f97f5f85cb2ba97be1f62, data reload: false

query1	0.04	0.04	0.04
query2	0.06	0.02	0.02
query3	0.22	0.06	0.06
query4	1.64	0.10	0.10
query5	0.52	0.51	0.52
query6	1.12	0.72	0.71
query7	0.02	0.02	0.02
query8	0.03	0.03	0.03
query9	0.57	0.50	0.50
query10	0.55	0.57	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.10
query13	0.60	0.59	0.59
query14	3.05	3.00	2.97
query15	0.89	0.82	0.83
query16	0.38	0.40	0.38
query17	0.98	0.97	1.06
query18	0.20	0.19	0.20
query19	1.86	1.76	1.98
query20	0.01	0.01	0.01
query21	15.36	0.59	0.59
query22	2.37	2.21	1.63
query23	17.21	0.82	0.73
query24	2.87	0.94	1.76
query25	0.25	0.14	0.07
query26	0.49	0.13	0.13
query27	0.04	0.03	0.04
query28	10.13	1.10	1.07
query29	12.57	3.31	3.29
query30	0.23	0.06	0.05
query31	2.88	0.39	0.38
query32	3.26	0.47	0.46
query33	3.02	3.03	3.04
query34	16.82	4.36	4.44
query35	4.54	4.41	4.45
query36	0.66	0.51	0.50
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.15	0.12	0.14
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 106.18 s
Total hot run time: 32.4 s

@yiguolei yiguolei merged commit 241cb7a into apache:master Sep 18, 2024
25 of 30 checks passed
yiguolei added a commit that referenced this pull request Sep 23, 2024
@yiguolei @Doris-Extras
[bugfix](core) fmt lost one parameter (#40914)
0a35a87 
## Proposed changes

bug is introduced by #40542

<!--Describe your changes.-->

---------

Co-authored-by: yiguolei <[email protected]>
xinyiZzz pushed a commit to xinyiZzz/incubator-doris that referenced this pull request Oct 16, 2024
@yiguolei @Doris-Extras @xinyiZzz
[bugfix](core) fmt lost one parameter (apache#40914)
6466e61 
## Proposed changes

bug is introduced by apache#40542

<!--Describe your changes.-->

---------

Co-authored-by: yiguolei <[email protected]>
@xinyiZzz xinyiZzz mentioned this pull request Oct 16, 2024
Merged
yiguolei added a commit that referenced this pull request Oct 18, 2024
@xinyiZzz @yiguolei @Doris-Extras
[pick](branch-3.0) pick #40542 #40914 (#41973)
603823a 
pick #40542 #40914

---------

Co-authored-by: yiguolei <[email protected]>
Co-authored-by: yiguolei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yiguolei @doris-robot @morningman @HappenLee @Doris-Extras