Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](auth)Fix some issues with incorrect permission verification (#3… #40412

Merged
merged 3 commits into from
Sep 9, 2024
Merged

[fix](auth)Fix some issues with incorrect permission verification (#3… #40412

merged 3 commits into from
Sep 9, 2024

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Sep 5, 2024 •
edited
Loading

…9726)
pick: #39726

Due to significant differences, not pick Show data from db.table should be the permission to determine the table, not the admin permission,

@zddr
[fix](auth)Fix some issues with incorrect permission verification (ap…
0c20935 
…ache#39726)

- `show columns` do not have permission to check
- `show sync job`do not have permission to check
- `Show data from db.table` should be the permission to determine the
table, not the admin permission
- users with grant permission should not see all processes through 'SHOW
PROCESS LIST'
- `show tablet storage format`fix permission error prompt

cases will be added uniformly in other PRs
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zddr
Copy link
Contributor Author

zddr commented Sep 5, 2024

run buildall

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Sep 5, 2024
@zddr
Copy link
Contributor Author

zddr commented Sep 5, 2024

run buildall

@zddr
Copy link
Contributor Author

zddr commented Sep 5, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 48945 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 89414a72afeedf86e45c6d39eafe2e90b27f9807, data reload: false

------ Round 1 ----------------------------------
q1	17608	4418	4398	4398
q2	2099	153	145	145
q3	10454	1880	1919	1880
q4	10332	1250	1347	1250
q5	8519	3893	3865	3865
q6	229	123	121	121
q7	2030	1619	1613	1613
q8	9574	2727	2698	2698
q9	13667	10000	9681	9681
q10	8641	3509	3486	3486
q11	412	253	245	245
q12	465	301	300	300
q13	18379	3962	4010	3962
q14	354	320	324	320
q15	501	455	449	449
q16	547	452	451	451
q17	1150	990	967	967
q18	7245	6780	6978	6780
q19	1697	1578	1561	1561
q20	539	303	323	303
q21	4455	4141	4085	4085
q22	499	416	385	385
Total cold run time: 119396 ms
Total hot run time: 48945 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4294	4273	4304	4273
q2	322	226	217	217
q3	4143	4164	4111	4111
q4	2723	2730	2749	2730
q5	7122	7127	7078	7078
q6	237	124	122	122
q7	3223	2837	2862	2837
q8	4348	4500	4429	4429
q9	13608	13480	13476	13476
q10	4180	4220	4222	4220
q11	766	719	694	694
q12	1039	835	860	835
q13	6737	3744	3705	3705
q14	461	432	420	420
q15	502	460	461	460
q16	622	601	586	586
q17	3863	3790	3911	3790
q18	8843	8748	8818	8748
q19	1677	1655	1653	1653
q20	2394	2146	2112	2112
q21	8537	8550	8457	8457
q22	1035	927	953	927
Total cold run time: 80676 ms
Total hot run time: 75880 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 211687 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 89414a72afeedf86e45c6d39eafe2e90b27f9807, data reload: false

query1	937	392	411	392
query2	6526	2285	2028	2028
query3	6916	200	204	200
query4	23019	21696	21567	21567
query5	19726	6445	6500	6445
query6	296	230	231	230
query7	4336	296	326	296
query8	247	244	262	244
query9	3080	2679	2592	2592
query10	439	297	303	297
query11	15855	14929	15278	14929
query12	130	77	69	69
query13	1040	445	445	445
query14	17071	13190	13047	13047
query15	371	225	228	225
query16	6469	280	254	254
query17	1785	925	914	914
query18	889	307	316	307
query19	220	148	148	148
query20	79	79	76	76
query21	193	100	98	98
query22	5251	5011	4807	4807
query23	34234	33416	33507	33416
query24	7892	6273	6288	6273
query25	513	426	426	426
query26	1270	163	160	160
query27	2444	290	291	290
query28	6153	2284	2246	2246
query29	2871	2567	2854	2567
query30	250	172	167	167
query31	924	721	741	721
query32	70	62	58	58
query33	463	269	250	250
query34	887	466	473	466
query35	1122	919	884	884
query36	1236	1220	1330	1220
query37	178	58	58	58
query38	3018	2915	2918	2915
query39	1394	1316	1326	1316
query40	306	94	96	94
query41	39	36	36	36
query42	87	93	88	88
query43	726	594	694	594
query44	1182	718	716	716
query45	248	232	231	231
query46	1222	967	968	967
query47	2178	1731	1742	1731
query48	498	420	423	420
query49	657	377	399	377
query50	855	642	628	628
query51	4782	4618	4727	4618
query52	99	79	86	79
query53	228	190	186	186
query54	2650	2467	2449	2449
query55	95	84	88	84
query56	226	207	205	205
query57	1202	1149	1136	1136
query58	215	208	205	205
query59	3761	3095	3336	3095
query60	233	229	204	204
query61	101	96	99	96
query62	839	450	452	450
query63	199	177	170	170
query64	3571	1567	1453	1453
query65	3600	3523	3550	3523
query66	769	411	397	397
query67	15726	17079	15632	15632
query68	9227	683	657	657
query69	498	267	285	267
query70	1759	1396	1346	1346
query71	400	308	310	308
query72	6767	4784	4774	4774
query73	767	314	317	314
query74	6411	5803	5802	5802
query75	4939	3817	3638	3638
query76	4929	1148	1215	1148
query77	710	251	253	251
query78	12447	11696	12082	11696
query79	8328	634	638	634
query80	1225	378	393	378
query81	504	240	238	238
query82	1512	101	100	100
query83	180	136	134	134
query84	256	70	70	70
query85	881	313	321	313
query86	340	296	293	293
query87	3244	3022	3036	3022
query88	4447	2312	2297	2297
query89	472	303	305	303
query90	1924	205	209	205
query91	169	133	139	133
query92	58	54	50	50
query93	5683	607	611	607
query94	740	211	211	211
query95	2025	1917	1944	1917
query96	643	321	321	321
query97	6477	6306	6385	6306
query98	237	205	190	190
query99	2880	926	857	857
Total cold run time: 317167 ms
Total hot run time: 211687 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.55 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 89414a72afeedf86e45c6d39eafe2e90b27f9807, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.03	0.02
query3	0.24	0.05	0.04
query4	1.79	0.08	0.09
query5	0.53	0.52	0.53
query6	1.27	0.62	0.63
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.53	0.50	0.48
query10	0.54	0.54	0.53
query11	0.11	0.08	0.08
query12	0.12	0.09	0.09
query13	0.61	0.62	0.61
query14	0.78	0.80	0.78
query15	0.78	0.76	0.77
query16	0.38	0.37	0.38
query17	1.02	1.04	1.05
query18	0.23	0.26	0.25
query19	1.94	1.87	1.85
query20	0.02	0.01	0.01
query21	15.44	0.54	0.53
query22	2.13	1.89	1.78
query23	17.28	0.95	0.86
query24	6.85	0.70	1.26
query25	0.39	0.07	0.07
query26	0.70	0.17	0.16
query27	0.04	0.05	0.03
query28	6.30	0.78	0.70
query29	12.73	2.38	2.22
query30	0.59	0.53	0.54
query31	2.82	0.40	0.37
query32	3.39	0.50	0.49
query33	3.09	3.07	3.09
query34	15.25	4.79	4.81
query35	4.87	4.83	4.81
query36	1.04	1.02	1.01
query37	0.06	0.04	0.05
query38	0.03	0.02	0.02
query39	0.02	0.01	0.01
query40	0.15	0.13	0.15
query41	0.06	0.01	0.01
query42	0.02	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 104.31 s
Total hot run time: 30.55 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 89414a72afeedf86e45c6d39eafe2e90b27f9807 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

@morrySnow morrySnow merged commit c290dbb into apache:branch-2.0 Sep 9, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/planner Issues or PRs related to the query planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zddr @doris-robot @morrySnow