Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](Nereids) support parse sql with semicolon at beginning #39399

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[opt](Nereids) support parse sql with semicolon at beginning #39399

merged 1 commit into from
Aug 15, 2024

Conversation

morrySnow
Copy link
Contributor

For statement with semicolon at beginning like: ;SELECT 1; MySQL could not parse it, but legacy planner could

@morrySnow
[opt](Nereids) support parse sql with semicolon at beginning
053c197 
For statement with semicolon at beginning like: ;SELECT 1;
MySQL could not parse it, but legacy planner could
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37776 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 053c197a24f90c2522af7d5435c6afe1a1586a41, data reload: false

------ Round 1 ----------------------------------
q1	18050	4446	4368	4368
q2	2016	175	169	169
q3	10488	1136	1086	1086
q4	10151	676	690	676
q5	7740	2816	2708	2708
q6	227	142	142	142
q7	954	590	600	590
q8	9319	2026	2086	2026
q9	7236	6545	6583	6545
q10	7014	2239	2224	2224
q11	441	240	242	240
q12	390	226	219	219
q13	17772	2985	2950	2950
q14	277	237	239	237
q15	522	488	487	487
q16	480	396	390	390
q17	979	643	684	643
q18	7384	6893	6839	6839
q19	3859	1002	1110	1002
q20	729	323	332	323
q21	4436	2955	2903	2903
q22	1118	1009	1019	1009
Total cold run time: 111582 ms
Total hot run time: 37776 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4386	4262	4231	4231
q2	386	277	272	272
q3	2858	2642	2630	2630
q4	1897	1604	1565	1565
q5	5351	5387	5391	5387
q6	222	135	134	134
q7	2036	1705	1680	1680
q8	3166	3345	3331	3331
q9	8371	8354	8346	8346
q10	3382	3220	3160	3160
q11	601	506	491	491
q12	780	613	600	600
q13	16572	2983	2972	2972
q14	314	291	274	274
q15	529	469	469	469
q16	484	419	416	416
q17	1778	1492	1477	1477
q18	7672	7530	7521	7521
q19	1756	1542	1409	1409
q20	2016	1863	1785	1785
q21	5277	5028	5139	5028
q22	1111	1015	1020	1015
Total cold run time: 70945 ms
Total hot run time: 54193 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184280 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 053c197a24f90c2522af7d5435c6afe1a1586a41, data reload: false

query1	922	381	367	367
query2	6476	1924	1850	1850
query3	6650	209	216	209
query4	31580	23320	23069	23069
query5	4195	482	492	482
query6	294	171	182	171
query7	4592	295	297	295
query8	246	196	200	196
query9	8498	2450	2395	2395
query10	425	267	260	260
query11	15377	14834	15032	14834
query12	141	106	100	100
query13	1632	360	353	353
query14	9799	6882	6568	6568
query15	215	171	193	171
query16	7167	475	504	475
query17	1128	546	536	536
query18	1327	281	280	280
query19	183	145	138	138
query20	112	108	106	106
query21	203	98	98	98
query22	4298	4056	3930	3930
query23	33914	33223	33287	33223
query24	12193	2821	2877	2821
query25	648	384	373	373
query26	1580	153	149	149
query27	2929	271	277	271
query28	7629	2065	2038	2038
query29	964	406	417	406
query30	311	151	147	147
query31	997	735	747	735
query32	91	55	54	54
query33	748	280	275	275
query34	1006	473	483	473
query35	860	730	733	730
query36	1075	924	901	901
query37	133	79	83	79
query38	4012	3846	3802	3802
query39	1414	1365	1363	1363
query40	273	122	113	113
query41	45	45	48	45
query42	117	99	98	98
query43	497	469	466	466
query44	1248	734	734	734
query45	193	165	165	165
query46	1107	743	733	733
query47	1878	1788	1781	1781
query48	361	294	294	294
query49	1147	464	409	409
query50	799	413	404	404
query51	6898	6734	6707	6707
query52	106	91	89	89
query53	254	179	182	179
query54	1043	446	446	446
query55	79	73	75	73
query56	267	247	253	247
query57	1143	1041	1043	1041
query58	240	216	224	216
query59	2847	2649	2622	2622
query60	289	263	264	263
query61	101	96	101	96
query62	818	640	652	640
query63	213	188	185	185
query64	6541	2258	1725	1725
query65	3214	3137	3128	3128
query66	1260	327	345	327
query67	15217	14874	14853	14853
query68	4603	545	552	545
query69	407	266	266	266
query70	1157	1044	1099	1044
query71	387	297	276	276
query72	6528	2403	2154	2154
query73	758	318	321	318
query74	9215	8830	8702	8702
query75	3358	2696	2700	2696
query76	2797	1018	998	998
query77	461	311	318	311
query78	9719	9129	8951	8951
query79	2734	532	536	532
query80	2614	511	509	509
query81	614	228	225	225
query82	787	141	136	136
query83	308	158	157	157
query84	274	82	82	82
query85	2210	323	315	315
query86	487	313	309	309
query87	4573	4323	4169	4169
query88	3963	2346	2321	2321
query89	399	295	296	295
query90	1881	196	192	192
query91	128	106	108	106
query92	68	51	54	51
query93	2442	532	531	531
query94	971	293	304	293
query95	363	270	265	265
query96	599	268	275	268
query97	3225	3033	3028	3028
query98	221	203	202	202
query99	1616	1269	1231	1231
Total cold run time: 294026 ms
Total hot run time: 184280 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.62 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 053c197a24f90c2522af7d5435c6afe1a1586a41, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.08	0.08
query5	0.50	0.47	0.48
query6	1.14	0.73	0.74
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.55	0.50	0.49
query10	0.52	0.55	0.54
query11	0.15	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.61	0.58
query14	0.74	0.80	0.79
query15	0.87	0.83	0.82
query16	0.37	0.36	0.36
query17	0.96	0.96	1.05
query18	0.23	0.22	0.22
query19	1.85	1.67	1.71
query20	0.02	0.01	0.01
query21	15.40	0.73	0.64
query22	4.65	6.82	2.02
query23	18.29	1.38	1.25
query24	2.18	0.22	0.21
query25	0.15	0.08	0.08
query26	0.31	0.21	0.21
query27	0.45	0.23	0.23
query28	13.25	1.02	1.00
query29	12.57	3.34	3.26
query30	0.23	0.06	0.05
query31	2.87	0.39	0.40
query32	3.27	0.48	0.47
query33	2.98	2.99	2.92
query34	17.02	4.33	4.37
query35	4.45	4.48	4.37
query36	0.66	0.47	0.47
query37	0.19	0.16	0.16
query38	0.16	0.16	0.15
query39	0.04	0.03	0.04
query40	0.15	0.12	0.13
query41	0.09	0.05	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 110.18 s
Total hot run time: 30.62 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor Author

run cloud_p0

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2024
@morrySnow morrySnow merged commit 3df4b7f into apache:master Aug 15, 2024
28 of 29 checks passed
@morrySnow morrySnow deleted the semi_colon_begin branch August 15, 2024 12:33
morrySnow added a commit that referenced this pull request Aug 15, 2024
@morrySnow
[opt](Nereids) support parse sql with semicolon at beginning (#39399)
5f7552d 
pick from master #39399

For statement with semicolon at beginning like: ;SELECT 1; MySQL could
not parse it, but legacy planner could
@morrySnow morrySnow mentioned this pull request Aug 15, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 15, 2024
@morrySnow
[opt](Nereids) support parse sql with semicolon at beginning (apache#…
102fed8 
…39399)

pick from master apache#39399

For statement with semicolon at beginning like: ;SELECT 1; MySQL could
not parse it, but legacy planner could
@morrySnow morrySnow mentioned this pull request Aug 15, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) support parse sql with semicolon at beginning (#39399) (…
2890966 
…#39442)

pick from master #39399

For statement with semicolon at beginning like: ;SELECT 1; MySQL could
not parse it, but legacy planner could
morrySnow added a commit that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) support parse sql with semicolon at beginning (#39399) (…
f0da2ff 
…#39443)

pick from master #39399

For statement with semicolon at beginning like: ;SELECT 1;
MySQL could not parse it, but legacy planner could
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@morrySnow @dataroaring
[opt](Nereids) support parse sql with semicolon at beginning (#39399)
e9f1587 
For statement with semicolon at beginning like: ;SELECT 1; MySQL could
not parse it, but legacy planner could
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
@xiaokang xiaokang mentioned this pull request Sep 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seawinde seawinde seawinde approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morrySnow @doris-robot @starocean999 @seawinde @yiguolei @dataroaring