Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](inverted index)Add exception check when write bkd index (#39248) #39277

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Aug 13, 2024

bp #39248

…#39248)

We are not catching the exception when add values in `bkd_writer`, 
if error throws, BE will run into segment fault.
So we add the exception check here to avoid coredump.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@qidaye
Copy link
Contributor Author

qidaye commented Aug 13, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.53% (9319/25513)
Line Coverage: 28.01% (76336/272492)
Region Coverage: 26.82% (39212/146200)
Branch Coverage: 23.55% (19907/84526)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c2aaa62db2ed8ddeb55bd932242e3ba49a9e7a7f_c2aaa62db2ed8ddeb55bd932242e3ba49a9e7a7f/report/index.html

@yiguolei yiguolei merged commit 000ea20 into apache:branch-2.1 Aug 13, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants