Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] (topn) fix uncleared block in topn_next() (#39119) #39226

Merged
merged 1 commit into from
Aug 13, 2024
Merged

[fix] (topn) fix uncleared block in topn_next() (#39119) #39226

merged 1 commit into from
Aug 13, 2024

Conversation

csun5285
Copy link
Contributor

Proposed changes

pick from master #39119

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@csun5285
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 49653 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ce82c11d9e6f9cccdf1905bd9e460f1ff42a4f9d, data reload: false

------ Round 1 ----------------------------------
q1	17734	4404	4386	4386
q2	2045	157	153	153
q3	10280	1884	1987	1884
q4	10360	1214	1290	1214
q5	8660	3841	3928	3841
q6	236	123	125	123
q7	2090	1593	1609	1593
q8	9374	2723	2702	2702
q9	10637	10371	10191	10191
q10	8625	3548	3521	3521
q11	422	245	253	245
q12	474	306	308	306
q13	18405	3917	4011	3917
q14	351	326	323	323
q15	526	465	453	453
q16	671	569	571	569
q17	1127	977	971	971
q18	7327	6946	6827	6827
q19	1789	1661	1610	1610
q20	522	331	307	307
q21	4477	4154	4071	4071
q22	534	454	446	446
Total cold run time: 116666 ms
Total hot run time: 49653 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4337	4316	4288	4288
q2	320	224	221	221
q3	4183	4181	4160	4160
q4	2784	2725	2762	2725
q5	7145	7155	7074	7074
q6	234	118	120	118
q7	3199	2891	2836	2836
q8	4360	4467	4514	4467
q9	16945	16779	16680	16680
q10	4243	4275	4276	4275
q11	751	698	714	698
q12	1032	865	830	830
q13	7295	3727	3706	3706
q14	457	424	422	422
q15	498	458	458	458
q16	742	701	685	685
q17	3885	3913	3879	3879
q18	8737	8795	8921	8795
q19	1723	1724	1628	1628
q20	2382	2156	2124	2124
q21	8497	8570	8466	8466
q22	1032	985	1036	985
Total cold run time: 84781 ms
Total hot run time: 79520 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.72% (8105/21485)
Line Coverage: 29.36% (66419/226211)
Region Coverage: 28.86% (34258/118708)
Branch Coverage: 24.74% (17608/71168)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ce82c11d9e6f9cccdf1905bd9e460f1ff42a4f9d_ce82c11d9e6f9cccdf1905bd9e460f1ff42a4f9d/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 203527 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ce82c11d9e6f9cccdf1905bd9e460f1ff42a4f9d, data reload: false

query1	928	424	384	384
query2	6543	2747	2614	2614
query3	6925	204	196	196
query4	20176	18163	18057	18057
query5	19751	6565	6519	6519
query6	311	217	234	217
query7	4172	328	330	328
query8	423	432	394	394
query9	3167	2720	2672	2672
query10	416	292	296	292
query11	11302	10696	10643	10643
query12	128	83	75	75
query13	5610	708	703	703
query14	17711	13323	13685	13323
query15	361	249	257	249
query16	6477	283	261	261
query17	1723	1450	875	875
query18	2299	438	421	421
query19	209	155	153	153
query20	77	81	77	77
query21	189	97	90	90
query22	5261	5068	5040	5040
query23	32590	32005	32258	32005
query24	6955	6469	6513	6469
query25	528	441	431	431
query26	533	167	169	167
query27	1834	303	303	303
query28	6137	2393	2359	2359
query29	2798	2815	2857	2815
query30	242	171	174	171
query31	917	734	758	734
query32	73	62	61	61
query33	412	271	261	261
query34	841	486	491	486
query35	1130	847	909	847
query36	1362	1160	1114	1114
query37	89	62	64	62
query38	3094	2940	2958	2940
query39	1374	1330	1322	1322
query40	214	97	94	94
query41	48	45	44	44
query42	87	85	94	85
query43	704	721	720	720
query44	1150	721	737	721
query45	254	237	243	237
query46	1217	969	975	969
query47	1741	1827	1789	1789
query48	1020	718	712	712
query49	621	376	377	376
query50	869	644	606	606
query51	4824	4623	4632	4623
query52	113	76	81	76
query53	448	330	329	329
query54	2708	2484	2479	2479
query55	101	79	97	79
query56	239	230	221	221
query57	1271	1107	1102	1102
query58	214	214	212	212
query59	4183	3825	3939	3825
query60	216	201	206	201
query61	98	96	97	96
query62	793	531	461	461
query63	487	345	365	345
query64	2514	1546	1517	1517
query65	3635	3573	3541	3541
query66	798	384	386	384
query67	16658	16939	14931	14931
query68	9107	694	657	657
query69	567	353	340	340
query70	1743	1656	1382	1382
query71	415	317	310	310
query72	6548	3505	3495	3495
query73	739	327	321	321
query74	6281	5830	5880	5830
query75	5459	3709	3657	3657
query76	5645	1164	1230	1164
query77	947	260	263	260
query78	12719	11522	11828	11522
query79	7874	647	664	647
query80	1055	426	402	402
query81	496	246	231	231
query82	1675	96	96	96
query83	175	136	131	131
query84	260	71	71	71
query85	883	333	334	333
query86	337	303	282	282
query87	3294	3065	3012	3012
query88	4755	2309	2305	2305
query89	387	300	281	281
query90	1953	207	205	205
query91	180	143	139	139
query92	63	52	55	52
query93	5186	582	571	571
query94	700	218	212	212
query95	1125	1053	1060	1053
query96	642	335	329	329
query97	6509	6356	6416	6356
query98	179	173	175	173
query99	2897	854	803	803
Total cold run time: 313088 ms
Total hot run time: 203527 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ce82c11d9e6f9cccdf1905bd9e460f1ff42a4f9d, data reload: false

query1	0.02	0.02	0.02
query2	0.08	0.03	0.03
query3	0.25	0.04	0.04
query4	1.77	0.08	0.07
query5	0.54	0.53	0.52
query6	1.22	0.61	0.62
query7	0.02	0.01	0.01
query8	0.04	0.02	0.02
query9	0.52	0.48	0.48
query10	0.55	0.54	0.53
query11	0.12	0.09	0.08
query12	0.12	0.09	0.09
query13	0.63	0.62	0.62
query14	0.79	0.78	0.80
query15	0.78	0.77	0.75
query16	0.37	0.39	0.36
query17	1.02	1.04	1.00
query18	0.24	0.23	0.27
query19	1.92	1.85	1.82
query20	0.02	0.01	0.01
query21	15.46	0.56	0.57
query22	2.39	2.64	1.66
query23	16.97	0.99	0.81
query24	4.45	1.01	1.58
query25	0.38	0.05	0.06
query26	0.56	0.16	0.17
query27	0.05	0.04	0.04
query28	8.04	0.78	0.72
query29	12.64	2.11	2.16
query30	0.61	0.54	0.50
query31	2.82	0.39	0.37
query32	3.38	0.50	0.49
query33	3.08	3.06	3.08
query34	15.25	4.80	4.80
query35	4.86	4.86	4.86
query36	1.07	1.01	1.02
query37	0.06	0.04	0.05
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.13
query41	0.06	0.01	0.02
query42	0.02	0.01	0.01
query43	0.03	0.02	0.02
Total cold run time: 103.42 s
Total hot run time: 30.52 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit ce82c11d9e6f9cccdf1905bd9e460f1ff42a4f9d with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       21.7 seconds inserted 10000000 Rows, about 460K ops/s

airborne12
airborne12 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@airborne12 airborne12 merged commit 970cadd into apache:branch-2.0 Aug 13, 2024
22 of 27 checks passed
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 27, 2024
@csun5285
[fix] (topn) fix uncleared block in topn_next() (apache#39119) (apach…
9bbe777 
…e#39226)

## Proposed changes

pick from master apache#39119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csun5285 @doris-robot @airborne12