Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](compaction) fix mismatch between segment key and value column rows during compaction (#37960)(#38251)(#38356) #38835

Merged

Conversation

luwei16
Copy link
Contributor

@luwei16 luwei16 commented Aug 4, 2024

pick master #37960 #38251 #38356

…ows during compaction (apache#37960)

When a block is splitted to 3 segments, old code just handles 2 and the
last is overlowed.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@luwei16
Copy link
Contributor Author

luwei16 commented Aug 4, 2024

run buildall

Copy link
Contributor

github-actions bot commented Aug 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@luwei16
Copy link
Contributor Author

luwei16 commented Aug 5, 2024

run buildall

Copy link
Contributor

github-actions bot commented Aug 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring dataroaring changed the title [fix](compaction) fix mismatch between segment key and value column rows during compaction (#37960) [fix](compaction) fix mismatch between segment key and value column rows during compaction (#37960)(#38251)(#38356) Aug 5, 2024
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.42% (9267/25446)
Line Coverage: 27.94% (75801/271256)
Region Coverage: 26.79% (38991/145528)
Branch Coverage: 23.51% (19789/84170)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5ef1704860ecbe267be50d5673cd1166fbd15c7b_5ef1704860ecbe267be50d5673cd1166fbd15c7b/report/index.html

@dataroaring dataroaring merged commit 0f69a2a into apache:branch-2.1 Aug 5, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants