-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](info) processlist schema table support show all fe #38701
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
b9651bb
to
aa19e81
Compare
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
aa19e81
to
4a7c7e0
Compare
clang-tidy review says "All clean, LGTM! 👍" |
fe/fe-core/src/main/java/org/apache/doris/planner/SchemaScanNode.java
Outdated
Show resolved
Hide resolved
@@ -56,9 +56,20 @@ Status SchemaProcessListScanner::start(RuntimeState* state) { | |||
TShowProcessListRequest request; | |||
request.__set_show_full_sql(true); | |||
|
|||
TShowProcessListResult ret1; | |||
RETURN_IF_ERROR(SchemaHelper::show_process_list(*(_param->common_param->ip), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里没用了吧。
原来单独设置的fe ip是不是都在fe ip list 里了啊?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
主要是灰度升级有用,都放list里,灰度升级就查不到数据了
private void setOtherFeIp(TPlanNode msg) { | ||
if ("processlist".equals(tableName) && ConnectContext.get().getSessionVariable().showAllFeConnection) { | ||
List<String> feIpList = new ArrayList<>(); | ||
List<Pair<String, Integer>> ret = FrontendsProcNode.getFrontendWithRpcPort(Env.getCurrentEnv(), false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里直接把所有的fe ip 都放进去吧
BE 的逻辑改成,只要有这个,就忽略原来单独设置的fe ip和port
4a7c7e0
to
f84c158
Compare
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
&_process_list_result)); | ||
for (const auto& fe_ip : _param->common_param->fe_ip_list) { | ||
TShowProcessListResult tmp_ret; | ||
RETURN_IF_ERROR(SchemaHelper::show_process_list(fe_ip, _param->common_param->port, request, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不是所有的fe的port 都一样的
TPC-H: Total hot run time: 42013 ms
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-DS: Total hot run time: 169806 ms
|
clang-tidy review says "All clean, LGTM! 👍" |
ClickBench: Total hot run time: 29.97 s
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
0b34db0
to
058d945
Compare
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
058d945
to
ffe5216
Compare
run buildall |
TPC-DS: Total hot run time: 169826 ms
|
ClickBench: Total hot run time: 29.83 s
|
ffe5216
to
47f875d
Compare
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 41867 ms
|
TPC-DS: Total hot run time: 170061 ms
|
ClickBench: Total hot run time: 30.65 s
|
## Proposed changes query schema table processlist support show all fe
query schema table processlist support show all fe
query schema table processlist support show all fe
query schema table processlist support show all fe
Proposed changes
query schema table processlist support show all fe