Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](nested_types)support nested type with agg replace_if_not_null #38304

Merged
merged 1 commit into from
Jul 25, 2024
Merged

[improve](nested_types)support nested type with agg replace_if_not_null #38304

merged 1 commit into from
Jul 25, 2024

Conversation

amorynan
Copy link
Contributor

Proposed changes

support nested type with agg table for replace_if_not_null
Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40043 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 05d1ddee1975a8463b36e24bca858619a42ecf65, data reload: false

------ Round 1 ----------------------------------
q1	5951	4374	4306	4306
q2	661	192	199	192
q3	5628	1120	1076	1076
q4	8139	845	885	845
q5	2675	2868	2827	2827
q6	222	135	137	135
q7	946	601	600	600
q8	2040	2058	2101	2058
q9	6613	6558	6569	6558
q10	3899	3798	3745	3745
q11	360	237	227	227
q12	388	219	225	219
q13	17036	2961	2965	2961
q14	271	235	230	230
q15	527	499	487	487
q16	476	372	373	372
q17	961	634	721	634
q18	8097	7527	7428	7428
q19	1534	1367	1364	1364
q20	526	317	338	317
q21	4868	3221	3182	3182
q22	343	286	280	280
Total cold run time: 72161 ms
Total hot run time: 40043 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4316	4275	4233	4233
q2	379	269	257	257
q3	3063	2812	2772	2772
q4	1936	1578	1597	1578
q5	5319	5347	5317	5317
q6	219	128	127	127
q7	2118	1737	1722	1722
q8	3173	3340	3307	3307
q9	8686	8754	8748	8748
q10	4128	4027	3986	3986
q11	600	523	512	512
q12	804	631	676	631
q13	17046	3055	3162	3055
q14	325	289	300	289
q15	533	501	490	490
q16	515	437	443	437
q17	1864	1518	1492	1492
q18	7924	7788	7808	7788
q19	1746	1552	1476	1476
q20	2112	1875	1892	1875
q21	5146	4963	4968	4963
q22	594	505	506	505
Total cold run time: 72546 ms
Total hot run time: 55560 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173876 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 05d1ddee1975a8463b36e24bca858619a42ecf65, data reload: false

query1	909	373	374	373
query2	6439	1804	1743	1743
query3	6639	217	227	217
query4	28593	17634	17389	17389
query5	3660	480	474	474
query6	269	168	165	165
query7	4584	296	295	295
query8	234	196	189	189
query9	8354	2384	2374	2374
query10	434	313	265	265
query11	11824	10143	10265	10143
query12	117	89	92	89
query13	1642	378	369	369
query14	10304	7570	7718	7570
query15	218	163	167	163
query16	7268	485	473	473
query17	1132	562	534	534
query18	1933	278	268	268
query19	197	146	148	146
query20	90	82	83	82
query21	202	126	121	121
query22	4510	4175	4070	4070
query23	33987	33788	33599	33599
query24	11339	2889	2950	2889
query25	619	384	404	384
query26	1409	155	159	155
query27	3021	278	280	278
query28	7974	2057	2064	2057
query29	991	648	623	623
query30	247	155	152	152
query31	950	784	755	755
query32	96	52	53	52
query33	752	343	340	340
query34	993	487	492	487
query35	886	750	749	749
query36	1142	972	967	967
query37	163	85	82	82
query38	2958	2876	2831	2831
query39	934	843	838	838
query40	247	117	115	115
query41	45	42	43	42
query42	113	94	99	94
query43	506	447	481	447
query44	1198	719	716	716
query45	205	172	181	172
query46	1085	753	741	741
query47	1867	1778	1767	1767
query48	362	290	288	288
query49	859	397	397	397
query50	768	388	381	381
query51	6661	6732	6660	6660
query52	104	92	92	92
query53	360	291	289	289
query54	955	446	443	443
query55	72	71	72	71
query56	286	257	263	257
query57	1133	1050	1070	1050
query58	262	241	261	241
query59	2889	2538	2601	2538
query60	295	283	303	283
query61	96	95	94	94
query62	794	643	665	643
query63	321	285	285	285
query64	10475	2186	1678	1678
query65	3159	3115	3093	3093
query66	1280	325	325	325
query67	15460	15065	14990	14990
query68	5271	538	555	538
query69	613	426	370	370
query70	1193	1105	1077	1077
query71	447	273	274	273
query72	7255	5758	5495	5495
query73	769	324	322	322
query74	6154	5670	5646	5646
query75	3639	2663	2708	2663
query76	3140	951	988	951
query77	698	309	302	302
query78	9721	9397	8958	8958
query79	4092	526	529	526
query80	1933	471	467	467
query81	587	223	220	220
query82	1533	137	134	134
query83	320	165	162	162
query84	269	92	87	87
query85	1565	314	302	302
query86	475	309	311	309
query87	3318	3124	3129	3124
query88	4832	2377	2366	2366
query89	497	400	394	394
query90	1823	197	200	197
query91	131	103	98	98
query92	62	48	49	48
query93	5166	519	521	519
query94	1184	278	298	278
query95	418	318	319	318
query96	614	272	269	269
query97	3180	3034	3028	3028
query98	235	204	204	204
query99	1567	1289	1363	1289
Total cold run time: 292571 ms
Total hot run time: 173876 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.22 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 05d1ddee1975a8463b36e24bca858619a42ecf65, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.08
query5	0.49	0.48	0.48
query6	1.14	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.55	0.49	0.49
query10	0.54	0.53	0.53
query11	0.16	0.11	0.11
query12	0.15	0.13	0.12
query13	0.60	0.58	0.60
query14	0.75	0.80	0.77
query15	0.85	0.81	0.82
query16	0.37	0.37	0.36
query17	0.96	0.97	0.99
query18	0.22	0.21	0.22
query19	1.75	1.69	1.66
query20	0.02	0.01	0.01
query21	15.41	0.77	0.67
query22	3.74	6.69	2.64
query23	18.26	1.50	1.27
query24	2.17	0.22	0.22
query25	0.16	0.09	0.09
query26	0.30	0.22	0.23
query27	0.45	0.23	0.22
query28	13.26	1.02	1.00
query29	12.60	3.34	3.29
query30	0.25	0.05	0.05
query31	2.87	0.38	0.38
query32	3.28	0.47	0.46
query33	2.92	2.87	2.90
query34	16.88	4.32	4.35
query35	4.42	4.40	4.40
query36	0.65	0.47	0.47
query37	0.19	0.16	0.16
query38	0.16	0.14	0.15
query39	0.04	0.04	0.04
query40	0.15	0.12	0.12
query41	0.09	0.05	0.05
query42	0.05	0.04	0.04
query43	0.04	0.03	0.04
Total cold run time: 108.98 s
Total hot run time: 31.22 s

eldenmoon
eldenmoon approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

xiaokang
xiaokang approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit 2abbed9 into apache:master Jul 25, 2024
29 of 31 checks passed
This was referenced Aug 1, 2024
Merged
Merged
yiguolei pushed a commit that referenced this pull request Aug 2, 2024
@amorynan
[pick](nestedtypes) support nested type with agg replace_if_not_null (#…
84d9b2f 
…38719)

## Proposed changes
backport: #38304
Issue Number: close #xxx

<!--Describe your changes.-->
@yiguolei yiguolei added dev/2.1.6-merged usercase Important user case type label and removed dev/2.1.x labels Aug 2, 2024
dataroaring pushed a commit that referenced this pull request Aug 6, 2024
@amorynan @dataroaring
[improve](nested_types)support nested type with agg replace_if_not_nu…
89b9868 
…ll (#38304)
xiaokang pushed a commit that referenced this pull request Aug 6, 2024
@amorynan
[pick](nestedtype)support nested type with agg replace_if_not_null #3…
9925204 
…8304 (#38716)
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 27, 2024
@amorynan
[pick](nestedtype)support nested type with agg replace_if_not_null ap…
ba2d3dd 
…ache#38304 (apache#38716)
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
@xiaokang xiaokang mentioned this pull request Sep 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@xiaokang xiaokang xiaokang approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.6-merged dev/3.0.1-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amorynan @doris-robot @xiaokang @eldenmoon @yiguolei @dataroaring