Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cloud) fix inconsistent reponse between cloud mode and local mode for streamload 2PC #38076

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

liaoxin01
Copy link
Contributor

fix the regression test case of flink_connector_response for cloud p0.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@liaoxin01
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39575 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c4d0309197bff00a0ec3c288606f5251608a7c27, data reload: false

------ Round 1 ----------------------------------
q1	17623	4303	4232	4232
q2	2025	192	194	192
q3	10442	1156	1046	1046
q4	10186	809	816	809
q5	7555	2674	2689	2674
q6	222	137	137	137
q7	955	610	598	598
q8	9213	2082	2053	2053
q9	8678	6489	6505	6489
q10	8758	3820	3742	3742
q11	464	243	242	242
q12	454	225	227	225
q13	17764	2991	2954	2954
q14	291	233	242	233
q15	532	498	494	494
q16	519	376	377	376
q17	955	639	695	639
q18	7945	7499	7291	7291
q19	6300	1388	1373	1373
q20	687	305	318	305
q21	4828	3272	3189	3189
q22	346	294	282	282
Total cold run time: 116742 ms
Total hot run time: 39575 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4409	4213	4200	4200
q2	386	276	265	265
q3	2993	2754	2854	2754
q4	1964	1751	1714	1714
q5	5708	5519	5502	5502
q6	221	130	130	130
q7	2135	1865	1837	1837
q8	3272	3382	3436	3382
q9	8766	8684	8847	8684
q10	4062	3858	3787	3787
q11	608	518	484	484
q12	833	655	602	602
q13	16394	3203	3181	3181
q14	321	274	285	274
q15	546	490	482	482
q16	491	432	447	432
q17	1807	1533	1508	1508
q18	7998	7884	7806	7806
q19	1707	1572	1597	1572
q20	2256	1841	1862	1841
q21	8812	4787	4769	4769
q22	578	512	507	507
Total cold run time: 76267 ms
Total hot run time: 55713 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173128 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c4d0309197bff00a0ec3c288606f5251608a7c27, data reload: false

query1	905	362	358	358
query2	6444	2017	1920	1920
query3	6655	202	217	202
query4	28672	17652	17460	17460
query5	3676	472	470	470
query6	266	191	166	166
query7	4583	292	294	292
query8	234	192	198	192
query9	8568	2513	2481	2481
query10	421	288	271	271
query11	10687	9980	10003	9980
query12	121	86	89	86
query13	1665	368	373	368
query14	10388	7076	7720	7076
query15	219	167	174	167
query16	7720	331	321	321
query17	1787	571	541	541
query18	1902	284	291	284
query19	214	155	154	154
query20	90	81	81	81
query21	201	129	131	129
query22	4372	4062	3985	3985
query23	34036	33594	33702	33594
query24	10939	2890	2887	2887
query25	597	418	412	412
query26	702	153	154	153
query27	2228	284	289	284
query28	6474	2118	2114	2114
query29	936	692	651	651
query30	261	163	157	157
query31	1015	769	840	769
query32	103	54	55	54
query33	739	303	300	300
query34	961	495	494	494
query35	716	635	584	584
query36	1176	949	986	949
query37	146	82	80	80
query38	2949	2837	2822	2822
query39	872	819	824	819
query40	199	115	116	115
query41	49	43	43	43
query42	114	103	99	99
query43	524	466	479	466
query44	1187	734	725	725
query45	195	159	161	159
query46	1076	768	729	729
query47	1853	1794	1769	1769
query48	380	298	288	288
query49	826	414	408	408
query50	788	389	391	389
query51	6934	6841	6837	6837
query52	101	90	89	89
query53	363	280	288	280
query54	961	445	444	444
query55	73	74	74	74
query56	287	263	262	262
query57	1178	1037	1067	1037
query58	255	258	261	258
query59	2813	2792	2519	2519
query60	297	276	273	273
query61	92	91	89	89
query62	790	627	648	627
query63	315	279	286	279
query64	9396	2241	1647	1647
query65	3176	3092	3108	3092
query66	756	330	329	329
query67	15510	14839	14855	14839
query68	4683	546	547	546
query69	681	455	342	342
query70	1186	1045	1159	1045
query71	463	275	276	275
query72	8977	5551	5598	5551
query73	753	329	327	327
query74	6150	5695	5719	5695
query75	4434	2688	2681	2681
query76	3525	937	994	937
query77	684	297	301	297
query78	10838	8902	8891	8891
query79	8432	534	538	534
query80	1515	468	478	468
query81	595	228	229	228
query82	923	133	131	131
query83	343	175	165	165
query84	277	85	86	85
query85	1817	310	293	293
query86	463	304	293	293
query87	3297	3072	3132	3072
query88	5085	2486	2483	2483
query89	504	382	383	382
query90	1882	193	196	193
query91	127	119	99	99
query92	59	47	50	47
query93	6439	521	516	516
query94	1253	216	216	216
query95	414	322	316	316
query96	614	280	278	278
query97	3208	3039	3025	3025
query98	227	196	194	194
query99	1552	1251	1290	1251
Total cold run time: 296528 ms
Total hot run time: 173128 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c4d0309197bff00a0ec3c288606f5251608a7c27, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.05
query4	1.66	0.07	0.08
query5	0.51	0.50	0.49
query6	1.13	0.72	0.72
query7	0.02	0.02	0.01
query8	0.06	0.05	0.04
query9	0.55	0.49	0.50
query10	0.54	0.55	0.54
query11	0.16	0.12	0.11
query12	0.15	0.13	0.12
query13	0.59	0.58	0.58
query14	0.76	0.76	0.79
query15	0.85	0.81	0.81
query16	0.37	0.37	0.38
query17	0.98	0.95	0.96
query18	0.23	0.22	0.22
query19	1.75	1.69	1.67
query20	0.02	0.01	0.01
query21	15.41	0.74	0.67
query22	4.45	7.42	1.71
query23	18.27	1.34	1.35
query24	2.15	0.23	0.22
query25	0.15	0.09	0.08
query26	0.29	0.21	0.20
query27	0.46	0.22	0.24
query28	13.18	1.01	1.00
query29	12.58	3.34	3.35
query30	0.25	0.06	0.05
query31	2.86	0.40	0.39
query32	3.27	0.48	0.47
query33	2.90	2.93	2.92
query34	16.90	4.35	4.34
query35	4.41	4.44	4.44
query36	0.65	0.50	0.48
query37	0.18	0.15	0.14
query38	0.15	0.15	0.14
query39	0.04	0.04	0.04
query40	0.16	0.12	0.12
query41	0.10	0.04	0.04
query42	0.05	0.04	0.05
query43	0.05	0.03	0.04
Total cold run time: 109.58 s
Total hot run time: 30.5 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 18, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 30da34a into apache:master Jul 19, 2024
28 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
…de for streamload 2PC (#38076)

fix  the regression test case of flink_connector_response for cloud p0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants