-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](dynamic partition) fix create dynamic partition with overlap not throw exception #37924
[fix](dynamic partition) fix create dynamic partition with overlap not throw exception #37924
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39951 ms
|
TPC-DS: Total hot run time: 174284 ms
|
ClickBench: Total hot run time: 31.34 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
run buildall |
update |
5b1dea2
to
4260d21
Compare
run buildall |
TPC-H: Total hot run time: 39900 ms
|
TPC-DS: Total hot run time: 173509 ms
|
ClickBench: Total hot run time: 30.7 s
|
run p0 |
run cloud_p0 |
run p0 |
TPC-H: Total hot run time: 39779 ms
|
TPC-DS: Total hot run time: 173326 ms
|
ClickBench: Total hot run time: 31.08 s
|
run external |
run cloud_p0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
…t throw exception (#37924) PR #35778 will throw exception if dynamic partition overlap with others. Don't throw exception due to considering no behaviour change. Just ignore create this partition. SQL: ``` PARTITION BY RANGE(`dt`)( PARTITION `phistory` VALUES less than ('2024-01-01') ) DISTRIBUTED BY HASH(`user_id`, `room_id`) BUCKETS 3 PROPERTIES ( "replication_allocation" = "tag.location.default: 1", "dynamic_partition.enable" = "true", "dynamic_partition.time_unit" = "DAY", "dynamic_partition.end" = "10", "dynamic_partition.prefix" = "p", "dynamic_partition.create_history_partition" = "true", "dynamic_partition.history_partition_num" = "250" ); ``` error: ``` ERROR 1105 (HY000): errCode = 2, detailMessage = errCode = 2, detailMessage = errCode = 2, detailMessage = Range [types: [DATEV2]; keys: [0000-01-01]; ..types: [DATEV2]; keys: [2024-01-01]; ) is intersected with range: [types: [DATEV2]; keys: [2023-12-29]; ..types: [DATEV2]; keys: [2023-12-30]; ) ```
…t throw exception apache#37924 (apache#37966) cherry-pick: apache#37924
PR #35778 will throw exception if dynamic partition overlap with others. Don't throw exception due to considering no behaviour change. Just ignore create this partition.
SQL:
error: