[Improvement][Audit] add sql type for query audit #37790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
qzsee
force-pushed
the
add-sql-type
branch
2 times, most recently
from
5046679
to
e4fd3c4
Compare
|
run buildall |
TPC-H: Total hot run time: 40364 ms |
TPC-DS: Total hot run time: 174639 ms |
ClickBench: Total hot run time: 31.33 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
reviewed
Jul 18, 2024
| @@ -107,4 +108,8 @@ default DataTrait computeDataTrait() { | |||
| void computeEqualSet(DataTrait.Builder builder); | |||
|
|
|||
| void computeFd(DataTrait.Builder builder); | |||
|
|
|||
| default StmtType stmtType() { | |||
| return StmtType.OTHER; | |||
There was a problem hiding this comment.
do not give default impl, let it be abstract
There was a problem hiding this comment.
If it is changed to an abstract method, then all subclasses must implement this method, which is unnecessary
| package org.apache.doris.analysis; | ||
|
|
||
| public enum StmtType { | ||
| DDL, |
There was a problem hiding this comment.
add comment
- clarifying the criteria for classifying a statement. for example we have DDL and CREATE, so when to use DDL directly, when to add a new type of DDL?
- sort and classify these types for easy read and maintain
There was a problem hiding this comment.
1.The reason for not simplifying the DDL type is that we can see more detailed SQL types. The reason for adding the DDL type is that if there are new DDL operations in the future, if there is no corresponding method implemented, it will be directly a DDL type.
2.done
github-actions
bot
removed
the
approved
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 39780 ms |
TPC-DS: Total hot run time: 173484 ms |
ClickBench: Total hot run time: 30.44 s |
|
run buildall |
TPC-H: Total hot run time: 40063 ms |
TPC-DS: Total hot run time: 173089 ms |
ClickBench: Total hot run time: 30.8 s |
morrySnow
previously approved these changes
Jul 22, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
run P0 |
|
run buildall |
TPC-H: Total hot run time: 39793 ms |
TPC-DS: Total hot run time: 174722 ms |
ClickBench: Total hot run time: 30.64 s |
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 39550 ms |
TPC-DS: Total hot run time: 172662 ms |
ClickBench: Total hot run time: 31 s |
morrySnow
approved these changes
Jul 25, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
morningman
approved these changes
Jul 26, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: garenshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx