Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](round) fix round decimal128 overflow #37733

Merged
merged 3 commits into from
Jul 16, 2024
Merged

[fix](round) fix round decimal128 overflow #37733

merged 3 commits into from
Jul 16, 2024

Conversation

cambyzju
Copy link
Contributor

Proposed changes

Issue Number: close ##37143

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

rund buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39785 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 858caf5c0277af380b9ca7562c7f787ed4390b03, data reload: false

------ Round 1 ----------------------------------
q1	17621	4350	4296	4296
q2	2025	192	185	185
q3	10440	1219	1045	1045
q4	10191	787	729	729
q5	7542	2696	2684	2684
q6	222	136	136	136
q7	949	596	596	596
q8	9227	2069	2065	2065
q9	8927	6592	6586	6586
q10	8720	3778	3799	3778
q11	470	233	238	233
q12	474	224	224	224
q13	17772	2960	2997	2960
q14	288	242	253	242
q15	528	494	490	490
q16	509	379	387	379
q17	953	709	632	632
q18	8049	7444	7349	7349
q19	8276	1447	1405	1405
q20	694	324	341	324
q21	4929	3163	3165	3163
q22	349	284	285	284
Total cold run time: 119155 ms
Total hot run time: 39785 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4452	4252	4234	4234
q2	375	269	275	269
q3	3000	2909	2903	2903
q4	1988	1683	1736	1683
q5	5632	5553	5468	5468
q6	226	134	134	134
q7	2181	1897	1866	1866
q8	3287	3452	3444	3444
q9	8799	8828	8945	8828
q10	4091	3840	3798	3798
q11	584	514	517	514
q12	811	634	632	632
q13	16466	3207	3219	3207
q14	325	301	299	299
q15	547	486	493	486
q16	481	469	444	444
q17	1805	1545	1533	1533
q18	8138	8069	7939	7939
q19	1699	1614	1707	1614
q20	2064	1882	1877	1877
q21	7268	4861	4827	4827
q22	565	522	509	509
Total cold run time: 74784 ms
Total hot run time: 56508 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173140 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 858caf5c0277af380b9ca7562c7f787ed4390b03, data reload: false

query1	918	374	368	368
query2	6445	1830	1799	1799
query3	6646	205	214	205
query4	28314	17603	17320	17320
query5	3710	485	482	482
query6	271	162	158	158
query7	4582	291	293	291
query8	239	205	194	194
query9	8479	2383	2369	2369
query10	443	278	300	278
query11	11644	10020	10166	10020
query12	127	91	84	84
query13	1650	375	371	371
query14	10098	7896	6837	6837
query15	224	173	169	169
query16	7642	319	321	319
query17	1345	573	549	549
query18	1771	289	282	282
query19	197	156	160	156
query20	95	82	85	82
query21	208	132	126	126
query22	4209	4109	4013	4013
query23	33801	33648	33704	33648
query24	10662	3006	2960	2960
query25	600	405	385	385
query26	703	151	158	151
query27	2253	279	275	275
query28	5929	2045	2036	2036
query29	882	678	620	620
query30	258	158	161	158
query31	931	771	761	761
query32	91	52	55	52
query33	653	306	297	297
query34	896	506	498	498
query35	664	592	589	589
query36	1125	992	988	988
query37	147	83	87	83
query38	3009	2876	2837	2837
query39	900	863	853	853
query40	217	118	117	117
query41	47	42	43	42
query42	114	97	100	97
query43	507	470	469	469
query44	1054	722	730	722
query45	190	160	161	160
query46	1079	727	755	727
query47	1867	1773	1804	1773
query48	356	291	292	291
query49	833	406	413	406
query50	787	392	388	388
query51	6954	6873	6792	6792
query52	103	93	94	93
query53	350	281	282	281
query54	845	449	450	449
query55	76	75	74	74
query56	290	272	273	272
query57	1141	1050	1040	1040
query58	257	258	278	258
query59	2837	2611	2612	2611
query60	339	276	284	276
query61	98	123	94	94
query62	771	635	644	635
query63	313	287	284	284
query64	9160	2214	1678	1678
query65	3166	3109	3112	3109
query66	716	333	326	326
query67	15737	15178	14900	14900
query68	4620	533	532	532
query69	632	406	354	354
query70	1195	1142	1156	1142
query71	393	298	286	286
query72	7801	5991	5614	5614
query73	741	324	326	324
query74	6157	5723	5726	5723
query75	4024	2694	2687	2687
query76	2583	945	893	893
query77	657	321	301	301
query78	9760	9202	9034	9034
query79	2925	520	514	514
query80	1567	469	470	469
query81	583	223	219	219
query82	870	136	134	134
query83	346	170	166	166
query84	285	88	91	88
query85	1785	308	293	293
query86	464	314	329	314
query87	3316	3139	3114	3114
query88	4216	2463	2444	2444
query89	472	373	371	371
query90	1828	197	198	197
query91	129	101	103	101
query92	60	48	50	48
query93	5026	502	489	489
query94	1290	216	210	210
query95	408	316	310	310
query96	618	281	276	276
query97	3212	3011	3009	3009
query98	232	198	202	198
query99	1520	1259	1279	1259
Total cold run time: 282680 ms
Total hot run time: 173140 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 858caf5c0277af380b9ca7562c7f787ed4390b03, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.07
query5	0.49	0.48	0.49
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.54	0.49	0.50
query10	0.54	0.57	0.54
query11	0.16	0.11	0.12
query12	0.15	0.13	0.13
query13	0.59	0.60	0.58
query14	0.76	0.80	0.78
query15	0.85	0.80	0.81
query16	0.37	0.36	0.34
query17	0.99	1.00	1.01
query18	0.22	0.22	0.22
query19	1.76	1.70	1.80
query20	0.01	0.01	0.03
query21	15.39	0.73	0.66
query22	4.14	6.84	2.26
query23	18.27	1.45	1.23
query24	2.12	0.22	0.22
query25	0.16	0.09	0.09
query26	0.29	0.21	0.20
query27	0.46	0.23	0.22
query28	13.30	1.03	1.00
query29	12.61	3.27	3.26
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.27	0.48	0.48
query33	2.89	2.92	2.88
query34	17.27	4.39	4.35
query35	4.43	4.41	4.40
query36	0.64	0.47	0.49
query37	0.19	0.15	0.16
query38	0.15	0.15	0.15
query39	0.04	0.03	0.04
query40	0.14	0.12	0.12
query41	0.09	0.04	0.04
query42	0.07	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.73 s
Total hot run time: 30.87 s

zhiqiang-hhhh
zhiqiang-hhhh approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zhiqiang-hhhh
Copy link
Contributor

image Failed on known problem.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@cambyzju
Copy link
Contributor Author

run p0

@yiguolei yiguolei merged commit 1d3a21f into apache:master Jul 16, 2024
29 of 31 checks passed
@yiguolei yiguolei added the usercase Important user case type label label Jul 16, 2024
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 17, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733)
448dbf2 
## Proposed changes

Issue Number: close #apache#37143

<!--Describe your changes.-->
@cambyzju cambyzju mentioned this pull request Jul 17, 2024
Merged
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 17, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733)
73d64c4
@cambyzju cambyzju mentioned this pull request Jul 17, 2024
Merged
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 17, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733)
b5b773f
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
@cambyzju @seawinde
[fix](round) fix round decimal128 overflow (apache#37733)
6de2426 
## Proposed changes

Issue Number: close #apache#37143

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@cambyzju @dataroaring
[fix](round) fix round decimal128 overflow (#37733)
cbeeac6 
## Proposed changes

Issue Number: close ##37143

<!--Describe your changes.-->
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 17, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733)
7ee850d
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 17, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733)
a41a222
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 18, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733)
49aa5b7
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 18, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733)
af0e6d3
yiguolei pushed a commit that referenced this pull request Jul 18, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (#37733) (#37963)
de2272c 
cherry-pick #37733 to branch-2.1
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 19, 2024
@cambyzju
Revert "[fix](round) fix round decimal128 overflow (apache#37733)"
b1690cd 
This reverts commit 1d3a21f.
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 19, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733) (apache#37963)
3dd1388 
cherry-pick apache#37733 to branch-2.1
@cambyzju cambyzju mentioned this pull request Jul 19, 2024
Merged
cambyzju added a commit that referenced this pull request Jul 19, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (#37733) (#37965)
ce71a13
@yanyxin
Copy link

yanyxin commented Jul 24, 2024

@cambyzju Will it synchronize to 2.0.13 and 2.1.5

@cambyzju
Copy link
Contributor Author

cambyzju commented Aug 1, 2024

@cambyzju Will it synchronize to 2.0.13 and 2.1.5

yes，will backport to 2.0.14 & 2.1.5

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733) (apache#37965)
df2fcfa
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

@jacktengg jacktengg jacktengg approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.14-merged dev/2.1.5-merged dev/3.0.1-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cambyzju @doris-robot @zhiqiang-hhhh @yanyxin @yiguolei @jacktengg @xiaokang @dataroaring