Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](partial update) fix a mem leak issue #37706

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

zhannngchen
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

we should avoid to use raw pointer

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhannngchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen marked this pull request as draft July 12, 2024 04:15
@doris-robot
Copy link

TPC-H: Total hot run time: 39715 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6f15670ba905f8cfd5a15b87e882114302dc73ef, data reload: false

------ Round 1 ----------------------------------
q1	17607	4317	4251	4251
q2	2017	190	182	182
q3	10464	1160	1107	1107
q4	10196	802	838	802
q5	7575	2654	2676	2654
q6	221	135	152	135
q7	949	591	604	591
q8	9212	2061	2080	2061
q9	8850	6514	6498	6498
q10	8821	3763	3750	3750
q11	451	232	230	230
q12	467	235	225	225
q13	18968	2986	2972	2972
q14	286	227	234	227
q15	538	476	482	476
q16	510	376	380	376
q17	966	681	672	672
q18	8103	7380	7339	7339
q19	8507	1454	1347	1347
q20	643	323	318	318
q21	4907	3170	3225	3170
q22	386	332	333	332
Total cold run time: 120644 ms
Total hot run time: 39715 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4417	4338	4279	4279
q2	364	273	266	266
q3	3072	2872	2922	2872
q4	1976	1743	1725	1725
q5	5523	5502	5465	5465
q6	235	139	136	136
q7	2277	1840	1812	1812
q8	3305	3439	3414	3414
q9	8727	8924	8791	8791
q10	4121	3760	3868	3760
q11	602	503	506	503
q12	869	641	623	623
q13	15987	3171	3260	3171
q14	323	308	297	297
q15	520	480	491	480
q16	508	461	446	446
q17	1820	1515	1522	1515
q18	8188	7979	7851	7851
q19	1864	1567	1473	1473
q20	2320	1865	1854	1854
q21	5156	4908	4786	4786
q22	647	580	515	515
Total cold run time: 72821 ms
Total hot run time: 56034 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174009 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6f15670ba905f8cfd5a15b87e882114302dc73ef, data reload: false

query1	921	368	365	365
query2	6449	2404	2446	2404
query3	6655	214	228	214
query4	28015	17711	17474	17474
query5	3672	497	468	468
query6	258	162	179	162
query7	4580	287	284	284
query8	326	298	288	288
query9	8707	2433	2416	2416
query10	439	292	278	278
query11	10837	10046	10054	10046
query12	114	84	81	81
query13	1643	374	376	374
query14	10118	7487	7777	7487
query15	244	187	189	187
query16	7754	332	319	319
query17	1333	583	541	541
query18	1980	288	281	281
query19	200	158	153	153
query20	91	131	79	79
query21	203	126	125	125
query22	4562	4129	4025	4025
query23	33880	35020	33573	33573
query24	11397	2930	2886	2886
query25	531	411	393	393
query26	691	152	153	152
query27	2682	280	274	274
query28	7532	2109	2100	2100
query29	865	638	629	629
query30	257	152	149	149
query31	1035	745	750	745
query32	93	50	56	50
query33	785	306	292	292
query34	1018	507	514	507
query35	714	600	585	585
query36	1120	984	981	981
query37	148	81	89	81
query38	3010	2873	2851	2851
query39	886	841	808	808
query40	217	128	120	120
query41	52	54	58	54
query42	129	97	103	97
query43	610	563	553	553
query44	1213	704	717	704
query45	195	172	165	165
query46	1092	753	728	728
query47	1852	1757	1783	1757
query48	375	291	296	291
query49	839	396	404	396
query50	782	393	391	391
query51	6987	6632	6756	6632
query52	98	94	87	87
query53	356	285	287	285
query54	863	446	441	441
query55	76	75	73	73
query56	277	266	273	266
query57	1145	1053	1038	1038
query58	249	235	249	235
query59	3352	3210	3136	3136
query60	308	265	276	265
query61	127	95	95	95
query62	804	668	648	648
query63	316	288	290	288
query64	9299	2204	1653	1653
query65	3148	3074	3090	3074
query66	764	358	322	322
query67	15438	15044	15041	15041
query68	5352	532	544	532
query69	612	435	372	372
query70	1117	1043	1119	1043
query71	454	280	278	278
query72	7093	5039	5864	5039
query73	770	325	329	325
query74	5947	5612	5467	5467
query75	3558	2706	2671	2671
query76	3593	949	867	867
query77	612	298	304	298
query78	11212	10043	8941	8941
query79	3261	516	520	516
query80	1391	484	463	463
query81	574	226	219	219
query82	860	136	133	133
query83	249	168	170	168
query84	274	84	91	84
query85	1331	326	355	326
query86	473	298	295	295
query87	3324	3115	3130	3115
query88	3778	2436	2438	2436
query89	532	396	400	396
query90	1802	192	189	189
query91	129	102	100	100
query92	70	48	47	47
query93	4118	494	490	490
query94	1207	212	208	208
query95	414	321	320	320
query96	610	281	273	273
query97	3206	3057	3037	3037
query98	225	198	206	198
query99	1759	1278	1221	1221
Total cold run time: 286615 ms
Total hot run time: 174009 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.78 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6f15670ba905f8cfd5a15b87e882114302dc73ef, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.03
query3	0.23	0.05	0.05
query4	1.65	0.07	0.07
query5	0.50	0.49	0.48
query6	1.14	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.50
query10	0.54	0.55	0.54
query11	0.16	0.11	0.12
query12	0.14	0.12	0.12
query13	0.60	0.58	0.59
query14	0.75	0.77	0.81
query15	0.85	0.83	0.81
query16	0.37	0.38	0.37
query17	0.97	0.98	1.03
query18	0.23	0.21	0.21
query19	1.86	1.67	1.71
query20	0.01	0.01	0.01
query21	15.39	0.78	0.66
query22	3.80	8.42	1.15
query23	18.25	1.38	1.26
query24	2.09	0.22	0.22
query25	0.15	0.08	0.08
query26	0.30	0.21	0.21
query27	0.46	0.23	0.23
query28	13.30	1.03	0.99
query29	12.58	3.34	3.32
query30	0.25	0.06	0.05
query31	2.86	0.39	0.38
query32	3.25	0.47	0.48
query33	2.90	2.93	2.88
query34	17.23	4.36	4.39
query35	4.42	4.37	4.38
query36	0.66	0.46	0.47
query37	0.19	0.16	0.16
query38	0.15	0.15	0.15
query39	0.04	0.04	0.03
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.05	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.34 s
Total hot run time: 29.78 s

@zhannngchen zhannngchen marked this pull request as ready for review July 12, 2024 06:27
@zhannngchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40369 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 79ebf6b153c95df1976955cafd7accab28fe3914, data reload: false

------ Round 1 ----------------------------------
q1	17622	4317	4536	4317
q2	2010	195	191	191
q3	10439	1225	1163	1163
q4	10190	877	774	774
q5	7607	2680	2663	2663
q6	226	139	139	139
q7	955	608	622	608
q8	9229	2078	2082	2078
q9	8876	6584	6621	6584
q10	8802	3838	3814	3814
q11	459	247	242	242
q12	428	240	236	236
q13	17829	2993	3036	2993
q14	280	248	235	235
q15	515	492	493	492
q16	515	381	390	381
q17	972	663	721	663
q18	8146	7554	7478	7478
q19	7984	1553	1463	1463
q20	701	321	324	321
q21	5090	3203	3268	3203
q22	404	338	331	331
Total cold run time: 119279 ms
Total hot run time: 40369 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4525	4320	4326	4320
q2	375	285	272	272
q3	3296	3005	3040	3005
q4	2162	1892	1795	1795
q5	5767	5758	5826	5758
q6	239	139	144	139
q7	2351	1957	2000	1957
q8	3379	3548	3549	3548
q9	8979	9094	8983	8983
q10	4122	3863	3900	3863
q11	594	520	506	506
q12	817	645	642	642
q13	15816	3188	3251	3188
q14	313	300	280	280
q15	534	487	497	487
q16	495	433	444	433
q17	1825	1529	1500	1500
q18	8263	8022	7936	7936
q19	1817	1500	1730	1500
q20	2751	1919	1858	1858
q21	8593	4695	4804	4695
q22	627	559	549	549
Total cold run time: 77640 ms
Total hot run time: 57214 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 175420 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 79ebf6b153c95df1976955cafd7accab28fe3914, data reload: false

query1	917	382	365	365
query2	6448	2475	2445	2445
query3	6654	208	220	208
query4	23987	17708	17446	17446
query5	3595	502	482	482
query6	279	167	176	167
query7	4584	307	282	282
query8	331	303	291	291
query9	8766	2420	2406	2406
query10	424	293	264	264
query11	10586	10114	10219	10114
query12	117	88	81	81
query13	1632	380	375	375
query14	10091	7591	7763	7591
query15	249	187	191	187
query16	7575	320	299	299
query17	1751	620	519	519
query18	1873	277	290	277
query19	197	147	152	147
query20	102	82	83	82
query21	208	136	124	124
query22	4319	4038	4275	4038
query23	34327	33720	33797	33720
query24	7000	2880	2876	2876
query25	594	400	399	399
query26	697	152	150	150
query27	2244	284	279	279
query28	4787	2177	2177	2177
query29	882	661	653	653
query30	272	156	181	156
query31	987	763	751	751
query32	95	55	56	55
query33	551	314	280	280
query34	891	497	522	497
query35	678	587	578	578
query36	1092	999	976	976
query37	148	83	88	83
query38	2921	2878	2869	2869
query39	878	859	828	828
query40	205	127	118	118
query41	58	50	50	50
query42	116	98	99	98
query43	616	566	534	534
query44	1108	759	735	735
query45	195	167	164	164
query46	1076	733	728	728
query47	1868	1763	1776	1763
query48	377	299	291	291
query49	848	409	414	409
query50	773	399	385	385
query51	6908	6788	6788	6788
query52	108	104	94	94
query53	369	291	295	291
query54	559	455	444	444
query55	77	76	74	74
query56	277	265	273	265
query57	1146	1056	1056	1056
query58	252	261	251	251
query59	3524	3599	3227	3227
query60	300	270	282	270
query61	140	92	94	92
query62	790	626	636	626
query63	325	286	292	286
query64	9193	2183	1672	1672
query65	3190	3135	3137	3135
query66	747	323	332	323
query67	15399	15166	14943	14943
query68	4671	542	543	542
query69	769	429	359	359
query70	1199	1108	1113	1108
query71	406	294	282	282
query72	7019	5776	5476	5476
query73	781	322	321	321
query74	5921	5558	5517	5517
query75	3433	2736	2774	2736
query76	2741	957	978	957
query77	665	320	318	318
query78	9589	9310	8956	8956
query79	2300	524	534	524
query80	2015	485	493	485
query81	600	224	229	224
query82	771	131	132	131
query83	266	167	170	167
query84	279	89	85	85
query85	1220	303	295	295
query86	452	326	327	326
query87	3262	3111	3141	3111
query88	4127	2385	2387	2385
query89	491	387	373	373
query90	1834	195	190	190
query91	131	104	100	100
query92	64	52	47	47
query93	2848	513	507	507
query94	1048	210	211	210
query95	403	313	323	313
query96	610	280	276	276
query97	3183	3096	3019	3019
query98	240	208	196	196
query99	1582	1255	1293	1255
Total cold run time: 269193 ms
Total hot run time: 175420 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 79ebf6b153c95df1976955cafd7accab28fe3914, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.22	0.05	0.06
query4	1.67	0.08	0.08
query5	0.49	0.48	0.48
query6	1.19	0.72	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.50	0.48
query10	0.54	0.54	0.54
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.59
query14	0.76	0.77	0.83
query15	0.86	0.82	0.82
query16	0.35	0.37	0.37
query17	0.96	0.99	1.05
query18	0.24	0.22	0.21
query19	1.79	1.74	1.73
query20	0.01	0.01	0.01
query21	15.39	0.78	0.66
query22	4.03	7.10	2.48
query23	18.33	1.48	1.30
query24	2.14	0.22	0.24
query25	0.16	0.08	0.09
query26	0.29	0.20	0.21
query27	0.46	0.23	0.22
query28	13.22	1.02	1.02
query29	12.62	3.32	3.26
query30	0.25	0.06	0.05
query31	2.87	0.38	0.39
query32	3.27	0.46	0.47
query33	2.89	2.93	2.86
query34	16.95	4.38	4.34
query35	4.42	4.42	4.41
query36	0.64	0.48	0.48
query37	0.18	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.03
query40	0.16	0.12	0.13
query41	0.09	0.04	0.05
query42	0.05	0.05	0.05
query43	0.04	0.05	0.04
Total cold run time: 109.38 s
Total hot run time: 31.2 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 12, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@hust-hhb hust-hhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit 6312b58 into apache:master Jul 12, 2024
27 of 31 checks passed
zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Jul 12, 2024
zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Jul 12, 2024
zhannngchen added a commit that referenced this pull request Jul 13, 2024
dataroaring pushed a commit that referenced this pull request Jul 13, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
we should avoid to use raw pointer
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants