Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test](be-ut) fix load stream test after segment num check #37660

Merged
merged 1 commit into from
Jul 12, 2024
Merged

[test](be-ut) fix load stream test after segment num check #37660

merged 1 commit into from
Jul 12, 2024

Conversation

kaijchen
Copy link
Contributor

Proposed changes

fix load stream test after #36753

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Contributor Author

run buildall

liaoxin01
liaoxin01 previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaijchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@kaijchen kaijchen mentioned this pull request Jul 11, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40038 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 184182cd56e74ee28c1b776f38b0bb40ab486b86, data reload: false

------ Round 1 ----------------------------------
q1	17599	4420	4324	4324
q2	2020	196	193	193
q3	10451	1216	1073	1073
q4	10187	748	777	748
q5	7618	2696	2715	2696
q6	223	144	144	144
q7	962	625	617	617
q8	9220	2108	2096	2096
q9	8764	6583	6550	6550
q10	8807	3766	3774	3766
q11	464	246	243	243
q12	405	239	234	234
q13	17758	2976	2992	2976
q14	287	230	250	230
q15	530	482	498	482
q16	496	374	377	374
q17	974	608	690	608
q18	8250	7542	7363	7363
q19	5727	1531	1484	1484
q20	657	324	326	324
q21	4920	3176	3312	3176
q22	393	337	338	337
Total cold run time: 116712 ms
Total hot run time: 40038 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4393	4269	4212	4212
q2	374	268	265	265
q3	3037	2850	2946	2850
q4	2009	1740	1712	1712
q5	5667	5561	5528	5528
q6	231	141	139	139
q7	2221	1864	1852	1852
q8	3333	3412	3433	3412
q9	8778	8787	8961	8787
q10	4096	3914	3805	3805
q11	622	511	510	510
q12	846	658	629	629
q13	16275	3172	3214	3172
q14	326	291	301	291
q15	531	489	471	471
q16	493	451	432	432
q17	1840	1543	1509	1509
q18	8068	8062	7807	7807
q19	1806	1690	1683	1683
q20	2449	1920	1854	1854
q21	5007	5030	4713	4713
q22	824	547	557	547
Total cold run time: 73226 ms
Total hot run time: 56180 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174404 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 184182cd56e74ee28c1b776f38b0bb40ab486b86, data reload: false

query1	926	370	356	356
query2	6444	2354	2353	2353
query3	6649	209	221	209
query4	24589	17421	17322	17322
query5	3641	496	489	489
query6	258	167	150	150
query7	4572	300	289	289
query8	299	265	280	265
query9	8519	2475	2476	2475
query10	446	295	278	278
query11	10549	10110	9920	9920
query12	117	83	85	83
query13	1633	371	376	371
query14	10273	7445	7721	7445
query15	242	187	194	187
query16	7681	355	334	334
query17	1642	589	552	552
query18	1937	287	283	283
query19	197	159	157	157
query20	90	84	82	82
query21	202	136	132	132
query22	4199	4086	3982	3982
query23	34092	33767	33663	33663
query24	10817	2906	2886	2886
query25	671	396	384	384
query26	698	150	151	150
query27	2260	284	279	279
query28	6213	2149	2165	2149
query29	917	639	649	639
query30	246	150	153	150
query31	1017	752	755	752
query32	100	54	52	52
query33	675	300	297	297
query34	894	513	518	513
query35	714	570	599	570
query36	1166	1008	982	982
query37	147	86	89	86
query38	2953	2869	2805	2805
query39	911	866	838	838
query40	202	128	125	125
query41	56	49	54	49
query42	111	104	103	103
query43	601	553	525	525
query44	1110	722	744	722
query45	190	159	156	156
query46	1078	708	779	708
query47	1856	1772	1772	1772
query48	368	292	297	292
query49	820	414	420	414
query50	791	401	397	397
query51	6906	6841	6746	6746
query52	110	88	96	88
query53	351	289	289	289
query54	925	452	447	447
query55	76	74	77	74
query56	287	263	260	260
query57	1125	1041	1086	1041
query58	261	242	245	242
query59	3398	3180	3166	3166
query60	305	275	272	272
query61	96	90	121	90
query62	796	652	634	634
query63	322	291	288	288
query64	9137	2226	1625	1625
query65	3126	3100	3107	3100
query66	764	316	328	316
query67	15403	14987	14832	14832
query68	6094	542	589	542
query69	671	453	361	361
query70	1116	1087	1095	1087
query71	485	277	280	277
query72	6895	5636	5851	5636
query73	775	329	334	329
query74	5975	5447	5478	5447
query75	3872	2696	2641	2641
query76	3772	904	951	904
query77	695	314	311	311
query78	10563	9113	8901	8901
query79	5409	536	520	520
query80	1187	473	472	472
query81	575	222	220	220
query82	749	139	135	135
query83	199	177	178	177
query84	280	85	92	85
query85	1397	314	306	306
query86	459	323	318	318
query87	3328	3099	3120	3099
query88	4554	2448	2461	2448
query89	494	370	386	370
query90	1839	192	197	192
query91	132	102	103	102
query92	59	49	48	48
query93	4817	513	507	507
query94	1122	212	224	212
query95	414	339	336	336
query96	606	274	274	274
query97	3186	3029	3020	3020
query98	227	207	193	193
query99	1680	1299	1252	1252
Total cold run time: 283793 ms
Total hot run time: 174404 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 184182cd56e74ee28c1b776f38b0bb40ab486b86, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.66	0.08	0.07
query5	0.48	0.50	0.49
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.56	0.49	0.49
query10	0.54	0.55	0.56
query11	0.15	0.11	0.11
query12	0.14	0.12	0.13
query13	0.62	0.59	0.59
query14	0.75	0.79	0.77
query15	0.84	0.82	0.80
query16	0.37	0.38	0.37
query17	0.93	0.98	0.96
query18	0.22	0.22	0.22
query19	1.80	1.82	1.79
query20	0.01	0.01	0.02
query21	15.39	0.76	0.65
query22	4.54	6.60	1.88
query23	18.34	1.42	1.25
query24	2.17	0.23	0.23
query25	0.15	0.08	0.07
query26	0.30	0.21	0.22
query27	0.45	0.25	0.24
query28	13.20	1.02	1.00
query29	12.72	3.34	3.36
query30	0.25	0.06	0.06
query31	2.88	0.40	0.40
query32	3.27	0.48	0.47
query33	2.86	2.93	3.00
query34	17.05	4.32	4.34
query35	4.43	4.42	4.44
query36	0.66	0.46	0.48
query37	0.18	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.06	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 110.03 s
Total hot run time: 30.75 s

liaoxin01 pushed a commit that referenced this pull request Jul 11, 2024
@kaijchen
[fix](move-memtable) check segment num when closing each tablet (#36753…
fed632b 
…) (#37536)

cherry-pick #36753 and #37660
liaoxin01
liaoxin01 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@liaoxin01 liaoxin01 added dev/2.1.5-merged and removed approved Indicates a PR has been approved by one committer. reviewed labels Jul 12, 2024
dataroaring
dataroaring approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit d1bd06c into apache:master Jul 12, 2024
26 of 30 checks passed
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
@kaijchen @seawinde
[test](be-ut) fix load stream test after segment num check (apache#37660
e89e168 
)

## Proposed changes

fix load stream test after apache#36753
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@kaijchen @dataroaring
[test](be-ut) fix load stream test after segment num check (#37660)
1133197 
## Proposed changes

fix load stream test after #36753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@liaoxin01 liaoxin01 liaoxin01 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaijchen @doris-robot @liaoxin01 @dataroaring