[Fix](Variant) Schema should be updated when update_tmp_rowset in cloud mode #37557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ud mode 1. In cloud mode the updated rowset meta after `rowset->merge_rowset_meta` in `BaseTablet::update_delete_bitmap` will be lost in `update_tmp_rowset`.So in order to keep the latest schema we should keep schema in update_tmp_rowset 2. cloud tablet should also do copy_without_variant_extracted_columns
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
eldenmoon
changed the title
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 39972 ms |
TPC-DS: Total hot run time: 172182 ms |
ClickBench: Total hot run time: 31.38 s |
qidaye
approved these changes
Jul 11, 2024
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jul 16, 2024
…ud mode (apache#37557) 1. In cloud mode the updated rowset meta after `rowset->merge_rowset_meta` in `BaseTablet::update_delete_bitmap` will be lost in `update_tmp_rowset`.So in order to keep the latest schema we should keep schema in update_tmp_rowset 2. cloud tablet should also do copy_without_variant_extracted_columns
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…ud mode (apache#37557) 1. In cloud mode the updated rowset meta after `rowset->merge_rowset_meta` in `BaseTablet::update_delete_bitmap` will be lost in `update_tmp_rowset`.So in order to keep the latest schema we should keep schema in update_tmp_rowset 2. cloud tablet should also do copy_without_variant_extracted_columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cloud mode the updated rowset meta after
rowset->merge_rowset_metainBaseTablet::update_delete_bitmapwill be lost inupdate_tmp_rowset.So in order to keep the latest schema we should keep schema in update_tmp_rowsetcloud tablet should also do copy_without_variant_extracted_columns
Proposed changes
Issue Number: close #xxx