Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](dump) do not report success if dumping FE image fails #37508

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

dataroaring
Copy link
Contributor

@dataroaring dataroaring commented Jul 9, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@dataroaring
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39817 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4b0adc8991516dbd631234fd9de9fe6c026acf49, data reload: false

------ Round 1 ----------------------------------
q1	17601	4338	4306	4306
q2	2022	193	183	183
q3	10447	1179	1151	1151
q4	10198	694	751	694
q5	7494	2662	2626	2626
q6	223	138	138	138
q7	953	591	602	591
q8	9217	2062	2078	2062
q9	8663	6466	6508	6466
q10	9017	3719	3713	3713
q11	440	242	239	239
q12	581	223	225	223
q13	18064	2976	2998	2976
q14	268	221	232	221
q15	532	483	483	483
q16	528	384	373	373
q17	961	702	604	604
q18	8028	7454	7354	7354
q19	7429	1488	1497	1488
q20	642	325	332	325
q21	5015	3261	3858	3261
q22	394	344	340	340
Total cold run time: 118717 ms
Total hot run time: 39817 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4442	4232	4238	4232
q2	372	275	263	263
q3	2988	2927	2925	2925
q4	1974	1668	1718	1668
q5	5607	5513	5472	5472
q6	226	128	133	128
q7	2220	1873	1851	1851
q8	3261	3430	3414	3414
q9	8672	8839	8781	8781
q10	4073	3767	3798	3767
q11	606	500	519	500
q12	812	642	652	642
q13	16933	3136	3194	3136
q14	312	280	276	276
q15	535	486	476	476
q16	492	428	430	428
q17	1811	1525	1505	1505
q18	8094	8092	7838	7838
q19	1813	1695	1721	1695
q20	2139	1876	1884	1876
q21	8727	4812	4752	4752
q22	647	547	583	547
Total cold run time: 76756 ms
Total hot run time: 56172 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173898 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4b0adc8991516dbd631234fd9de9fe6c026acf49, data reload: false

query1	923	383	367	367
query2	6427	2503	2454	2454
query3	6628	210	214	210
query4	25769	17517	17384	17384
query5	3675	495	486	486
query6	269	180	169	169
query7	4595	290	276	276
query8	332	310	302	302
query9	8478	2412	2409	2409
query10	570	301	275	275
query11	12077	10161	10035	10035
query12	117	84	81	81
query13	1635	377	377	377
query14	10166	7696	7516	7516
query15	237	190	180	180
query16	7088	315	299	299
query17	1355	541	519	519
query18	1147	272	266	266
query19	194	147	147	147
query20	90	79	79	79
query21	212	131	128	128
query22	4322	4156	3918	3918
query23	34037	33674	33966	33674
query24	11117	2834	2789	2789
query25	576	399	373	373
query26	701	154	148	148
query27	2261	274	280	274
query28	6106	2138	2118	2118
query29	877	645	625	625
query30	254	156	150	150
query31	982	750	755	750
query32	95	55	55	55
query33	712	289	304	289
query34	907	507	493	493
query35	692	574	567	567
query36	1149	982	983	982
query37	139	86	112	86
query38	2939	2830	2781	2781
query39	907	859	815	815
query40	199	122	118	118
query41	54	52	58	52
query42	112	98	93	93
query43	596	541	548	541
query44	1143	718	715	715
query45	193	160	162	160
query46	1074	707	719	707
query47	1848	1760	1754	1754
query48	375	296	289	289
query49	832	416	407	407
query50	768	388	392	388
query51	6819	6839	6770	6770
query52	109	92	93	92
query53	357	290	288	288
query54	877	446	440	440
query55	73	77	74	74
query56	286	267	261	261
query57	1099	1018	1039	1018
query58	254	246	233	233
query59	3405	3295	2969	2969
query60	291	283	277	277
query61	96	92	93	92
query62	782	636	630	630
query63	325	291	285	285
query64	9134	2156	1646	1646
query65	3135	3122	3083	3083
query66	722	340	346	340
query67	15357	15046	14899	14899
query68	4515	536	518	518
query69	515	332	340	332
query70	1177	1163	1140	1140
query71	392	285	310	285
query72	7388	5464	5569	5464
query73	741	331	315	315
query74	5948	5555	5575	5555
query75	3418	2643	2679	2643
query76	2481	927	930	927
query77	578	299	296	296
query78	9565	8961	8950	8950
query79	2776	522	517	517
query80	2799	480	465	465
query81	583	221	212	212
query82	859	140	132	132
query83	306	183	175	175
query84	278	89	88	88
query85	2085	322	298	298
query86	477	306	322	306
query87	3294	3093	3133	3093
query88	3554	2329	2330	2329
query89	481	386	381	381
query90	1939	185	187	185
query91	130	101	104	101
query92	61	50	49	49
query93	2859	492	490	490
query94	1351	206	214	206
query95	409	311	314	311
query96	593	259	256	256
query97	3179	2998	2976	2976
query98	221	200	207	200
query99	1573	1236	1312	1236
Total cold run time: 277597 ms
Total hot run time: 173898 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.74 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4b0adc8991516dbd631234fd9de9fe6c026acf49, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.04	0.05
query4	1.68	0.07	0.07
query5	0.49	0.48	0.49
query6	1.14	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.55	0.51	0.52
query10	0.55	0.54	0.54
query11	0.16	0.10	0.11
query12	0.15	0.12	0.12
query13	0.59	0.58	0.58
query14	0.78	0.79	0.79
query15	0.87	0.84	0.84
query16	0.36	0.38	0.41
query17	1.05	1.06	1.05
query18	0.23	0.22	0.23
query19	1.91	1.84	1.74
query20	0.01	0.01	0.01
query21	15.39	0.76	0.66
query22	4.62	6.23	1.97
query23	18.30	1.40	1.27
query24	2.11	0.24	0.21
query25	0.15	0.08	0.09
query26	0.29	0.20	0.21
query27	0.46	0.23	0.23
query28	13.25	1.02	1.00
query29	12.59	3.27	3.28
query30	0.25	0.06	0.05
query31	2.86	0.38	0.39
query32	3.28	0.48	0.48
query33	2.89	2.87	2.90
query34	16.80	4.34	4.36
query35	4.48	4.40	4.40
query36	0.65	0.48	0.47
query37	0.18	0.15	0.15
query38	0.15	0.14	0.14
query39	0.05	0.03	0.04
query40	0.15	0.13	0.12
query41	0.09	0.04	0.05
query42	0.05	0.04	0.04
query43	0.04	0.03	0.04
Total cold run time: 110.02 s
Total hot run time: 30.74 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 10, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou changed the title [fix](dump) do not report success if dumping fails [fix](dump) do not report success if dumping FE image fails Jul 10, 2024
@gavinchou gavinchou merged commit cff3f18 into apache:master Jul 10, 2024
29 of 32 checks passed
dataroaring added a commit that referenced this pull request Jul 10, 2024
## Proposed changes
pick #37508

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants