Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](timezone) make TimeUtils formatter use correct time_zone #37465

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

zclllyybb
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

All timestamp/datetime parsing in Doris is controlled by the session variable time_zone. Apply it also to interface of TimeUtils in FE.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39794 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 15a4fbe707dd44fdf009d3b99ea656027d622f23, data reload: false

------ Round 1 ----------------------------------
q1	17611	4664	4301	4301
q2	2022	197	191	191
q3	10518	1159	1064	1064
q4	10221	731	738	731
q5	7484	2703	2637	2637
q6	222	138	139	138
q7	953	632	595	595
q8	9219	2091	2066	2066
q9	9104	6502	6488	6488
q10	9020	3717	3736	3717
q11	442	232	236	232
q12	527	235	221	221
q13	17777	3018	2998	2998
q14	271	225	230	225
q15	526	487	471	471
q16	492	377	377	377
q17	974	742	671	671
q18	8052	7420	7596	7420
q19	8317	1574	1411	1411
q20	701	315	318	315
q21	4924	3822	3195	3195
q22	391	330	335	330
Total cold run time: 119768 ms
Total hot run time: 39794 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4377	4245	4256	4245
q2	364	259	268	259
q3	3109	2922	2905	2905
q4	1976	1779	1724	1724
q5	5539	5574	5465	5465
q6	226	132	136	132
q7	2284	1864	1846	1846
q8	3341	3436	3462	3436
q9	8737	8863	8821	8821
q10	4121	3823	3772	3772
q11	596	496	501	496
q12	828	683	656	656
q13	17218	3175	3197	3175
q14	320	287	267	267
q15	540	492	492	492
q16	505	437	462	437
q17	1820	1509	1494	1494
q18	8184	7919	8071	7919
q19	4204	1655	1557	1557
q20	2119	1887	1860	1860
q21	8837	4858	4799	4799
q22	671	558	543	543
Total cold run time: 79916 ms
Total hot run time: 56300 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173913 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 15a4fbe707dd44fdf009d3b99ea656027d622f23, data reload: false

query1	924	370	371	370
query2	6453	2303	2423	2303
query3	6649	203	216	203
query4	27435	17488	17411	17411
query5	3799	481	478	478
query6	269	168	159	159
query7	4592	305	304	304
query8	328	293	288	288
query9	8571	2390	2360	2360
query10	561	290	279	279
query11	11003	10106	10016	10016
query12	123	84	86	84
query13	1657	390	386	386
query14	9401	7732	7388	7388
query15	253	184	193	184
query16	7836	320	316	316
query17	1773	569	534	534
query18	2029	293	291	291
query19	196	155	157	155
query20	94	85	86	85
query21	223	131	132	131
query22	4224	4048	4214	4048
query23	34150	33814	33375	33375
query24	11839	2824	2856	2824
query25	647	445	437	437
query26	1541	168	160	160
query27	2836	326	332	326
query28	7501	2174	2136	2136
query29	1020	670	672	670
query30	252	158	154	154
query31	962	753	738	738
query32	102	60	60	60
query33	768	310	330	310
query34	966	496	503	496
query35	774	640	641	640
query36	1128	976	981	976
query37	158	83	82	82
query38	2981	2803	2853	2803
query39	916	835	830	830
query40	259	135	133	133
query41	54	54	55	54
query42	118	100	98	98
query43	554	564	513	513
query44	1203	744	745	744
query45	197	173	164	164
query46	1099	734	721	721
query47	1904	1828	1809	1809
query48	379	312	308	308
query49	1001	431	418	418
query50	767	381	398	381
query51	6833	6875	6746	6746
query52	107	97	90	90
query53	358	290	284	284
query54	942	449	469	449
query55	78	76	73	73
query56	282	274	273	273
query57	1152	1033	1054	1033
query58	260	245	265	245
query59	3416	3260	3195	3195
query60	309	282	289	282
query61	98	97	98	97
query62	624	455	443	443
query63	316	293	287	287
query64	10305	2196	1633	1633
query65	3176	3109	3121	3109
query66	1257	327	331	327
query67	15686	15072	15260	15072
query68	7766	549	553	549
query69	658	451	400	400
query70	1222	1086	1054	1054
query71	525	278	285	278
query72	8904	5376	5814	5376
query73	825	328	323	323
query74	6136	5485	5498	5485
query75	5298	2703	2659	2659
query76	5108	964	891	891
query77	764	307	301	301
query78	9600	8970	8972	8970
query79	9353	531	528	528
query80	1017	481	482	481
query81	574	219	228	219
query82	766	105	109	105
query83	353	171	163	163
query84	275	86	85	85
query85	1449	324	301	301
query86	399	299	339	299
query87	3326	3128	3179	3128
query88	5136	2488	2451	2451
query89	537	382	386	382
query90	1984	186	193	186
query91	130	107	106	106
query92	61	49	49	49
query93	6991	526	512	512
query94	1121	214	214	214
query95	409	310	311	310
query96	625	268	272	268
query97	3182	3091	3020	3020
query98	220	200	200	200
query99	1171	849	854	849
Total cold run time: 305553 ms
Total hot run time: 173913 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.93 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 15a4fbe707dd44fdf009d3b99ea656027d622f23, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.08	0.09
query5	0.50	0.47	0.51
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.55	0.50	0.50
query10	0.56	0.56	0.53
query11	0.14	0.11	0.12
query12	0.14	0.12	0.12
query13	0.59	0.59	0.58
query14	0.79	0.79	0.77
query15	0.85	0.83	0.82
query16	0.35	0.36	0.37
query17	0.96	1.01	1.02
query18	0.23	0.24	0.26
query19	1.76	1.67	1.80
query20	0.01	0.01	0.00
query21	15.39	0.79	0.66
query22	4.88	7.72	1.32
query23	18.60	1.41	1.27
query24	2.11	0.23	0.21
query25	0.15	0.08	0.09
query26	0.29	0.21	0.20
query27	0.45	0.23	0.22
query28	13.31	1.02	1.00
query29	12.61	3.31	3.28
query30	0.25	0.07	0.06
query31	2.87	0.39	0.40
query32	3.28	0.48	0.47
query33	2.93	2.88	2.89
query34	17.14	4.40	4.35
query35	4.42	4.34	4.50
query36	0.65	0.48	0.47
query37	0.18	0.16	0.15
query38	0.15	0.15	0.14
query39	0.04	0.04	0.03
query40	0.15	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.05	0.04
Total cold run time: 110.71 s
Total hot run time: 29.93 s

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39800 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21292bea5047922f2d4b75228b9e3cf0fcb18104, data reload: false

------ Round 1 ----------------------------------
q1	17634	4343	4274	4274
q2	2034	201	197	197
q3	10444	1182	1106	1106
q4	10207	841	824	824
q5	7530	2656	2664	2656
q6	220	137	137	137
q7	963	602	600	600
q8	9224	2048	2079	2048
q9	8864	6521	6553	6521
q10	8765	3717	3736	3717
q11	480	240	239	239
q12	471	229	232	229
q13	17766	2963	2932	2932
q14	267	248	244	244
q15	520	483	493	483
q16	515	386	371	371
q17	956	691	673	673
q18	8093	7425	7374	7374
q19	6423	1451	1438	1438
q20	650	333	326	326
q21	4894	3077	3150	3077
q22	379	334	338	334
Total cold run time: 117299 ms
Total hot run time: 39800 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4348	4220	4240	4220
q2	364	268	257	257
q3	2968	2803	2878	2803
q4	1972	1663	1696	1663
q5	5598	5497	5404	5404
q6	224	143	129	129
q7	2170	1857	1848	1848
q8	3322	3402	3424	3402
q9	8728	8675	8864	8675
q10	4087	3909	3757	3757
q11	567	506	542	506
q12	836	649	621	621
q13	15852	3178	3176	3176
q14	326	305	294	294
q15	530	481	475	475
q16	471	431	424	424
q17	1823	1506	1528	1506
q18	8028	7871	7781	7781
q19	1798	1681	1778	1681
q20	2107	1873	1876	1873
q21	5074	4921	4629	4629
q22	596	572	537	537
Total cold run time: 71789 ms
Total hot run time: 55661 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174980 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21292bea5047922f2d4b75228b9e3cf0fcb18104, data reload: false

query1	913	363	365	363
query2	6446	2499	2467	2467
query3	6644	205	217	205
query4	28480	17534	17353	17353
query5	3625	458	465	458
query6	254	176	158	158
query7	4585	283	278	278
query8	340	307	301	301
query9	8457	2423	2417	2417
query10	439	294	271	271
query11	10701	10161	10090	10090
query12	120	90	84	84
query13	1663	386	380	380
query14	9331	7734	7590	7590
query15	242	186	205	186
query16	7701	317	311	311
query17	1613	557	531	531
query18	1872	286	279	279
query19	208	154	162	154
query20	90	86	80	80
query21	205	132	127	127
query22	4663	4316	4049	4049
query23	34165	33610	33637	33610
query24	10893	2901	2902	2901
query25	617	417	433	417
query26	710	153	149	149
query27	2198	276	286	276
query28	6361	2167	2139	2139
query29	919	656	675	656
query30	256	155	156	155
query31	970	785	746	746
query32	104	55	58	55
query33	675	322	315	315
query34	901	495	491	491
query35	696	589	607	589
query36	1151	1001	978	978
query37	147	90	87	87
query38	3043	2887	2795	2795
query39	879	840	846	840
query40	203	121	120	120
query41	56	52	52	52
query42	116	96	100	96
query43	617	569	552	552
query44	1062	744	742	742
query45	199	169	171	169
query46	1094	693	720	693
query47	1886	1787	1808	1787
query48	369	294	292	292
query49	825	507	404	404
query50	768	381	375	375
query51	6820	6737	6835	6737
query52	104	94	100	94
query53	352	298	284	284
query54	854	438	436	436
query55	85	74	71	71
query56	294	260	265	260
query57	1163	1043	1046	1043
query58	252	257	253	253
query59	3644	3311	3382	3311
query60	308	270	282	270
query61	110	94	100	94
query62	778	654	653	653
query63	316	283	289	283
query64	9118	2228	1653	1653
query65	3158	3090	3097	3090
query66	714	324	336	324
query67	15865	15216	15135	15135
query68	8315	543	551	543
query69	743	441	390	390
query70	1239	1148	1118	1118
query71	536	275	285	275
query72	8710	5759	5322	5322
query73	1397	324	319	319
query74	6004	5604	5456	5456
query75	5097	2716	2644	2644
query76	5117	934	1003	934
query77	832	308	301	301
query78	9978	9878	8897	8897
query79	13129	523	527	523
query80	1348	510	486	486
query81	579	230	226	226
query82	726	131	127	127
query83	343	167	160	160
query84	276	84	91	84
query85	1374	319	307	307
query86	343	325	291	291
query87	3416	3127	3152	3127
query88	5503	2374	2387	2374
query89	579	391	372	372
query90	1965	190	191	190
query91	130	104	114	104
query92	60	49	48	48
query93	7516	511	503	503
query94	964	214	207	207
query95	402	316	318	316
query96	625	276	270	270
query97	3219	3038	2999	2999
query98	226	203	205	203
query99	1548	1263	1260	1260
Total cold run time: 306646 ms
Total hot run time: 174980 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.85 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21292bea5047922f2d4b75228b9e3cf0fcb18104, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.04
query4	1.68	0.08	0.08
query5	0.50	0.49	0.50
query6	1.14	0.74	0.73
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.56	0.48	0.50
query10	0.55	0.53	0.52
query11	0.16	0.11	0.11
query12	0.15	0.13	0.12
query13	0.63	0.60	0.59
query14	0.74	0.78	0.80
query15	0.85	0.83	0.82
query16	0.36	0.36	0.37
query17	1.04	1.04	1.02
query18	0.22	0.21	0.20
query19	1.89	1.84	1.75
query20	0.01	0.01	0.01
query21	15.41	0.74	0.66
query22	4.67	6.47	2.07
query23	18.31	1.41	1.29
query24	2.06	0.22	0.23
query25	0.15	0.09	0.08
query26	0.29	0.22	0.22
query27	0.46	0.23	0.22
query28	13.34	1.00	1.00
query29	12.58	3.33	3.33
query30	0.25	0.06	0.06
query31	2.86	0.39	0.39
query32	3.28	0.47	0.46
query33	2.85	2.94	2.85
query34	17.00	4.36	4.42
query35	4.43	4.43	4.39
query36	0.65	0.48	0.47
query37	0.19	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.03	0.04
query40	0.15	0.13	0.12
query41	0.10	0.04	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.03
Total cold run time: 110.24 s
Total hot run time: 30.85 s

@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40239 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 48e3a3c7e902b069de7caa6b65c4fd36c1e1844e, data reload: false

------ Round 1 ----------------------------------
q1	17945	4524	4418	4418
q2	2853	197	193	193
q3	12343	1167	1259	1167
q4	11424	716	814	716
q5	7747	2692	2611	2611
q6	224	141	138	138
q7	960	600	595	595
q8	9214	2069	2087	2069
q9	8690	6536	6563	6536
q10	8783	3804	3769	3769
q11	457	244	244	244
q12	410	234	233	233
q13	18797	2977	3010	2977
q14	282	235	232	232
q15	535	480	493	480
q16	503	381	368	368
q17	968	709	709	709
q18	8108	7633	7423	7423
q19	8561	1480	1481	1480
q20	698	328	330	328
q21	4941	3262	3219	3219
q22	397	334	339	334
Total cold run time: 124840 ms
Total hot run time: 40239 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4477	4287	4319	4287
q2	378	281	275	275
q3	2957	2774	2749	2749
q4	1904	1609	1700	1609
q5	5306	5312	5333	5312
q6	218	134	131	131
q7	2147	1752	1715	1715
q8	3193	3349	3321	3321
q9	8453	8410	8392	8392
q10	3885	3681	3717	3681
q11	608	481	502	481
q12	794	617	612	612
q13	16228	2986	3002	2986
q14	300	278	268	268
q15	542	467	488	467
q16	476	417	424	417
q17	1757	1473	1453	1453
q18	7528	7642	7355	7355
q19	1861	1561	1531	1531
q20	2016	1795	1752	1752
q21	4837	4787	4636	4636
q22	611	554	551	551
Total cold run time: 70476 ms
Total hot run time: 53981 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174429 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 48e3a3c7e902b069de7caa6b65c4fd36c1e1844e, data reload: false

query1	908	365	358	358
query2	6454	2496	2459	2459
query3	6670	204	223	204
query4	23369	17670	17253	17253
query5	4176	497	500	497
query6	277	178	153	153
query7	4587	288	288	288
query8	339	319	306	306
query9	8446	2435	2427	2427
query10	441	286	273	273
query11	11298	10288	10032	10032
query12	135	86	82	82
query13	1644	372	386	372
query14	10186	7782	7170	7170
query15	243	194	189	189
query16	7703	329	319	319
query17	1792	573	543	543
query18	1928	290	288	288
query19	205	154	158	154
query20	93	83	82	82
query21	216	133	126	126
query22	4563	4126	4112	4112
query23	33810	33781	33306	33306
query24	11945	2884	2817	2817
query25	666	395	399	395
query26	1702	153	162	153
query27	2838	275	276	275
query28	7531	2115	2088	2088
query29	1024	645	632	632
query30	293	151	153	151
query31	987	762	774	762
query32	106	55	56	55
query33	799	320	324	320
query34	907	483	490	483
query35	684	599	590	590
query36	1122	966	928	928
query37	152	78	84	78
query38	2853	2782	2769	2769
query39	846	829	818	818
query40	281	125	124	124
query41	58	55	52	52
query42	122	99	107	99
query43	582	568	570	568
query44	1261	760	755	755
query45	197	165	166	165
query46	1095	734	737	734
query47	1860	1779	1771	1771
query48	384	296	308	296
query49	1147	425	436	425
query50	770	398	398	398
query51	6947	6862	6753	6753
query52	106	95	97	95
query53	367	301	300	300
query54	968	458	462	458
query55	79	80	75	75
query56	318	295	315	295
query57	1162	1058	1042	1042
query58	277	250	252	250
query59	3653	3323	3233	3233
query60	313	270	272	270
query61	95	92	92	92
query62	803	624	675	624
query63	333	295	299	295
query64	10555	2209	1662	1662
query65	3189	3104	3128	3104
query66	1174	342	336	336
query67	15706	15058	14899	14899
query68	8594	557	557	557
query69	740	514	357	357
query70	1160	1139	1151	1139
query71	520	277	297	277
query72	8699	5730	6068	5730
query73	1643	326	327	326
query74	6124	5442	5558	5442
query75	4974	2720	2681	2681
query76	5200	998	904	904
query77	784	361	313	313
query78	11760	9426	9086	9086
query79	10782	547	531	531
query80	1423	473	484	473
query81	600	222	218	218
query82	266	135	128	128
query83	337	164	162	162
query84	286	83	91	83
query85	740	315	309	309
query86	356	299	326	299
query87	3334	3209	3106	3106
query88	5316	2378	2371	2371
query89	506	388	384	384
query90	2338	190	196	190
query91	135	105	105	105
query92	65	48	49	48
query93	4903	513	509	509
query94	1366	220	215	215
query95	410	315	317	315
query96	604	267	267	267
query97	3219	3014	2989	2989
query98	226	200	185	185
query99	1681	1253	1287	1253
Total cold run time: 306831 ms
Total hot run time: 174429 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.12 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 48e3a3c7e902b069de7caa6b65c4fd36c1e1844e, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.04
query4	1.68	0.07	0.08
query5	0.50	0.50	0.49
query6	1.14	0.74	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.55	0.48	0.49
query10	0.54	0.54	0.54
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.59
query14	0.75	0.78	0.77
query15	0.86	0.82	0.81
query16	0.36	0.36	0.37
query17	0.96	1.00	0.96
query18	0.23	0.23	0.22
query19	1.77	1.66	1.71
query20	0.01	0.01	0.01
query21	15.39	0.74	0.68
query22	4.12	6.74	2.39
query23	18.24	1.39	1.36
query24	2.12	0.23	0.23
query25	0.17	0.10	0.08
query26	0.30	0.21	0.22
query27	0.45	0.23	0.22
query28	13.29	1.00	0.99
query29	12.71	3.34	3.32
query30	0.25	0.06	0.06
query31	2.88	0.40	0.38
query32	3.27	0.49	0.47
query33	2.86	2.94	2.86
query34	17.11	4.34	4.34
query35	4.39	4.45	4.38
query36	0.66	0.46	0.48
query37	0.19	0.16	0.15
query38	0.15	0.15	0.15
query39	0.04	0.04	0.04
query40	0.15	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.58 s
Total hot run time: 31.12 s

Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@zhangstar333 zhangstar333 merged commit 1d0dea9 into apache:master Jul 11, 2024
27 of 29 checks passed
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jul 11, 2024
…e#37465)

All timestamp/datetime parsing in Doris is controlled by the session
variable `time_zone`.
Apply it also to interface of `TimeUtils` in FE.
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jul 11, 2024
…e#37465)

All timestamp/datetime parsing in Doris is controlled by the session
variable `time_zone`.
Apply it also to interface of `TimeUtils` in FE.
yiguolei pushed a commit that referenced this pull request Jul 15, 2024
…#37465) (#37652)

All timestamp/datetime parsing in Doris is controlled by the session
variable `time_zone`.
Apply it also to interface of `TimeUtils` in FE.

pick #37465
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
…e#37465)

## Proposed changes
All timestamp/datetime parsing in Doris is controlled by the session
variable `time_zone`. 
Apply it also to interface of `TimeUtils` in FE.
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
## Proposed changes
All timestamp/datetime parsing in Doris is controlled by the session
variable `time_zone`. 
Apply it also to interface of `TimeUtils` in FE.
@zclllyybb zclllyybb deleted the rm_fe_tz branch August 27, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants