-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](inverted index) mow supports index optimization #37428
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add testcase
@@ -2233,7 +2233,11 @@ Status SegmentIterator::_read_columns_by_rowids(std::vector<ColumnId>& read_colu | |||
} | |||
|
|||
for (auto cid : read_column_ids) { | |||
if (_prune_column(cid, (*mutable_columns)[cid], true, select_size)) { | |||
auto& colunm = (*mutable_columns)[cid]; | |||
if (_no_need_read_key_data(cid, colunm, select_size)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you call _no_need_read_key_data inside _prune_column?
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
TPC-H: Total hot run time: 39920 ms
|
TPC-DS: Total hot run time: 172931 ms
|
ClickBench: Total hot run time: 30.31 s
|
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39748 ms
|
TPC-DS: Total hot run time: 173776 ms
|
ClickBench: Total hot run time: 31.53 s
|
@@ -2892,11 +2919,24 @@ bool SegmentIterator::_can_opt_topn_reads() const { | |||
return false; | |||
} | |||
|
|||
if (!_col_predicates.empty() || !_col_preds_except_leafnode_of_andnode.empty()) { | |||
if (!_common_expr_ctxs_push_down.empty() || !_remaining_conjunct_roots.empty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the modifications in _can_opt_topn_reads related to mow need_read_key_data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run p0 |
run p0 |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40373 ms
|
TPC-DS: Total hot run time: 172802 ms
|
ClickBench: Total hot run time: 31.57 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. mow support no need_read_data opt. 2. mow support topN opt.
1. mow support no need_read_data opt. 2. mow support topN opt.
1. mow support no need_read_data opt. 2. mow support topN opt.
1. mow support no need_read_data opt. 2. mow support topN opt.
apache#37428 apache#37429 <!--Describe your changes.-->
Proposed changes