Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement](rpc) set grpc channel's keepAliveTime and remove proxy on InterruptedExcep… #37304

Merged
merged 9 commits into from
Jul 18, 2024
Merged

[Improvement](rpc) set grpc channel's keepAliveTime and remove proxy on InterruptedExcep… #37304

merged 9 commits into from
Jul 18, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Jul 4, 2024 •
edited
Loading

Proposed changes

  1. set grpc channel's keepAliveTime
  2. remove proxy on InterruptedException/TimeoutException to avoid channel unavailable

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

1 similar comment
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt BiteTheDDDDt changed the title set grpc channel's keepAliveTime and remove proxy on InterruptedExcep… [Improvement](rpc) set grpc channel's keepAliveTime and remove proxy on InterruptedExcep… Jul 9, 2024
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

w41ter
w41ter reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@w41ter w41ter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset LGTM

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

HappenLee
HappenLee approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 881abbb into apache:master Jul 18, 2024
27 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
@BiteTheDDDDt @dataroaring
[Improvement](rpc) set grpc channel's keepAliveTime and remove proxy …
d54dbae 
…on InterruptedExcep… (#37304)

## Proposed changes
1. set grpc channel's keepAliveTime
2. remove proxy on InterruptedException/TimeoutException to avoid
channel unavailable
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Jul 25, 2024
@BiteTheDDDDt
[Improvement](rpc) set grpc channel's keepAliveTime and remove proxy …
e59f8d0 
…on InterruptedExcep… (apache#37304)

## Proposed changes
1. set grpc channel's keepAliveTime
2. remove proxy on InterruptedException/TimeoutException to avoid
channel unavailable
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Jul 25, 2024
Merged
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Jul 25, 2024
@BiteTheDDDDt
[Improvement](rpc) set grpc channel's keepAliveTime and remove proxy …
2ced17f 
…on InterruptedExcep… (apache#37304)

## Proposed changes
1. set grpc channel's keepAliveTime
2. remove proxy on InterruptedException/TimeoutException to avoid
channel unavailable
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Jul 25, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 25, 2024
@BiteTheDDDDt
[Improvement](rpc) set grpc channel's keepAliveTime and remove proxy … (
b4e82d2 
#38381)

…on InterruptedExcep… (#37304)

## Proposed changes
1. set grpc channel's keepAliveTime
2. remove proxy on InterruptedException/TimeoutException to avoid
channel unavailable
pick from #37304
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
BiteTheDDDDt added a commit that referenced this pull request Jul 26, 2024
@BiteTheDDDDt
[Improvement](rpc) set grpc channel's keepAliveTime and remove proxy … (
71c7c77 
#38380)

…on InterruptedExcep… (#37304)

## Proposed changes
1. set grpc channel's keepAliveTime
2. remove proxy on InterruptedException/TimeoutException to avoid
channel unavailable

pick from #37304
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Aug 7, 2024
@BiteTheDDDDt
[Improvement](rpc) set grpc channel's keepAliveTime and remove proxy … (
09aa556 
apache#38380)

…on InterruptedExcep… (apache#37304)

## Proposed changes
1. set grpc channel's keepAliveTime
2. remove proxy on InterruptedException/TimeoutException to avoid
channel unavailable

pick from apache#37304
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@BiteTheDDDDt
[Improvement](rpc) set grpc channel's keepAliveTime and remove proxy … (
7b31e87 
apache#38380)

…on InterruptedExcep… (apache#37304)

## Proposed changes
1. set grpc channel's keepAliveTime
2. remove proxy on InterruptedException/TimeoutException to avoid
channel unavailable

pick from apache#37304
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman left review comments

@HappenLee HappenLee HappenLee approved these changes

@w41ter w41ter w41ter approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BiteTheDDDDt @morningman @w41ter @HappenLee @yiguolei @dataroaring