Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](fe) Fix the sql of AddPartitionRecord #37295

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[fix](fe) Fix the sql of AddPartitionRecord #37295

merged 1 commit into from
Jul 5, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Jul 4, 2024 •
edited
Loading

The range field is accidentally compared to DUMMY_ITEM.

It was introduced by #35461.

The case is improved in selectdb/ccr-syncer#118.

Affected versions:

  • 2.0.11 ~ 2.0.12
  • 2.1.4

@w41ter
[fix](fe) Fix the sql of AddPartitionRecord
5c00132 
The range field is accidentally compared to DUMMY_ITEM.

It was introduced by apache#35461.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented Jul 4, 2024

run buildall

dataroaring
dataroaring approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40121 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5c00132d5bc3a7da424891345cc35b42ba1a795c, data reload: false

------ Round 1 ----------------------------------
q1	17615	4420	4333	4333
q2	2017	192	193	192
q3	10469	1210	1240	1210
q4	10198	831	829	829
q5	7503	2667	2610	2610
q6	219	138	140	138
q7	965	601	608	601
q8	9236	2085	2086	2085
q9	8915	6484	6469	6469
q10	8960	3765	3690	3690
q11	447	243	239	239
q12	442	233	235	233
q13	19014	2977	2989	2977
q14	255	225	222	222
q15	527	482	494	482
q16	518	395	376	376
q17	977	657	610	610
q18	8056	7439	7420	7420
q19	7924	1544	1463	1463
q20	681	340	326	326
q21	4959	3274	3820	3274
q22	405	342	342	342
Total cold run time: 120302 ms
Total hot run time: 40121 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4379	4227	4289	4227
q2	364	273	268	268
q3	3166	2894	2957	2894
q4	1979	1686	1820	1686
q5	5513	5502	5466	5466
q6	234	137	140	137
q7	2260	1879	1838	1838
q8	3323	3442	3439	3439
q9	8723	8897	8736	8736
q10	4058	3737	3899	3737
q11	587	493	486	486
q12	816	681	620	620
q13	16938	3190	3161	3161
q14	319	291	285	285
q15	525	497	481	481
q16	475	425	433	425
q17	1851	1559	1513	1513
q18	8217	7923	7776	7776
q19	1780	1552	1500	1500
q20	2643	1848	1938	1848
q21	5018	4766	4938	4766
q22	609	564	560	560
Total cold run time: 73777 ms
Total hot run time: 55849 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173824 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5c00132d5bc3a7da424891345cc35b42ba1a795c, data reload: false

query1	925	375	375	375
query2	6378	2605	2529	2529
query3	6630	203	212	203
query4	19198	17399	17274	17274
query5	3762	481	462	462
query6	267	178	181	178
query7	4588	306	290	290
query8	321	288	293	288
query9	8463	2416	2382	2382
query10	581	286	292	286
query11	10657	10076	9977	9977
query12	117	87	83	83
query13	1664	372	395	372
query14	9484	7564	7639	7564
query15	228	185	185	185
query16	7711	325	305	305
query17	1522	535	522	522
query18	1813	270	269	269
query19	197	155	150	150
query20	88	82	77	77
query21	229	134	127	127
query22	4480	4082	4064	4064
query23	33590	33589	33619	33589
query24	10839	2890	2884	2884
query25	608	414	368	368
query26	713	154	152	152
query27	2274	329	333	329
query28	5966	2160	2166	2160
query29	875	648	619	619
query30	274	156	161	156
query31	968	739	756	739
query32	97	55	53	53
query33	670	285	278	278
query34	888	481	478	478
query35	744	609	647	609
query36	1114	968	982	968
query37	140	79	80	79
query38	2970	2850	2849	2849
query39	880	827	892	827
query40	215	129	122	122
query41	52	51	50	50
query42	115	96	101	96
query43	615	565	571	565
query44	1058	722	723	722
query45	185	160	164	160
query46	1075	726	756	726
query47	1896	1759	1786	1759
query48	376	308	296	296
query49	864	412	415	412
query50	761	385	389	385
query51	6983	6702	6710	6702
query52	101	94	96	94
query53	366	294	282	282
query54	855	440	447	440
query55	72	75	72	72
query56	288	265	261	261
query57	1131	1048	1088	1048
query58	251	262	247	247
query59	3464	3332	3248	3248
query60	290	275	280	275
query61	129	93	92	92
query62	571	442	454	442
query63	320	288	280	280
query64	8566	2283	1804	1804
query65	3179	3093	3083	3083
query66	746	326	323	323
query67	15359	14977	14962	14962
query68	4562	515	531	515
query69	655	470	320	320
query70	1199	1109	1083	1083
query71	362	274	270	270
query72	7751	5314	5524	5314
query73	750	320	373	320
query74	5891	5692	5433	5433
query75	3400	2640	2694	2640
query76	2331	934	867	867
query77	673	299	288	288
query78	9394	9162	9210	9162
query79	2037	513	520	513
query80	1020	456	470	456
query81	558	214	216	214
query82	622	104	104	104
query83	288	169	166	166
query84	258	89	82	82
query85	1662	282	287	282
query86	454	305	322	305
query87	3301	3146	3061	3061
query88	4017	2352	2359	2352
query89	476	373	390	373
query90	1755	187	184	184
query91	125	99	170	99
query92	62	46	46	46
query93	1754	492	495	492
query94	1099	215	201	201
query95	397	312	309	309
query96	600	262	260	260
query97	3187	3035	3033	3033
query98	223	194	192	192
query99	1286	849	841	841
Total cold run time: 264945 ms
Total hot run time: 173824 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.91 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5c00132d5bc3a7da424891345cc35b42ba1a795c, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.22	0.04	0.04
query4	1.69	0.07	0.07
query5	0.49	0.47	0.48
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.06	0.04	0.05
query9	0.55	0.50	0.48
query10	0.54	0.54	0.53
query11	0.16	0.11	0.12
query12	0.15	0.11	0.11
query13	0.59	0.58	0.59
query14	0.80	0.80	0.77
query15	0.85	0.81	0.80
query16	0.36	0.37	0.37
query17	1.04	1.04	0.95
query18	0.23	0.24	0.23
query19	1.90	1.85	1.73
query20	0.01	0.00	0.00
query21	15.39	0.74	0.64
query22	4.40	6.35	2.33
query23	18.33	1.33	1.21
query24	2.19	0.22	0.22
query25	0.14	0.08	0.08
query26	0.31	0.20	0.21
query27	0.46	0.23	0.23
query28	13.20	1.02	1.00
query29	12.63	3.34	3.29
query30	0.25	0.06	0.05
query31	2.88	0.39	0.39
query32	3.30	0.48	0.48
query33	2.95	2.90	2.93
query34	17.12	4.36	4.35
query35	4.45	4.47	4.41
query36	0.64	0.47	0.49
query37	0.18	0.15	0.15
query38	0.16	0.16	0.15
query39	0.04	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.04	0.06
query42	0.05	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 110.28 s
Total hot run time: 30.91 s

@w41ter w41ter merged commit 41501d9 into apache:master Jul 5, 2024
28 of 31 checks passed
@w41ter w41ter deleted the fix_add_partition_record branch July 5, 2024 02:00
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Jul 5, 2024
@w41ter
[fix](fe) Fix the sql of AddPartitionRecord
35d54fe 
Cherry-pick apache#37295.

The range field is accidentally compared to DUMMY_ITEM.

It was introduced by apache#35461.
This was referenced Jul 5, 2024
Draft
Merged
dataroaring pushed a commit that referenced this pull request Jul 5, 2024
@w41ter
[fix](fe) Fix the sql of AddPartitionRecord (#37341)
7ce4a42 
Cherry-pick #37295

The range field is accidentally compared to DUMMY_ITEM.

It was introduced by #35461.
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@w41ter @dataroaring
[fix](fe) Fix the sql of AddPartitionRecord (#37295)
06110cc 
The range field is accidentally compared to DUMMY_ITEM.

It was introduced by #35461.
@w41ter w41ter removed the dev/2.0.x label Jul 29, 2024
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w41ter @doris-robot @gavinchou @dataroaring