(cloud-merge) Support shadow tablet to do cumulative compaction in cloud mode #37293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params) { | ||
| Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params, |
There was a problem hiding this comment.
warning: function '_convert_historical_rowsets' exceeds recommended size/complexity thresholds [readability-function-size]
Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params,
^Additional context
be/src/cloud/cloud_schema_change_job.cpp:216: 172 lines including whitespace and comments (threshold 80)
Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params,
^
|
run buildall |
| } | ||
|
|
||
| Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params) { | ||
| Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params, |
There was a problem hiding this comment.
warning: function '_convert_historical_rowsets' exceeds recommended size/complexity thresholds [readability-function-size]
Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params,
^Additional context
be/src/cloud/cloud_schema_change_job.cpp:214: 172 lines including whitespace and comments (threshold 80)
Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params,
^
|
run buildall |
TPC-H: Total hot run time: 40097 ms |
TPC-DS: Total hot run time: 173080 ms |
ClickBench: Total hot run time: 30.24 s |
Lchangliang
changed the title
luwei16
reviewed
Jul 9, 2024
luwei16
reviewed
Jul 9, 2024
| } | ||
|
|
||
| Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params) { | ||
| Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params, |
There was a problem hiding this comment.
warning: function '_convert_historical_rowsets' exceeds recommended size/complexity thresholds [readability-function-size]
Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params,
^Additional context
be/src/cloud/cloud_schema_change_job.cpp:224: 172 lines including whitespace and comments (threshold 80)
Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params,
^
| } | ||
|
|
||
| Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params) { | ||
| Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params, |
There was a problem hiding this comment.
warning: function '_convert_historical_rowsets' exceeds recommended size/complexity thresholds [readability-function-size]
Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params,
^Additional context
be/src/cloud/cloud_schema_change_job.cpp:222: 173 lines including whitespace and comments (threshold 80)
Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParams& sc_params,
^
gavinchou
reviewed
Jul 28, 2024
gavinchou
reviewed
Jul 28, 2024
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java
Outdated
Show resolved
Hide resolved
gavinchou
reviewed
Jul 28, 2024
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java
Outdated
Show resolved
Hide resolved
gavinchou
reviewed
Jul 28, 2024
fe/fe-core/src/main/java/org/apache/doris/alter/CloudSchemaChangeJobV2.java
Show resolved
Hide resolved
gavinchou
reviewed
Jul 28, 2024
| LOG.warn("tryTimes:{}, onCancel exception:", tryTimes, e); | ||
| } | ||
| sleepSeveralSeconds(); | ||
| tryTimes++; |
There was a problem hiding this comment.
What if it tries to abort the same tablet job multiple times?
There was a problem hiding this comment.
Ms will check the message <origin_idx, shadow_idx, origin_tablet, shadow_tablet>. If it's not match, skip the request.
gavinchou
reviewed
Jul 28, 2024
| ((CloudInternalCatalog) Env.getCurrentInternalCatalog()) | ||
| .removeSchemaChangeJob(dbId, tableId, baseIndexId, partitionId, baseTabletId); | ||
| } | ||
| } |
There was a problem hiding this comment.
log here:
- which table/index has been processed (id name etc.)
- how many talbets have been processed here.
and, what if it tries to abort the same tablet job multiple times?
There was a problem hiding this comment.
Ms will check the message <origin_idx, rollup_idx, origin_tablet, rollup_tablet>. If it's not match, skip the request.
gavinchou
reviewed
Jul 28, 2024
gavinchou
reviewed
Jul 28, 2024
| if (recorded_job.has_schema_change() && request->action() == FinishTabletJobRequest::COMMIT && | ||
| !check_compaction_input_verions(compaction, recorded_job)) { | ||
| SS << "Check compaction input versions failed in schema change. input_version_start=" | ||
| << compaction.input_versions(0) << " input_version_end=" << compaction.input_versions(1) |
There was a problem hiding this comment.
SS typo? it should be lowercase
There was a problem hiding this comment.
#define SS (ss << &FILE[get_file_name_offset(FILE)] << ":" << LINE << " ")
gavinchou
reviewed
Jul 28, 2024
gavinchou
reviewed
Jul 28, 2024
Lchangliang
force-pushed
the
dev-0628-sc
branch
from
59894ff
to
130c04e
Compare
|
run buildall |
Lchangliang
force-pushed
the
dev-0628-sc
branch
from
130c04e
to
65ae146
Compare
|
run buildall |
TPC-H: Total hot run time: 41877 ms |
TPC-DS: Total hot run time: 170147 ms |
ClickBench: Total hot run time: 30.76 s |
|
run p0 |
luwei16
approved these changes
Aug 2, 2024
|
PR approved by anyone and no changes requested. |
gavinchou
approved these changes
Aug 2, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
gavinchou
added a commit
to gavinchou/doris
that referenced
this pull request
Aug 4, 2024
…on in cloud mode (apache#37293)" This reverts commit b58b9e4.
dataroaring
pushed a commit
that referenced
this pull request
Aug 4, 2024
…on in cloud mode (#37293)" (#38828) We have to figure out why it causes a SEGV when running cloud_p0 later ``` #0 doris::cloud::TabletCompactionJobPB::_internal_input_versions(int) const /root/doris/cloud/../gensrc/build/gen_cpp/cloud.pb.h:48193:33 #1 doris::cloud::MetaServiceImpl::start_tablet_job(google::protobuf::RpcController*, doris::cloud::StartTabletJobRequest const*, doris::cloud::StartTabletJobResponse*, google::protobuf::Closure*) /root/doris/cloud/src/meta-service/meta_service_job.cpp:436:9 #2 void doris::cloud::MetaServiceProxy::call_impl<doris::cloud::StartTabletJobRequest, doris::cloud::StartTabletJobResponse>(void (doris::cloud::MetaService::*)(google::protobuf::RpcController*, doris::cloud::StartTabletJobRequest const*, doris::cloud::StartTabletJobResponse*, google::protobuf::Closure*), google::protobuf::RpcController*, doris::cloud::StartTabletJobRequest const*, doris::cloud::StartTabletJobResponse*, google::protobuf::Closure*) /root/doris/cloud/src/meta-service/meta_service.h:684:13 #3 doris::cloud::MetaServiceProxy::start_tablet_job(google::protobuf::RpcController*, doris::cloud::StartTabletJobRequest const*, doris::cloud::StartTabletJobResponse*, google::protobuf::Closure*) /root/doris/cloud/src/meta-service/meta_service.h:478:9 #4 doris::cloud::MetaService::CallMethod(google::protobuf::MethodDescriptor const*, google::protobuf::RpcController*, google::protobuf::Message const*, google::protobuf::Message*, google::protobuf::Closure*) /root/doris/gensrc/build/gen_cpp/cloud.pb.cc:0:7 ``` This PR also add some FE log
TangSiyang2001
pushed a commit
to TangSiyang2001/doris
that referenced
this pull request
Aug 19, 2024
…oud mode (apache#37293) In cloud mode, when do schema change, shadow tablet encounters -235 because it cant do cumulative compaction in the case of a large number of loads. And it will prevents the user from continuing to loads. Implementation details: 1. When start schema change, record the end convert rowset version `alter_version` into SchemaChangeJob. 2. For origin tablet, only can do base compaction in [0, `alter_version`] and do cumulative compaction in (`alter_version`, N]. can not do compaction across `alter_verison` such as compaction [a, `alter_version` + n]. 3. For shadow tablet, cannot do base compaction and and do cumulative compaction in (`alter_version`, N]. 4. When the schema change failed because FE or BE coredump, it will retry. When retry the schema change, it will get the `alter_version` from meta_serive, and continue to do it. 5. When finish the schema change job or cancel it, we need to clear the schema change job. Before this pr, it will cover by next schema change.
TangSiyang2001
pushed a commit
to TangSiyang2001/doris
that referenced
this pull request
Aug 19, 2024
…oud mode (apache#37293) In cloud mode, when do schema change, shadow tablet encounters -235 because it cant do cumulative compaction in the case of a large number of loads. And it will prevents the user from continuing to loads. Implementation details: 1. When start schema change, record the end convert rowset version `alter_version` into SchemaChangeJob. 2. For origin tablet, only can do base compaction in [0, `alter_version`] and do cumulative compaction in (`alter_version`, N]. can not do compaction across `alter_verison` such as compaction [a, `alter_version` + n]. 3. For shadow tablet, cannot do base compaction and and do cumulative compaction in (`alter_version`, N]. 4. When the schema change failed because FE or BE coredump, it will retry. When retry the schema change, it will get the `alter_version` from meta_serive, and continue to do it. 5. When finish the schema change job or cancel it, we need to clear the schema change job. Before this pr, it will cover by next schema change.
gavinchou
pushed a commit
that referenced
this pull request
Aug 27, 2024
…mpaction during schema change in cloud mode (#39558) ## Proposed changes In cloud mode, when do schema change, shadow tablet encounters -235 because it cant do cumulative compaction in the case of a large number of loads. And it will prevents the user from continuing to loads. Implementation details: 1. When start schema change, record the end convert rowset version `alter_version` into SchemaChangeJob. 2. For origin tablet, only can do base compaction in [0, `alter_version`] and do cumulative compaction in (`alter_version`, N]. can not do compaction across `alter_verison` such as compaction [a, `alter_version` + n]. 3. For shadow tablet, cannot do base compaction and and do cumulative compaction in (`alter_version`, N]. 4. When the schema change failed because FE or BE coredump, it will retry. When retry the schema change, it will get the `alter_version` from meta_serive, and continue to do it. 5. When finish the schema change job or cancel it, we need to clear the schema change job. Before this pr, it will cover by next schema change. co-author(main author): @Lchangliang original PR: #37293 --------- Co-authored-by: Lightman <[email protected]>
gavinchou
pushed a commit
that referenced
this pull request
Sep 11, 2024
…mpaction during schema change in cloud mode (#39558) In cloud mode, when do schema change, shadow tablet encounters -235 because it cant do cumulative compaction in the case of a large number of loads. And it will prevents the user from continuing to loads. Implementation details: 1. When start schema change, record the end convert rowset version `alter_version` into SchemaChangeJob. 2. For origin tablet, only can do base compaction in [0, `alter_version`] and do cumulative compaction in (`alter_version`, N]. can not do compaction across `alter_verison` such as compaction [a, `alter_version` + n]. 3. For shadow tablet, cannot do base compaction and and do cumulative compaction in (`alter_version`, N]. 4. When the schema change failed because FE or BE coredump, it will retry. When retry the schema change, it will get the `alter_version` from meta_serive, and continue to do it. 5. When finish the schema change job or cancel it, we need to clear the schema change job. Before this pr, it will cover by next schema change. co-author(main author): @Lchangliang original PR: #37293 --------- Co-authored-by: Lightman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cloud mode, when do schema change, shadow tablet encounters -235 because it cant do cumulative compaction in the case of a large number of loads. And it will prevents the user from continuing to loads.
Implementation details:
alter_versioninto SchemaChangeJob.alter_version] and do cumulative compaction in (alter_version, N]. can not do compaction acrossalter_verisonsuch as compaction [a,alter_version+ n].alter_version, N].alter_versionfrom meta_serive, and continue to do it.