-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](trino-connector) Fix the problem of reading the DATE
type from Trino too slowly
#37266
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39876 ms
|
TPC-DS: Total hot run time: 172354 ms
|
ClickBench: Total hot run time: 30.73 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…m Trino too slowly (#37266) Previously, we use `LocalDate.parse(DateTimeUtils.printDate(block.getInt(position, 0)), DateTimeFormatter.ISO_DATE)` to handle DATE type from Trino. Now, we use `LocalDate.ofEpochDay(block.getInt(position, 0))` to handle DATE type from Trino. This will result in a 20-fold speed improvement.
Previously, we use
LocalDate.parse(DateTimeUtils.printDate(block.getInt(position, 0)), DateTimeFormatter.ISO_DATE)
to handle DATE type from Trino.Now, we use
LocalDate.ofEpochDay(block.getInt(position, 0))
to handle DATE type from Trino.This will result in a 20-fold speed improvement.