[Improvement](ObjectStorage) Retry when encountering TooManyRequest response #37199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 39989 ms |
TPC-DS: Total hot run time: 172722 ms |
ClickBench: Total hot run time: 30.9 s |
gavinchou
reviewed
Jul 4, 2024
be/src/io/fs/s3_file_reader.cpp
Outdated
| @@ -187,16 +139,10 @@ void S3FileReader::_collect_profile_before_close() { | |||
| ADD_TIMER(_profile, s3_profile_name); | |||
| RuntimeProfile::Counter* total_get_request_counter = | |||
| ADD_CHILD_COUNTER(_profile, "TotalGetRequest", TUnit::UNIT, s3_profile_name); | |||
| RuntimeProfile::Counter* too_many_request_err_counter = | |||
There was a problem hiding this comment.
do not remove these profile items
gavinchou
requested changes
Jul 4, 2024
gavinchou
requested changes
Jul 13, 2024
be/src/util/s3_util.cpp
Outdated
| long attemptedRetries) const override { | ||
| if (attemptedRetries < m_maxRetries && | ||
| error.GetResponseCode() == Aws::Http::HttpResponseCode::TOO_MANY_REQUESTS) { | ||
| return true; |
There was a problem hiding this comment.
We should record something here if we are doing retry.
e.g. a retry counter or something useful for us to observe the status of requesting the object storage service.
be/src/io/fs/s3_file_reader.cpp
Outdated
| } | ||
| return Status::OK(); | ||
| // clang-format off | ||
| auto resp = client->get_object( { .bucket = _bucket, .key = _key, }, |
There was a problem hiding this comment.
Considering create a new client with CustomRetryStrategy which can carry enough context
such as number retires and duration of all retires.
gavinchou
changed the title
|
run buildall |
TPC-H: Total hot run time: 40081 ms |
TPC-DS: Total hot run time: 173745 ms |
ClickBench: Total hot run time: 30.51 s |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #pragma once | ||
|
|
||
| #include <aws/core/client/AWSError.h> |
There was a problem hiding this comment.
warning: 'aws/core/client/AWSError.h' file not found [clang-diagnostic-error]
#include <aws/core/client/AWSError.h>
^|
|
||
| #pragma once | ||
|
|
||
| #include <aws/core/client/AWSError.h> |
There was a problem hiding this comment.
warning: 'aws/core/client/AWSError.h' file not found [clang-diagnostic-error]
#include <aws/core/client/AWSError.h>
^
|
run beut |
|
run feut |
|
run cloudut |
|
run buildall |
TPC-H: Total hot run time: 40348 ms |
TPC-DS: Total hot run time: 173237 ms |
ClickBench: Total hot run time: 30.68 s |
platoneko
previously approved these changes
Jul 16, 2024
ByteYue
force-pushed
the
retry_for_429
branch
2 times, most recently
from
926d517
to
07ff178
Compare
|
run buildall |
1 similar comment
|
run buildall |
|
run buildall |
|
run buildall |
gavinchou
requested changes
Jul 17, 2024
|
run buildall |
gavinchou
approved these changes
Jul 18, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Yukang-Lian
approved these changes
Jul 18, 2024
platoneko
approved these changes
Jul 18, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 19, 2024
…esponse (#37199) We can do retry for 429 using the embedded utility of corresponding sdk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We can do retry for 429 using the embedded utility of corresponding sdk.