Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](serde) support json string format with escaped charactors #37176

Merged
merged 5 commits into from
Jul 4, 2024
Merged

[improve](serde) support json string format with escaped charactors #37176

merged 5 commits into from
Jul 4, 2024

Conversation

amorynan
Copy link
Contributor

@amorynan amorynan commented Jul 2, 2024

Proposed changes

before this pr
if we use some escape from nested types like array, we can not make this string cast to json
Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

amorynan commented Jul 2, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39918 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0ab17f1885411052f6eeb730e6cba228e9538d60, data reload: false

------ Round 1 ----------------------------------
q1	17610	4745	4321	4321
q2	2022	200	193	193
q3	10473	1173	1091	1091
q4	10182	751	772	751
q5	7575	2672	2685	2672
q6	222	135	136	135
q7	956	604	609	604
q8	9234	2126	2096	2096
q9	8955	6500	6471	6471
q10	8959	3778	3764	3764
q11	494	246	247	246
q12	438	236	229	229
q13	17979	2962	2972	2962
q14	268	220	217	217
q15	532	486	497	486
q16	538	371	378	371
q17	1009	674	617	617
q18	8172	7560	7370	7370
q19	5447	1475	1489	1475
q20	678	343	333	333
q21	4904	3187	3312	3187
q22	398	341	327	327
Total cold run time: 117045 ms
Total hot run time: 39918 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4362	4330	4248	4248
q2	368	277	266	266
q3	3000	2843	2855	2843
q4	2004	1704	1696	1696
q5	5663	5538	5533	5533
q6	225	133	132	132
q7	2210	1791	1880	1791
q8	3274	3406	3425	3406
q9	8751	8702	8809	8702
q10	4170	3975	3811	3811
q11	589	486	500	486
q12	809	653	664	653
q13	15852	3178	3108	3108
q14	309	291	289	289
q15	523	498	482	482
q16	484	457	427	427
q17	1839	1526	1555	1526
q18	8303	8062	7817	7817
q19	3306	1731	1641	1641
q20	2135	1882	1843	1843
q21	4994	4966	4882	4882
q22	605	534	523	523
Total cold run time: 73775 ms
Total hot run time: 56105 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174297 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0ab17f1885411052f6eeb730e6cba228e9538d60, data reload: false

query1	908	387	368	368
query2	6448	2310	2333	2310
query3	6646	205	215	205
query4	18997	17574	17239	17239
query5	3693	489	480	480
query6	264	180	172	172
query7	4611	315	295	295
query8	311	285	281	281
query9	8747	2504	2499	2499
query10	585	311	279	279
query11	10468	9918	9933	9918
query12	113	86	105	86
query13	1631	376	364	364
query14	9582	7779	7633	7633
query15	239	185	185	185
query16	7926	263	266	263
query17	1911	546	532	532
query18	2036	273	275	273
query19	209	151	153	151
query20	87	83	81	81
query21	213	130	127	127
query22	4415	4022	3990	3990
query23	33947	33831	33543	33543
query24	11151	2883	2904	2883
query25	676	381	366	366
query26	1399	164	159	159
query27	2870	325	335	325
query28	7777	2212	2204	2204
query29	920	677	638	638
query30	258	159	154	154
query31	1011	774	764	764
query32	101	52	53	52
query33	794	290	284	284
query34	985	483	499	483
query35	770	670	663	663
query36	1168	943	978	943
query37	163	79	76	76
query38	2953	2798	2800	2798
query39	887	854	816	816
query40	204	125	120	120
query41	53	49	49	49
query42	116	96	107	96
query43	547	527	540	527
query44	1168	742	731	731
query45	193	166	165	165
query46	1085	743	729	729
query47	1848	1764	1769	1764
query48	368	317	302	302
query49	855	408	418	408
query50	763	405	392	392
query51	6937	6707	6791	6707
query52	106	98	95	95
query53	355	298	292	292
query54	863	464	454	454
query55	74	71	71	71
query56	293	261	264	261
query57	1135	1062	1077	1062
query58	288	248	260	248
query59	3381	3143	3095	3095
query60	315	272	280	272
query61	92	91	88	88
query62	605	450	454	450
query63	314	299	301	299
query64	8824	2237	1767	1767
query65	3154	3103	3084	3084
query66	829	327	349	327
query67	15543	15046	14991	14991
query68	4487	550	558	550
query69	580	387	327	327
query70	1147	1146	1071	1071
query71	415	275	273	273
query72	7046	5273	5666	5273
query73	762	337	336	336
query74	5912	5502	5420	5420
query75	3412	2688	2716	2688
query76	2799	1015	926	926
query77	564	309	309	309
query78	10354	9827	9807	9807
query79	2623	515	516	515
query80	2170	474	466	466
query81	559	217	225	217
query82	1371	108	106	106
query83	294	171	196	171
query84	256	90	85	85
query85	1485	277	267	267
query86	473	276	340	276
query87	3271	3080	3045	3045
query88	3669	2445	2427	2427
query89	464	375	392	375
query90	1765	187	184	184
query91	128	100	100	100
query92	58	49	48	48
query93	2588	531	515	515
query94	1126	188	247	188
query95	416	313	310	310
query96	593	268	266	266
query97	3210	3024	3005	3005
query98	222	196	194	194
query99	1168	829	846	829
Total cold run time: 273565 ms
Total hot run time: 174297 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.65 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0ab17f1885411052f6eeb730e6cba228e9538d60, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.06
query4	1.68	0.08	0.08
query5	0.51	0.49	0.48
query6	1.13	0.74	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.50
query10	0.54	0.55	0.54
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.60	0.60	0.59
query14	0.78	0.78	0.78
query15	0.85	0.82	0.81
query16	0.35	0.38	0.37
query17	1.05	1.04	0.98
query18	0.21	0.26	0.22
query19	1.78	1.73	1.68
query20	0.01	0.02	0.01
query21	15.39	0.81	0.67
query22	4.52	6.91	1.93
query23	18.22	1.42	1.37
query24	2.11	0.22	0.23
query25	0.15	0.09	0.09
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.24	0.99	1.01
query29	12.63	3.28	3.20
query30	0.26	0.06	0.05
query31	2.88	0.39	0.39
query32	3.26	0.49	0.47
query33	2.90	2.89	2.96
query34	17.00	4.43	4.42
query35	4.52	4.50	4.54
query36	0.66	0.47	0.47
query37	0.18	0.15	0.16
query38	0.15	0.14	0.14
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.08	0.04	0.04
query42	0.05	0.05	0.05
query43	0.05	0.03	0.04
Total cold run time: 109.54 s
Total hot run time: 30.65 s

@amorynan
Copy link
Contributor Author

amorynan commented Jul 3, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@qidaye
Copy link
Contributor

qidaye commented Jul 3, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40463 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e7d516639ccde335f9d5c3b363374675db08a726, data reload: false

------ Round 1 ----------------------------------
q1	17673	4975	4302	4302
q2	2009	185	185	185
q3	10517	1217	1043	1043
q4	10201	803	782	782
q5	7480	2869	2621	2621
q6	219	136	138	136
q7	947	589	594	589
q8	9220	2097	2074	2074
q9	9093	6494	6517	6494
q10	9060	3739	3671	3671
q11	455	229	236	229
q12	475	235	225	225
q13	18807	2926	2966	2926
q14	272	226	221	221
q15	524	467	480	467
q16	505	372	376	372
q17	979	790	598	598
q18	8096	7495	7415	7415
q19	3680	1503	1528	1503
q20	650	322	333	322
q21	4955	3949	4050	3949
q22	407	339	350	339
Total cold run time: 116224 ms
Total hot run time: 40463 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4386	4230	4281	4230
q2	380	281	277	277
q3	2935	2879	2903	2879
q4	2014	1693	1713	1693
q5	5621	5506	5453	5453
q6	229	135	131	131
q7	2194	1857	1832	1832
q8	3279	3385	3421	3385
q9	8660	8694	8726	8694
q10	4098	3847	3737	3737
q11	594	491	503	491
q12	801	647	644	644
q13	17222	3149	3179	3149
q14	301	289	263	263
q15	534	494	506	494
q16	503	461	439	439
q17	1831	1533	1510	1510
q18	8250	8065	7780	7780
q19	1804	1821	1532	1532
q20	2709	1852	1849	1849
q21	5074	5036	4846	4846
q22	671	586	545	545
Total cold run time: 74090 ms
Total hot run time: 55853 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174918 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e7d516639ccde335f9d5c3b363374675db08a726, data reload: false

query1	910	370	370	370
query2	6454	2545	2428	2428
query3	6649	206	225	206
query4	19445	17306	17048	17048
query5	3680	471	479	471
query6	251	173	167	167
query7	4580	292	292	292
query8	324	283	289	283
query9	8439	2390	2345	2345
query10	564	293	282	282
query11	10407	10061	10091	10061
query12	115	86	84	84
query13	1655	375	390	375
query14	10293	7650	7639	7639
query15	227	189	188	188
query16	7776	273	267	267
query17	1911	561	536	536
query18	1964	282	274	274
query19	203	152	157	152
query20	94	80	82	80
query21	215	132	133	132
query22	4283	4109	4051	4051
query23	34109	33601	33642	33601
query24	10627	3018	2892	2892
query25	631	405	406	405
query26	709	160	156	156
query27	2254	333	324	324
query28	6030	2147	2158	2147
query29	924	765	618	618
query30	231	155	162	155
query31	977	739	778	739
query32	94	53	56	53
query33	670	285	286	285
query34	894	484	481	481
query35	767	651	637	637
query36	1157	982	986	982
query37	138	77	80	77
query38	2985	2841	2826	2826
query39	882	847	838	838
query40	213	123	129	123
query41	52	51	54	51
query42	113	105	101	101
query43	549	567	522	522
query44	1111	754	732	732
query45	196	172	166	166
query46	1072	753	725	725
query47	1906	1768	1773	1768
query48	387	293	302	293
query49	844	410	411	410
query50	770	387	395	387
query51	6913	6802	6796	6796
query52	100	92	89	89
query53	356	291	287	287
query54	884	460	438	438
query55	72	74	72	72
query56	279	254	266	254
query57	1169	1021	1001	1001
query58	249	244	271	244
query59	3385	3309	3105	3105
query60	293	278	275	275
query61	97	90	95	90
query62	620	441	453	441
query63	314	284	286	284
query64	8525	2269	1749	1749
query65	3147	3111	3111	3111
query66	736	318	329	318
query67	15594	15067	15035	15035
query68	4570	541	552	541
query69	582	383	314	314
query70	1203	1077	1054	1054
query71	419	281	279	279
query72	8152	5707	5667	5667
query73	746	329	328	328
query74	5850	5511	5593	5511
query75	3839	2661	2658	2658
query76	2685	1018	1006	1006
query77	678	301	305	301
query78	10364	9770	9764	9764
query79	2709	523	517	517
query80	1350	479	476	476
query81	575	218	221	218
query82	835	104	103	103
query83	350	166	171	166
query84	263	85	90	85
query85	1728	289	340	289
query86	436	330	320	320
query87	3277	3088	3042	3042
query88	3764	2475	2446	2446
query89	470	395	385	385
query90	1898	188	192	188
query91	127	101	99	99
query92	58	50	50	50
query93	3267	510	501	501
query94	1233	181	182	181
query95	413	317	318	317
query96	607	272	263	263
query97	3231	3032	3011	3011
query98	223	199	198	198
query99	1217	826	826	826
Total cold run time: 271583 ms
Total hot run time: 174918 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e7d516639ccde335f9d5c3b363374675db08a726, data reload: false

query1	0.04	0.03	0.02
query2	0.08	0.03	0.04
query3	0.23	0.06	0.06
query4	1.66	0.08	0.10
query5	0.51	0.49	0.48
query6	1.13	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.55	0.47	0.49
query10	0.53	0.55	0.53
query11	0.16	0.11	0.10
query12	0.14	0.13	0.11
query13	0.59	0.58	0.58
query14	0.80	0.78	0.77
query15	0.84	0.82	0.81
query16	0.37	0.35	0.34
query17	0.99	0.99	0.98
query18	0.23	0.23	0.25
query19	1.83	1.68	1.69
query20	0.02	0.01	0.01
query21	15.44	0.80	0.66
query22	4.43	7.72	1.62
query23	18.27	1.28	1.24
query24	2.15	0.23	0.22
query25	0.15	0.08	0.09
query26	0.25	0.17	0.17
query27	0.09	0.08	0.08
query28	13.24	1.01	1.00
query29	12.64	3.28	3.30
query30	0.25	0.06	0.05
query31	2.85	0.39	0.38
query32	3.29	0.48	0.46
query33	2.88	2.90	2.88
query34	17.28	4.41	4.44
query35	4.48	4.46	4.47
query36	0.64	0.47	0.48
query37	0.19	0.16	0.15
query38	0.16	0.14	0.15
query39	0.04	0.03	0.04
query40	0.17	0.15	0.15
query41	0.09	0.05	0.04
query42	0.05	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.85 s
Total hot run time: 30.11 s

@amorynan
Copy link
Contributor Author

amorynan commented Jul 4, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

eldenmoon
eldenmoon previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by anyone and no changes requested.

@amorynan
Copy link
Contributor Author

amorynan commented Jul 4, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

qidaye
qidaye approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40732 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit efcb1284cf61f12330dd0a354995ce319bb7ab67, data reload: false

------ Round 1 ----------------------------------
q1	17918	4600	4398	4398
q2	2336	193	198	193
q3	10453	1226	1017	1017
q4	10197	935	812	812
q5	7519	2686	2662	2662
q6	222	140	139	139
q7	962	602	607	602
q8	9225	2097	2121	2097
q9	8962	6480	6532	6480
q10	8971	3765	3831	3765
q11	452	243	237	237
q12	406	252	238	238
q13	17783	3023	2992	2992
q14	269	229	225	225
q15	520	492	488	488
q16	537	377	390	377
q17	982	662	727	662
q18	8255	7444	7500	7444
q19	7744	1499	1473	1473
q20	698	328	334	328
q21	4944	3768	3871	3768
q22	408	335	336	335
Total cold run time: 119763 ms
Total hot run time: 40732 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4403	4278	4256	4256
q2	364	265	263	263
q3	2989	2761	2752	2752
q4	1858	1578	1576	1576
q5	5313	5319	5287	5287
q6	224	131	128	128
q7	2104	1741	1712	1712
q8	3227	3355	3321	3321
q9	8370	8378	8315	8315
q10	3898	3652	3711	3652
q11	581	508	500	500
q12	785	624	593	593
q13	16794	2990	3027	2990
q14	293	253	276	253
q15	530	485	483	483
q16	495	434	430	430
q17	1827	1513	1469	1469
q18	7596	7446	7390	7390
q19	1681	1708	1589	1589
q20	1955	1768	1786	1768
q21	4882	4789	4711	4711
q22	621	556	556	556
Total cold run time: 70790 ms
Total hot run time: 53994 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171138 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit efcb1284cf61f12330dd0a354995ce319bb7ab67, data reload: false

query1	912	392	370	370
query2	6458	2402	2264	2264
query3	6655	203	206	203
query4	20228	17565	17287	17287
query5	4268	490	470	470
query6	267	167	163	163
query7	4701	305	300	300
query8	299	291	273	273
query9	8574	2401	2396	2396
query10	615	319	302	302
query11	10502	10089	10047	10047
query12	132	92	82	82
query13	1654	376	375	375
query14	10121	7551	6191	6191
query15	266	186	195	186
query16	7978	319	310	310
query17	1818	577	525	525
query18	2038	281	267	267
query19	200	152	157	152
query20	91	84	85	84
query21	211	139	134	134
query22	4284	3973	3915	3915
query23	33932	33095	33219	33095
query24	11904	2843	2999	2843
query25	643	368	383	368
query26	1793	154	150	150
query27	2968	315	326	315
query28	7403	2068	2067	2067
query29	1045	633	620	620
query30	273	151	153	151
query31	959	738	748	738
query32	98	55	53	53
query33	779	293	281	281
query34	937	456	479	456
query35	756	636	612	612
query36	1128	977	930	930
query37	194	76	76	76
query38	2890	2740	2751	2740
query39	872	796	795	795
query40	284	128	127	127
query41	55	47	48	47
query42	119	100	99	99
query43	591	544	553	544
query44	1282	720	733	720
query45	197	161	161	161
query46	1082	748	719	719
query47	1846	1776	1743	1743
query48	371	297	301	297
query49	1189	437	402	402
query50	773	388	398	388
query51	6865	6745	6685	6685
query52	106	89	99	89
query53	361	298	298	298
query54	956	478	432	432
query55	74	74	75	74
query56	292	269	258	258
query57	1163	1045	1048	1045
query58	270	239	251	239
query59	3426	3206	3090	3090
query60	319	291	275	275
query61	93	89	94	89
query62	667	439	453	439
query63	329	291	288	288
query64	9852	2245	1740	1740
query65	3213	3086	3119	3086
query66	1390	336	326	326
query67	15430	15166	14901	14901
query68	5815	547	559	547
query69	682	412	346	346
query70	1168	1143	1193	1143
query71	454	273	279	273
query72	7444	5393	5657	5393
query73	783	324	324	324
query74	5913	5568	5532	5532
query75	3847	2654	2636	2636
query76	3621	978	916	916
query77	669	310	313	310
query78	9651	8835	8825	8825
query79	3160	512	527	512
query80	1453	479	470	470
query81	537	224	222	222
query82	1439	116	107	107
query83	207	177	173	173
query84	272	86	91	86
query85	1546	289	350	289
query86	464	341	321	321
query87	3235	3144	3094	3094
query88	4302	2375	2376	2375
query89	485	381	376	376
query90	1833	190	190	190
query91	129	102	103	102
query92	66	51	50	50
query93	4373	517	517	517
query94	1228	219	211	211
query95	405	326	319	319
query96	601	274	269	269
query97	3236	3005	3035	3005
query98	225	212	194	194
query99	1303	824	833	824
Total cold run time: 283987 ms
Total hot run time: 171138 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit efcb1284cf61f12330dd0a354995ce319bb7ab67, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.08
query5	0.48	0.46	0.48
query6	1.14	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.55	0.49	0.49
query10	0.54	0.54	0.56
query11	0.15	0.11	0.11
query12	0.15	0.13	0.12
query13	0.60	0.59	0.59
query14	0.76	0.79	0.77
query15	0.81	0.81	0.82
query16	0.35	0.36	0.37
query17	0.98	0.98	1.03
query18	0.25	0.25	0.23
query19	1.90	1.69	1.73
query20	0.01	0.00	0.01
query21	15.43	0.77	0.66
query22	4.15	6.99	2.25
query23	18.30	1.48	1.34
query24	2.17	0.22	0.24
query25	0.14	0.08	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.07
query28	13.21	1.02	1.01
query29	12.64	3.26	3.27
query30	0.25	0.06	0.06
query31	2.85	0.39	0.38
query32	3.28	0.49	0.47
query33	2.89	2.91	2.92
query34	17.18	4.41	4.47
query35	4.47	4.53	4.49
query36	0.66	0.47	0.48
query37	0.19	0.15	0.15
query38	0.15	0.15	0.13
query39	0.04	0.04	0.03
query40	0.16	0.14	0.15
query41	0.10	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.46 s
Total hot run time: 30.95 s

@amorynan amorynan requested a review from eldenmoon July 4, 2024 06:40
eldenmoon
eldenmoon approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 195fb73 into apache:master Jul 4, 2024
26 of 30 checks passed
@xiaokang xiaokang added the doing label Jul 15, 2024
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@amorynan @dataroaring
[improve](serde) support json string format with escaped charactors (#…
48dede2 
…37176)

before this pr
if we use some escape from nested types like array, we can not make this
string cast to json
@amorynan amorynan mentioned this pull request Aug 1, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 2, 2024
@amorynan
[pick](json-serde)pick jsonb string deserialize with spec char (#38711)
9b07cd2 
## Proposed changes
backport: #37176
Issue Number: close #xxx

<!--Describe your changes.-->
@amorynan
Copy link
Contributor Author

amorynan commented Aug 5, 2024

this pr is no need to pick for 2.0 , because it has bavior change , and it relays on #34764

@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@qidaye qidaye qidaye approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged kind/behavior-changed reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@amorynan @doris-robot @qidaye @eldenmoon @xiaokang @morningman @yiguolei @dataroaring