-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](BE) Fix inefficient problem in PriorTaskWorkerPool #37169
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40007 ms
|
TPC-DS: Total hot run time: 172508 ms
|
ClickBench: Total hot run time: 31.15 s
|
run buildall |
TPC-H: Total hot run time: 39999 ms
|
TPC-DS: Total hot run time: 175277 ms
|
ClickBench: Total hot run time: 31.07 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Proposed changes In the original implementation of `PriorTaskWorkerPool`, although multiple threads were launched in the normal pool and high prior pool, only one thread was actually working in each pool (running `normal_loop` and `high_prior_loop`, respectively). This PR fixes this issue.
Proposed changes
In the original implementation of
PriorTaskWorkerPool
, although multiple threads were launched in the normal pool and high prior pool, only one thread was actually working in each pool (runningnormal_loop
andhigh_prior_loop
, respectively). This PR fixes this issue.