-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](nereids)mv selection should rule out shadow index from schema change #37154
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39864 ms
|
TPC-DS: Total hot run time: 170712 ms
|
ClickBench: Total hot run time: 30.07 s
|
run buildall |
TPC-H: Total hot run time: 39609 ms
|
TPC-DS: Total hot run time: 172330 ms
|
ClickBench: Total hot run time: 30.05 s
|
@@ -145,7 +145,8 @@ private List<SyncMaterializationContext> createSyncMvContexts(OlapTable olapTabl | |||
keyCount += column.isKey() ? 1 : 0; | |||
} | |||
for (Map.Entry<String, Long> entry : olapTable.getIndexNameToId().entrySet()) { | |||
if (entry.getValue() != baseIndexId) { | |||
long indexId = entry.getValue(); | |||
if (indexId != baseIndexId && !olapTable.isShadowIndex(indexId)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add some comment to explain shadowIndex
run buildall |
TPC-H: Total hot run time: 40563 ms
|
TPC-DS: Total hot run time: 171283 ms
|
ClickBench: Total hot run time: 30.9 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…hange (apache#37154) schema change would introduce a shadow index. MV selection should rule out the shadow index.
schema change would introduce a shadow index. MV selection should rule out the shadow index.
Issue Number: close #xxx