[opt](iceberg)Add a new appearance to display the pushDown count
#37046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 39917 ms |
TPC-DS: Total hot run time: 175038 ms |
ClickBench: Total hot run time: 30.27 s |
morningman
reviewed
Jul 1, 2024
| @@ -1800,6 +1802,10 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) { | |||
| description = {"强制使用jni方式读取外表", "Force the use of jni mode to read external table"}) | |||
| private boolean forceJniScanner = false; | |||
|
|
|||
| @VariableMgr.VarAttr(name = OPTIMIZE_PUSH_DOWN_COUNT, | |||
| description = {"对`COUNT`使用下推进行优化", "Optimize `COUNT` using pushdown"}) | |||
There was a problem hiding this comment.
Suggested change
| description = {"对`COUNT`使用下推进行优化", "Optimize `COUNT` using pushdown"}) | |
| description = {"对外表启用 count(*) 下推优化", "enable count(*) pushdown optimization for external table"}) |
| @@ -1800,6 +1802,10 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) { | |||
| description = {"强制使用jni方式读取外表", "Force the use of jni mode to read external table"}) | |||
| private boolean forceJniScanner = false; | |||
|
|
|||
| @VariableMgr.VarAttr(name = OPTIMIZE_PUSH_DOWN_COUNT, | |||
| description = {"对`COUNT`使用下推进行优化", "Optimize `COUNT` using pushdown"}) | |||
| private boolean optimizePushDownCount = true; | |||
There was a problem hiding this comment.
Suggested change
| private boolean optimizePushDownCount = true; | |
| private boolean enableCountPushDownForExternalTable = true; |
| @@ -584,6 +584,8 @@ public class SessionVariable implements Serializable, Writable { | |||
|
|
|||
| public static final String FORCE_JNI_SCANNER = "force_jni_scanner"; | |||
|
|
|||
| public static final String OPTIMIZE_PUSH_DOWN_COUNT = "optimize_push_down_count"; | |||
There was a problem hiding this comment.
Suggested change
| public static final String OPTIMIZE_PUSH_DOWN_COUNT = "optimize_push_down_count"; | |
| public static final String ENABLE_COUNT_PUSH_DOWN_FOR_EXTERNAL_TABLE = "enable_count_push_down_for_external_table"; |
|
run buildall |
TPC-H: Total hot run time: 39741 ms |
TPC-DS: Total hot run time: 170556 ms |
ClickBench: Total hot run time: 31.22 s |
wuwenchi
force-pushed
the
fix-add-iceberg-cnt-para
branch
from
d5d4796
to
e3e0a31
Compare
|
run buildall |
TPC-H: Total hot run time: 39825 ms |
TPC-DS: Total hot run time: 174416 ms |
ClickBench: Total hot run time: 31.01 s |
|
run feut |
wuwenchi
force-pushed
the
fix-add-iceberg-cnt-para
branch
from
e3e0a31
to
bbf8e3b
Compare
|
run buildall |
TPC-H: Total hot run time: 40072 ms |
TPC-DS: Total hot run time: 172313 ms |
ClickBench: Total hot run time: 30.77 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zddr
approved these changes
Jul 8, 2024
morningman
force-pushed
the
fix-add-iceberg-cnt-para
branch
from
bbf8e3b
to
db6737f
Compare
|
run buildall |
TPC-H: Total hot run time: 39766 ms |
TPC-DS: Total hot run time: 174489 ms |
ClickBench: Total hot run time: 30.33 s |
morningman
approved these changes
Jul 10, 2024
zy-kkk
approved these changes
Jul 10, 2024
yiguolei
pushed a commit
that referenced
this pull request
Jul 16, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…pache#37046) ## Proposed changes 1. When the count can be pushed down, the specific data will be displayed later. ``` | pushdown agg=COUNT (1) | ``` 2. Add a session variable `enable_count_push_down_for_external_table ` to control whether a pushdown count operation is required. Default is `true`; ``` mysql> show variables like 'enable_count_push_down_for_external_table'; +-------------------------------------------+-------+---------------+---------+ | Variable_name | Value | Default_Value | Changed | +-------------------------------------------+-------+---------------+---------+ | enable_count_push_down_for_external_table | false | true | 1 | +-------------------------------------------+-------+---------------+---------+ 1 row in set (0.02 sec) ```
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…37046) ## Proposed changes 1. When the count can be pushed down, the specific data will be displayed later. ``` | pushdown agg=COUNT (1) | ``` 2. Add a session variable `enable_count_push_down_for_external_table ` to control whether a pushdown count operation is required. Default is `true`; ``` mysql> show variables like 'enable_count_push_down_for_external_table'; +-------------------------------------------+-------+---------------+---------+ | Variable_name | Value | Default_Value | Changed | +-------------------------------------------+-------+---------------+---------+ | enable_count_push_down_for_external_table | false | true | 1 | +-------------------------------------------+-------+---------------+---------+ 1 row in set (0.02 sec) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
enable_count_push_down_for_external_tableto control whether a pushdown count operation is required. Default istrue;