-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix]thread pool resource leak #36990
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 40746 ms
|
TPC-DS: Total hot run time: 172943 ms
|
ClickBench: Total hot run time: 30.76 s
|
run buildall |
TPC-H: Total hot run time: 39861 ms
|
TPC-DS: Total hot run time: 175036 ms
|
ClickBench: Total hot run time: 30.87 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run buildall |
TPC-H: Total hot run time: 39581 ms
|
TPC-DS: Total hot run time: 171928 ms
|
ClickBench: Total hot run time: 30.56 s
|
run buildall |
TPC-H: Total hot run time: 39763 ms
|
TPC-DS: Total hot run time: 174453 ms
|
ClickBench: Total hot run time: 30.9 s
|
PR approved by at least one committer and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Proposed changes 1. When the thread pool is not needed, you need to manually close the thread pool. 2. Before rolling back, we need to abort the existing task. 3. Add some exception information
Proposed changes