Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.1](cherry-pick) partial update should not read old fileds from rows with delete sign (#36210) #36755

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

zhannngchen
Copy link
Contributor

cherry-pick #36210

…rows with delete sign (apache#36210)

Issue Number: close apache#34296

1. When partial update filling in the missing fields, if a load job
previously wrote data with a delete sign, it will also read out the data
in the column with the delete sign, so that the newly written data will
also become invisible
2. This problem was fixed in apache#24877, but was introduced again in apache#26721,
and was never found because the case was changed to the wrong output in
3. The fix in apache#24877 didn't take into account the handling of concurrent
conflicts in the publish phase, the current PR adds this part of the
handling, and adds the corresponding case.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhannngchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.34% (9148/25172)
Line Coverage: 27.87% (74581/267616)
Region Coverage: 26.78% (38473/143648)
Branch Coverage: 23.47% (19489/83040)
Coverage Report: http://coverage.selectdb-in.cc/coverage/971b84155dbe811d2c06b91e479d91266b91839f_971b84155dbe811d2c06b91e479d91266b91839f/report/index.html

@zhannngchen zhannngchen merged commit 6ec9a73 into apache:branch-2.1 Jun 24, 2024
19 of 21 checks passed
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants