[branch-2.1](routine-load) fix be core when partial table load failed #35622
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| st = consumer_grp->start_all(ctx, kafka_pipe); | ||
| if (!st.ok()) { | ||
| multi_table_pipe->handle_consume_finished(); | ||
| HANDLE_MULTI_TABLE_ERROR(st, "consuming failed"); |
There was a problem hiding this comment.
warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
HANDLE_MULTI_TABLE_ERROR(st, "consuming failed");
^Additional context
be/src/runtime/routine_load/routine_load_task_executor.cpp:322: expanded from macro 'HANDLE_MULTI_TABLE_ERROR'
if (UNLIKELY(!_status_.ok() && !_status_.is<PUBLISH_TIMEOUT>())) { \
^be/src/common/compiler_util.h:35: expanded from macro 'UNLIKELY'
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^| st = multi_table_pipe->request_and_exec_plans(); | ||
| if (!st.ok()) { | ||
| multi_table_pipe->handle_consume_finished(); | ||
| HANDLE_MULTI_TABLE_ERROR(st, "multi tables task executes plan error"); |
There was a problem hiding this comment.
warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
HANDLE_MULTI_TABLE_ERROR(st, "multi tables task executes plan error");
^Additional context
be/src/runtime/routine_load/routine_load_task_executor.cpp:322: expanded from macro 'HANDLE_MULTI_TABLE_ERROR'
if (UNLIKELY(!_status_.ok() && !_status_.is<PUBLISH_TIMEOUT>())) { \
^be/src/common/compiler_util.h:35: expanded from macro 'UNLIKELY'
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^| // need memory order | ||
| multi_table_pipe->handle_consume_finished(); | ||
| HANDLE_ERROR(kafka_pipe->finish(), "finish multi table task failed"); | ||
| } else { | ||
| // start to consume, this may block a while | ||
| HANDLE_ERROR(consumer_grp->start_all(ctx, kafka_pipe), "consuming failed"); |
There was a problem hiding this comment.
warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
HANDLE_ERROR(consumer_grp->start_all(ctx, kafka_pipe), "consuming failed");
^Additional context
be/src/runtime/routine_load/routine_load_task_executor.cpp:312: expanded from macro 'HANDLE_ERROR'
if (UNLIKELY(!_status_.ok() && !_status_.is<PUBLISH_TIMEOUT>())) { \
^be/src/common/compiler_util.h:35: expanded from macro 'UNLIKELY'
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^
Proposed changes
#34712