[fix](auto-partition) fix auto partition load lost data in multi sender #35287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41439 ms |
TPC-DS: Total hot run time: 169335 ms |
ClickBench: Total hot run time: 30.86 s |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41270 ms |
TPC-DS: Total hot run time: 171379 ms |
ClickBench: Total hot run time: 30.47 s |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41401 ms |
TPC-DS: Total hot run time: 168916 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.17 s |
zclllyybb
reviewed
May 27, 2024
| @@ -19,7 +19,7 @@ import groovy.io.FileType | |||
| import java.nio.file.Files | |||
| import java.nio.file.Paths | |||
|
|
|||
| suite("multi_thread_load", "p1,nonConcurrent") { // stress case should use resource fully | |||
| suite("multi_thread_load") { | |||
There was a problem hiding this comment.
please revert this line change
|
PR approved by anyone and no changes requested. |
kaijchen
commented
May 27, 2024
regression-test/suites/partition_p1/auto_partition/sql/multi_thread_load.groovy
Outdated
Show resolved
Hide resolved
…hread_load.groovy
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40475 ms |
TPC-DS: Total hot run time: 172477 ms |
ClickBench: Total hot run time: 30.56 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
May 30, 2024
…er (apache#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace apache#34740 Co-authored-by: zhaochangle <[email protected]>
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
May 30, 2024
…er (apache#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace apache#34740 Co-authored-by: zhaochangle <[email protected]>
yiguolei
pushed a commit
that referenced
this pull request
May 31, 2024
…er (#35287) (#35630) ## Proposed changes Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Backport #35287 Co-authored-by: zhaochangle <[email protected]>
dataroaring
pushed a commit
that referenced
this pull request
May 31, 2024
…er (#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace #34740 Co-authored-by: zhaochangle <[email protected]>
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Jun 19, 2024
…er (apache#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace apache#34740 Co-authored-by: zhaochangle <[email protected]>
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Jun 20, 2024
…er (apache#35287) (apache#35630) ## Proposed changes Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Backport apache#35287 Co-authored-by: zhaochangle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change
use_cntmechanism for incremental (auto partition) channels and streams, it's now dynamically counted.Use
close_wait()of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams.Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table.
Replace #34740
Co-authored-by: zhaochangle [email protected]
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...