Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement](rpc) should print fe address in error msg during thrift rpc call #33381

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Apr 8, 2024

Proposed changes

We often meet this ERROR, but we do not know the FE address from the error, and has to go to BE and analysis log.

Need add the fe address to the error msg.

Exception:
java.sql.SQLException: errCode = 2, detailMessage = (172.30.0.24)[CANCELLED]failed to call frontend service, reason: Internal error processing fetchSchemaTableData
at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
at com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:953)
at com.mysql.cj.jdbc.ClientPreparedStatement.execute(ClientPreparedStatement.java:371)
at org.apache.doris.regression.util.JdbcUtils$_executeToList_closure1.doCall(JdbcUtils.groovy:31)
at sun.reflect.GeneratedMethodAccessor13.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:343)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:328)
at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaCla

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yiguolei
Copy link
Contributor Author

yiguolei commented Apr 8, 2024

run buildall

Copy link
Contributor

github-actions bot commented Apr 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.59% (8889/24976)
Line Coverage: 27.34% (73007/267014)
Region Coverage: 26.51% (37734/142348)
Branch Coverage: 23.32% (19231/82468)
Coverage Report: http://coverage.selectdb-in.cc/coverage/29af17500183fed8e934601d4552d5ff1f610310_29af17500183fed8e934601d4552d5ff1f610310/report/index.html

Copy link
Contributor

github-actions bot commented Apr 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 272d58a into apache:master Apr 8, 2024
26 of 30 checks passed
yiguolei added a commit that referenced this pull request Apr 8, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants